Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wang Ming <machel@vivo.com>
To:     Jay Vosburgh <j.vosburgh@gmail.com>,
        Andy Gospodarek <andy@greyhouse.net>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Yufeng Mo <moyufeng@huawei.com>,
        Guangbin Huang <huangguangbin2@huawei.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     opensource.kernel@vivo.com, Wang Ming <machel@vivo.com>
Subject: [PATCH net v1] net:bonding:Fix error checking for debugfs_create_dir()
Date:   Thu, 13 Jul 2023 11:35:54 +0800
Message-Id: <20230713033607.12804-1-machel@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?34KInPvA0g6483uUp/FL/ePs3lWa4tlZ1KTqgyKBctdzPD7DSdIEUm8i9Wtj?=
 =?us-ascii?Q?WEd3dH0yNYwkewHRoFFb0NsAOYUNUmEOjR4sgPakD0UCgCA7dJGiSf4wHIKV?=
 =?us-ascii?Q?FyGpNRYxPVB3KZahRClzksemaoVpXToJPrn1yn/t40eCH+pJv+ngbarJbPLI?=
 =?us-ascii?Q?hfAIkvA1jjmwjcWj75RZIcvYqc8iZ7qo/wfgqHfDbv1YbdwrpzUXCm0UIfus?=
 =?us-ascii?Q?6jRmhLwEXBMDDc3w+oW4xW/fTf0mRIZeBTk3gOO0ONVhJHIPEtyAcQ37RB1Q?=
 =?us-ascii?Q?29w0yGz8UEJILvdwEEjPcSFdxQPdZaVAxEK9t2fYtK5ZEnCSM0MIUE8X9PjY?=
 =?us-ascii?Q?qIMKLyegtNEEGVjOu/Z2P23AI5Z0RkxQa3HP43nv98zNXhH/6xH6+ipoXr2N?=
 =?us-ascii?Q?V7qUW5r2BG6d1ePSP7e5FTIrTWEVhnEnhzdADy8FiiyiNTUfaBde/GAXS1sT?=
 =?us-ascii?Q?P0jx9zD4cRjnjv18TBIms7z5M5In4qZX1pZooVwgdManfngFyXdYdvf0YvbI?=
 =?us-ascii?Q?pckm/d+aTmOc36yrMSeUTLEj6EZUVOO9i6ls13ND0RPejWusrIH2nOB50ZWD?=
 =?us-ascii?Q?F+g1CFhb00Mpr7poBCQWcmg6ywtFD2IKScO5S8XcQDA5quIusDisBs2C5cvM?=
 =?us-ascii?Q?1wV+9aQLNTeuGgQq8oA9KtsWIPs6Ny/N2SaEkJRa1Fr+bnMT+1p+GXyj67hc?=
 =?us-ascii?Q?Zt4oR2c0G9BgNnGUQc5Cb3LABPGHNsBCTRMAJTP1TE56bg+xps+7f/O6LXE7?=
 =?us-ascii?Q?kktkc2WWEQ9Xz1Z5cauEWqBW4zoolVLMqmNBx/11NhK8xxPBQTah7scNU6wO?=
 =?us-ascii?Q?QgIGxmQiyfIIfs8Y+/BmnrchQG8epL/U+3LiZRn8Ek7oybzyzRZNXP9ug4MH?=
 =?us-ascii?Q?wwsO5oUZI5BCy1wscUNO2uPPX/LxTvbPGsg7nzc5CmYNA9YXesUAtyDZzvHL?=
 =?us-ascii?Q?KG0xxN97/v1Qrs+FTPaVckzCTAMybP8CO8Qzx1km8j0aNozxhbnBbmEwQq7K?=
 =?us-ascii?Q?RGQPikl0ZTbP4n/iaHN7KBAP2ZOYuvZQHT/jfVW9hMpvEY572bEqM3IWAsoY?=
 =?us-ascii?Q?GvKaeypQEdlXIsOSSTWAy98+bho226eSD0VkbTq6OSeddtws42HrC6Zqbd1v?=
 =?us-ascii?Q?3z4Og06HZ9wbBAPS+a/rSG1ZDjwtxa5cyPNYqWPqWSVvjwbY3926SdujEkPb?=
 =?us-ascii?Q?jA+hka5qjv+7TJrdYbDeJK9CicduKkT40iTfIRTRw/hdpdmWBs/mGQRk1boJ?=
 =?us-ascii?Q?nD+9vefS6uE60Oxmr4aTOzWRUenAiK+vhp2W0xc9M3ZNe2hkSmsMIGwFyXaa?=
 =?us-ascii?Q?yLNPLSD1Fu8zIeqGlfmHJbT6HQMS0nLorAzC7J8PRjYsn16l1Sxu1DorR/FN?=
 =?us-ascii?Q?aIdexPFZFxyLx+RQINW1fSv88oql32mNDm6GUPYKRQbqv5yyteb1ox9D4sJ0?=
 =?us-ascii?Q?6XGqXo/bKhnfZWWfZhWmE9titrutxQ2oNXB8M2ZjCJwiCWh5CP/SRmW+vpVn?=
 =?us-ascii?Q?MCfxlV8lqHqZoaG3gKmLJFdN1GhQqFw/ksKJeh3xX9y8DpnanceIaST8OY3A?=
 =?us-ascii?Q?LDSq/G3V2lwI/ZSQWzhrucA2/705pRCXLFZcg3ri?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cf575fd8-ac0d-47df-628c-08db83525098
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3743.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 03:36:16.9493
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0dtRJZXkCtCb2A1YQfW+7o9udPN6R1WBwMxIQL9ugk8h26i5Sdyw9bRuFeAEoP9VWHGlCGbPhW1u4JHrpJoVDA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR06MB5608
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The debugfs_create_dir() function returns error pointers,
it never returns NULL. Most incorrect error checks were fixed,
but the one in bond_create_debugfs() was forgotten.

Fix the remaining error check.

Signed-off-by: Wang Ming <machel@vivo.com>

Fixes: 52333512701b ("net: bonding: remove unnecessary braces")
---
 drivers/net/bonding/bond_debugfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/bonding/bond_debugfs.c b/drivers/net/bonding/bond_debugfs.c
index 594094526648..d4a82f276e87 100644
--- a/drivers/net/bonding/bond_debugfs.c
+++ b/drivers/net/bonding/bond_debugfs.c
@@ -88,7 +88,7 @@ void bond_create_debugfs(void)
 {
 	bonding_debug_root = debugfs_create_dir("bonding", NULL);
 
-	if (!bonding_debug_root)
+	if (IS_ERR(bonding_debug_root))
 		pr_warn("Warning: Cannot create bonding directory in debugfs\n");
 }
 
-- 
2.25.1