Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <670a325f-f066-d146-f738-e5db1ca029ee@infradead.org>
Date:   Wed, 12 Jul 2023 20:21:05 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH 12/20] bcache: move closures to lib/
Content-Language: en-US
To:     Kent Overstreet <kent.overstreet@linux.dev>,
        linux-bcachefs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Kent Overstreet <kent.overstreet@gmail.com>,
        Coly Li <colyli@suse.de>
References: <20230712211115.2174650-1-kent.overstreet@linux.dev>
 <20230712211115.2174650-13-kent.overstreet@linux.dev>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20230712211115.2174650-13-kent.overstreet@linux.dev>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

LGTM.
I have a couple of small nits below...

On 7/12/23 14:11, Kent Overstreet wrote:
> From: Kent Overstreet <kent.overstreet@gmail.com>
> 
> Prep work for bcachefs - being a fork of bcache it also uses closures
> 
> Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
> Acked-by: Coly Li <colyli@suse.de>
> ---
>  drivers/md/bcache/Kconfig                     | 10 +-----
>  drivers/md/bcache/Makefile                    |  4 +--
>  drivers/md/bcache/bcache.h                    |  2 +-
>  drivers/md/bcache/super.c                     |  1 -
>  drivers/md/bcache/util.h                      |  3 +-
>  .../md/bcache => include/linux}/closure.h     | 17 +++++----
>  lib/Kconfig                                   |  3 ++
>  lib/Kconfig.debug                             |  9 +++++
>  lib/Makefile                                  |  2 ++
>  {drivers/md/bcache => lib}/closure.c          | 35 +++++++++----------
>  10 files changed, 43 insertions(+), 43 deletions(-)
>  rename {drivers/md/bcache => include/linux}/closure.h (97%)
>  rename {drivers/md/bcache => lib}/closure.c (88%)
> 

> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index ce51d4dc68..3ee25d5dae 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1637,6 +1637,15 @@ config DEBUG_NOTIFIERS
>  	  This is a relatively cheap check but if you care about maximum
>  	  performance, say N.
>  
> +config DEBUG_CLOSURES
> +	bool "Debug closures (bcache async widgits)"

	                                   widgets

> +	depends on CLOSURES
> +	select DEBUG_FS
> +	help
> +	Keeps all active closures in a linked list and provides a debugfs
> +	interface to list them, which makes it possible to see asynchronous
> +	operations that get stuck.

Indent those 3 help text lines with 2 additional spaces, please,
as documented and as is done in (most of) the rest of this file.

With those fixed:

Reviewed-by: Randy Dunlap <rdunlap@infradead.org>

thanks.
-- 
~Randy