Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Minjie Du <duminjie@vivo.com>
To:     Jon Mason <jdmason@kudzu.us>, Dave Jiang <dave.jiang@intel.com>,
        Allen Hubbe <allenbh@gmail.com>, Minjie Du <duminjie@vivo.com>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        ntb@lists.linux.dev (open list:NTB DRIVER CORE),
        linux-kernel@vger.kernel.org (open list)
Cc:     opensource.kernel@vivo.com
Subject: [PATCH v1] dtivers: ntb: fix parameter check in perf_setup_dbgfs()
Date:   Thu, 13 Jul 2023 11:47:27 +0800
Message-Id: <20230713034728.2157-1-duminjie@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?CMghlaHCWSTYRRYUdMVFYG99P07RP4j7goJedz/nXYf7ptVQabdzEx7gmRXU?=
 =?us-ascii?Q?viJ99QPq40JbGlfl2UYUQkPNB5p4KCKLlE/zw2aV/z0LIc+rxS8ClDooZSnk?=
 =?us-ascii?Q?kTG44ZF7TMdGuZmi3Aje6ltBg8ZbOrxM4oJ5CnQPfOs15gpUOc+Rwo5oEDyP?=
 =?us-ascii?Q?pU0XLqkX3bNjqyQmT4fVkAtg6bF6g+O65YWwhtefSB6EFZT2xedaM2lVulAj?=
 =?us-ascii?Q?WmVpP8R8E9s4EZDtCNVoFsOatFYE+16uLQ4z7stQkYb6ASqC1IahwF7yqFDX?=
 =?us-ascii?Q?M8vfC24LI1yxaL6BxCznm+AD/DGq1UvePMKavyd7tLRxUzLpmAf2MuQ/ANNQ?=
 =?us-ascii?Q?199n55pPxSH2w2lUDzYtHRVtUTNCBx0+MSZaphKqlAvbJbudIX2uZMYZV2st?=
 =?us-ascii?Q?U3nKHF7METaXV0Qf4nM9TM7dh2frri5+lXw9uwccOpEL2Q3hW9YG+EWYowRp?=
 =?us-ascii?Q?kd3vuO0D+4AW3iglY4vCSbJONmRUfsZJKbcw2X2Jxq5UaDpmV2KyL+hT8uLx?=
 =?us-ascii?Q?VSQ1CMu0X/GsNl95mJ89wjb7E6PGZRkCX5KSGoULZARYZI99BswXvIE0uRm6?=
 =?us-ascii?Q?U3jXWr22JQ0ECk/pkMRGTHu8Qf2zh5vj+ZZq+zJxhWQNZTYtETQiY+Wm6YGV?=
 =?us-ascii?Q?KTOcYhOn9/0vtQsOeu93q96U947iFLCKnI8xW/qOfpZy/G2yis6b1PEwsK5O?=
 =?us-ascii?Q?vAulyoKQLe227idETKDa/IcytKcUE6rs93e58Wpq4JWG1EN9vIN343snPXS/?=
 =?us-ascii?Q?bE68kCEh32LERmh2/p1/7bLWB4RA5qXmADfE6qWkTBs/xd65pY3jt69wGP9h?=
 =?us-ascii?Q?xqwHmIBCk6tc/5kX4vzbXHaJQHAbmtAToYp9sg2j13E/djkJ/w4bdJ+QWooK?=
 =?us-ascii?Q?GEDqPDzeQETG/kWIkAMMrCSqqth7qOgVlRCpG7F009GcBqhJ0f/0/Z8algnW?=
 =?us-ascii?Q?/kZIVfabj49dI0rrY/j6rGH3p6/8M+tF6AeXqWQZczZfu3mIyTwoe5rI9MCo?=
 =?us-ascii?Q?Y4PyPo2QacVojMkz2W1T+web/L+PKy2V5LFbim55Tmjn7Ub0f0fNUmqKGQGf?=
 =?us-ascii?Q?uY5dhmdubx4Xct0FXMmBhG8l3LwySIyO2kQdW1XqVrj1c3HxT9GZCH2ULQYZ?=
 =?us-ascii?Q?eHajxp8xt/rgM7/U+M+zKop0hoE2YKY66jIE6cQGji7f12D3NcpMif1ixz0S?=
 =?us-ascii?Q?ZS6xoorW7TIfsTPJwMIBj/7afrYCBfuAZVtCTWjV9qeA6LI4AJ9061MTZWFf?=
 =?us-ascii?Q?7EELRCxMyBZ5xc/EZg13BqPCwL0xm+w7JJJnzZ0UsDEcRC6We0ewqyDDiwUi?=
 =?us-ascii?Q?LZyoSvTFMmDHwNAzY7DhEISG36EEFtP3Dc4fgcsVX8VdvJWHZDvSrGO561xH?=
 =?us-ascii?Q?voWKp0lUtERLiXcKokQKGpWJNGOlnAX1NvOnO6yRCi4vFEO/DP7r0rV80YsT?=
 =?us-ascii?Q?6tuAGUbVYqoGkwGIwYKoTt7VJEkEj/n4lgQ1/6LacKMqHvC1X91e6EQqTn51?=
 =?us-ascii?Q?Vpl0Meej4nT5Ctc1wM/jzWa6HvTh1GCYh9TzDtF2+4cwQImbET9AmoAWoGuO?=
 =?us-ascii?Q?thvP8Trjf4Xl/GsLYA8RPTQwxPl11OQrxOCdSxDn?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 55c4fd29-04bc-4fb9-cd0c-08db8353e5e1
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB5288.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 03:47:36.6752
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: l2zUcf3wLEZGquqrR6Zcj1DYKrq/+WwgPSQD8x78m1LTdsZguq5/s0dg7Z3ncO95RV4f7Ub4tDgMMOMGEoAnbg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY0PR06MB5236
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Make IS_ERR() judge the debugfs_create_dir() function return
in perf_setup_dbgfs().

Signed-off-by: Minjie Du <duminjie@vivo.com>
---
 drivers/ntb/test/ntb_perf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ntb/test/ntb_perf.c b/drivers/ntb/test/ntb_perf.c
index 65e1e5cf1..553f1f46b 100644
--- a/drivers/ntb/test/ntb_perf.c
+++ b/drivers/ntb/test/ntb_perf.c
@@ -1355,7 +1355,7 @@ static void perf_setup_dbgfs(struct perf_ctx *perf)
 	struct pci_dev *pdev = perf->ntb->pdev;
 
 	perf->dbgfs_dir = debugfs_create_dir(pci_name(pdev), perf_dbgfs_topdir);
-	if (!perf->dbgfs_dir) {
+	if (IS_ERR(perf->dbgfs_dir)) {
 		dev_warn(&perf->ntb->dev, "DebugFS unsupported\n");
 		return;
 	}
-- 
2.39.0