Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp642947rwp; Wed, 12 Jul 2023 21:07:23 -0700 (PDT) X-Google-Smtp-Source: APBJJlHYvXhNnofzL9/+U8ZDvCM8duRE1pEpRIlKsCm75W+s64tkHvAm7w/cCCNajOn9XObAyDz8 X-Received: by 2002:a05:6a21:6d87:b0:12c:f685:87e2 with SMTP id wl7-20020a056a216d8700b0012cf68587e2mr168173pzb.60.1689221243468; Wed, 12 Jul 2023 21:07:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689221243; cv=none; d=google.com; s=arc-20160816; b=JFqL9wrGdmfhVdNzEQaTnGLSB+ngLzDMqP20Zemd8E2LToDQcwpJ7j1/i/y0Y//qAh /ggMyUcrC7LdiUN1JrksVv8XszkaN36b55RkibYyIQbc4fGtswi8UQCWkWZwMkRsZbTP uudAmxhHkeCKyD/JKxVNfQ/JQliC4ouondlo+jd3PDOMnSqz3+cpfzm74Uz+oLg5oWQS WClxHwWFUU6HX5eF+sLKKx29os1T+PWMepDCIMywb0MZsJnS8NZPKCpPzvmADnWxbfbc OcrhPzAZPflFTOco/7KSsrSKQ/gJxBIsenuX3qWfXQ6H+4oWYb97163tjTmMUVgPYGxJ e+ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:dkim-signature:date; bh=vhk+LWYZuFsg6MH/5PRvcr3hByEuKg0581vbBlxGO2s=; fh=i9SMUf+QMdgPqk10IK0JOHhqt7nmQEOstVbKjKS1XCk=; b=lpwynB5BPyMDZzMeCta9oPdJNot4g8orivtNIlmkvRdyUjgLng5ZJGhey5EOD5pKVH X9xaS2pfTinZDsCoUgk5oJigCgGLONz5W4K/+rR91gJLtRkHmk6KcCuZ25AAwmlB1emd EcjuDpjx87uov1GpVt3zzRW8Uy+ySqcDoAPW6iEWgLxPbvj0y1cQv9eR7cTy4093013h 91aGFXJidXgXyXb6Z5yq5ojY9sovk8ayJWNgJqXrbyeMrxSCpsAvtNLI4BaCzwKcJmxr YmUGgknEFwf7fW4ynf7rGjbpQuRWUiLnooXVo8oOMgijuTYvqcDQMMcJTa5VakZ7xwi+ 7OBw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=dQwZB55t; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 2-20020a170902ee4200b001b8a39c6537si4315476plo.503.2023.07.12.21.07.10; Wed, 12 Jul 2023 21:07:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=dQwZB55t; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233742AbjGMDwP (ORCPT + 99 others); Wed, 12 Jul 2023 23:52:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233740AbjGMDwN (ORCPT ); Wed, 12 Jul 2023 23:52:13 -0400 Received: from out-1.mta1.migadu.com (out-1.mta1.migadu.com [IPv6:2001:41d0:203:375::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5360A1FC7 for ; Wed, 12 Jul 2023 20:52:11 -0700 (PDT) Date: Wed, 12 Jul 2023 23:52:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1689220328; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vhk+LWYZuFsg6MH/5PRvcr3hByEuKg0581vbBlxGO2s=; b=dQwZB55t2fV59oSEfoIzUoMl+9yFN2LZ/pgaPSjB10ZI5CUQGmF781qe/lVoS4zUfJKmSz VR2uImR/wNmcSvPdGliEBGIuF4V2Ps+AjAAKsVYaVt3FZ11BWKZDmWvzHOekFBR0KGGG5B eXS8Dtce+MDyhb90doooWkusAe+3eAc= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Randy Dunlap Cc: linux-bcachefs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Kent Overstreet , Coly Li Subject: Re: [PATCH 12/20] bcache: move closures to lib/ Message-ID: <20230713035204.xmaddzcdjgj3kqjw@moria.home.lan> References: <20230712211115.2174650-1-kent.overstreet@linux.dev> <20230712211115.2174650-13-kent.overstreet@linux.dev> <670a325f-f066-d146-f738-e5db1ca029ee@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <670a325f-f066-d146-f738-e5db1ca029ee@infradead.org> X-Migadu-Flow: FLOW_OUT X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 12, 2023 at 08:21:05PM -0700, Randy Dunlap wrote: > > From: Kent Overstreet > > + depends on CLOSURES > > + select DEBUG_FS > > + help > > + Keeps all active closures in a linked list and provides a debugfs > > + interface to list them, which makes it possible to see asynchronous > > + operations that get stuck. > > Indent those 3 help text lines with 2 additional spaces, please, > as documented and as is done in (most of) the rest of this file. > > With those fixed: > > Reviewed-by: Randy Dunlap Ack