Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wang Ming <machel@vivo.com>
To:     Rasesh Mody <rmody@marvell.com>,
        Sudarsana Kalluru <skalluru@marvell.com>,
        GR-Linux-NIC-Dev@marvell.com,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Krishna Gudipati <kgudipat@brocade.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     opensource.kernel@vivo.com, Wang Ming <machel@vivo.com>
Subject: [PATCH net v1] bna:Fix error checking for debugfs_create_dir()
Date:   Thu, 13 Jul 2023 13:38:08 +0800
Message-Id: <20230713053823.14898-1-machel@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?zv+qLkPiHOI32U2XpaCDn6yiVSxuOGYT0O9ECYrHzIPEnXphOm9LE1R9/f4R?=
 =?us-ascii?Q?b4mLvOjaV+OWd4USOyl4sr2sKZwJ4PHejy+XIVpEd+j9CLV1OS2W0mjolZ4K?=
 =?us-ascii?Q?Do4Djkxqjkxbrd/BUT1LW/b4zZI6MRJsCVslbFt06F04zTNpn1POPqaPJCr1?=
 =?us-ascii?Q?tpchBb4hA8GLGLnI4nMigU1dLBL4Vtra3Mbm+/lm5WTEkk/9+Wuk3VFyByVd?=
 =?us-ascii?Q?2aSaI+duESx+T58UQOqsE1XEfca5dJ0/Ego3sFyZSOW7IBQXEiImMyjYO/RV?=
 =?us-ascii?Q?nPZ84TZ6eepAzHtowm0al/5QBuNVLj+qMdgBRrSjRrb1JfUmGosPErVI0g76?=
 =?us-ascii?Q?JTz8a3hFY86AwcYVpc8U+vsGeWn8EOaZx/jgbSwk6waFRGEBpM7mqbVPjUa4?=
 =?us-ascii?Q?tloxSR7t6acgITDqHJNwiehvfVsHiXjs+og+zbIZtwKEPuiM3i31iGLAKAM/?=
 =?us-ascii?Q?ABqMydsVIybgP8x1+WBp/VFMnBO68qsZ6ve62MDWHlY14OU1C0a/aE0mPoe6?=
 =?us-ascii?Q?LJIBVW8vFWnKV3+NYXOeau8VFIg8JQBG7p41AK7qhoWfMp1YChrz6QuVLPkY?=
 =?us-ascii?Q?aRzmkey4SAOOEDyGCnrwcAXMTCAo4cumDlqBNJD25jkC6AN0hZCiZ4GdjfvE?=
 =?us-ascii?Q?KK9O/ODCDVGVMzG6XDj3CsJlHSLmFr5SAFLy73EPpi5uQPzolwyrWKvaeEO7?=
 =?us-ascii?Q?lGexHTa63cko933B7PSHzP5CqGp7g+rWfx6JhToiib+yaT06fZxZxq2EnCwZ?=
 =?us-ascii?Q?IYOpL4cgkOUcofZZN92YLbsZhpl+J0BPE4KXHw3YvQTziufLKnzUoKtD/zC0?=
 =?us-ascii?Q?m49PVNpgynhDCvtObus6ikf7ac+BR82XypVDC0pO46FFzKiZgmCglaZPGtSI?=
 =?us-ascii?Q?W6/n7+HTGOKzXADBWWcg1jvHMYFb+dg+RrTu/vElgSv308mJ7chOKFF7uo19?=
 =?us-ascii?Q?oXlD2npm93iiPviFNT+/ndaUi0QW0LCui+ApWy1OFR03UApqLPgmD/hbJhUg?=
 =?us-ascii?Q?DoW5nfYSqIGI0KUL5p7vKXRNgF5NB51W37/5wMlPAMdUperXMykN0r5oMfIU?=
 =?us-ascii?Q?x4TxneXWAAHnkBMIfHaMpscvsZ91djqGkpiPv5pIOblLQdmpH6jjSHUheUWi?=
 =?us-ascii?Q?c0olL/12jPHnPrj/uqi02Vq5YAjrZyaFdmSjpz3ZzzAm0cc/Y7mVGBxwDBZO?=
 =?us-ascii?Q?2JVv8aS33IZleZjdkG21icGjabAf/DDBYZwPxhVB9L9P7S1AKFOHXotLabSm?=
 =?us-ascii?Q?6GDw4gAEz0FKTZKj3f+n4QENPMng+BGpMFS34WyKw6NIvPxF6S696YvUh5uT?=
 =?us-ascii?Q?JZk/jMyDPV+qwrKD6arEsWLj0eCVk0viRQnHzH1if6tiilZ0wmsVw3XVesWe?=
 =?us-ascii?Q?zccJdwX6iJJrzNjXW6rpUsvSYU7SNWW4wp3B9ZXEB52aZkmcWtVx6OFbCCcX?=
 =?us-ascii?Q?qx/rQZ2bwrYupJ5V+gS17bb+TOS7mcnxdgO06p0mBzRTPjUm7dfzWSM5xNj4?=
 =?us-ascii?Q?qDe0HcgUGhRGUDdSZ0txX8jYW8hRHGvhVRPbjvsjS9YiaH3xXzbFIp+fqXdE?=
 =?us-ascii?Q?OYHtoOjrhvZtof68B4rDlrZwxkLxumFilBa7+TzH?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d6a4d0f7-bda4-42d5-023b-08db836367b3
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3743.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 05:38:37.5823
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Fm9KqmDdcAWGwx+wKAkDW9If2rLMeksJAiPYI4r2WbsMDhNlpmsBkeE/+hDZfpST8xmfnkP3fiFm5Ciw7U26bg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PUZPR06MB5827
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The debugfs_create_dir() function returns error pointers,
it never returns NULL. Most incorrect error checks were fixed,
but the one in bnad_debugfs_init() was forgotten.

Fix the remaining error check.

Signed-off-by: Wang Ming <machel@vivo.com>

Fixes: 7afc5dbde091 ("bna: Add debugfs interface.")
---
 drivers/net/ethernet/brocade/bna/bnad_debugfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/brocade/bna/bnad_debugfs.c b/drivers/net/ethernet/brocade/bna/bnad_debugfs.c
index 04ad0f2b9677..678a3668a041 100644
--- a/drivers/net/ethernet/brocade/bna/bnad_debugfs.c
+++ b/drivers/net/ethernet/brocade/bna/bnad_debugfs.c
@@ -512,7 +512,7 @@ bnad_debugfs_init(struct bnad *bnad)
 	if (!bnad->port_debugfs_root) {
 		bnad->port_debugfs_root =
 			debugfs_create_dir(name, bna_debugfs_root);
-		if (!bnad->port_debugfs_root) {
+		if (IS_ERR(bnad->port_debugfs_root)) {
 			netdev_warn(bnad->netdev,
 				    "debugfs root dir creation failed\n");
 			return;
-- 
2.25.1