Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <986bc150-1ab3-4ec1-dd76-d3be69bfcef9@kernel.org>
Date:   Thu, 13 Jul 2023 07:47:53 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] drivers: wireless: ath5k: fix parameter check in
 ath5k_debug_init_device
Content-Language: en-US
To:     Markus Elfring <Markus.Elfring@web.de>,
        Luis Chamberlain <mcgrof@kernel.org>,
        Minjie Du <duminjie@vivo.com>, linux-wireless@vger.kernel.org,
        kernel-janitors@vger.kernel.org
Cc:     opensource.kernel@vivo.com, LKML <linux-kernel@vger.kernel.org>,
        Kalle Valo <kvalo@kernel.org>,
        Nick Kossifidis <mickflemm@gmail.com>
References: <ZK7wqH86hEswxGo6@bombadil.infradead.org>
 <3e831a9c-b469-f1d3-1eaf-c9e275a74da5@web.de>
From:   Jiri Slaby <jirislaby@kernel.org>
In-Reply-To: <3e831a9c-b469-f1d3-1eaf-c9e275a74da5@web.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 12. 07. 23, 21:07, Markus Elfring wrote:
>>> +++ b/drivers/net/wireless/ath/ath5k/debug.c
>>> @@ -982,7 +982,7 @@ ath5k_debug_init_device(struct ath5k_hw *ah)
>>>   	ah->debug.level = ath5k_debug;
>>>
>>>   	phydir = debugfs_create_dir("ath5k", ah->hw->wiphy->debugfsdir);
>> -	if (!phydir)
>>> +	if (IS_ERR(phydir))
>>
>> Please use IS_ERR_OR_NULL() instead.
> 
> I find your support for consistent error detection interesting here.
> Contributors for other Linux software components provide different
> development views.

IS_ERR_OR_NULL() is almost never correct. It is used exceptionally in 
cases where one needs to distinct three states. It's not the case for 
sysfs/debugfs interfaces.

> Would a subject like “[PATCH v2] ath5k: Fix an error check in ath5k_debug_init_device()”
> be more appropriate?

Yes (pointing out specifically "()" at the end). And add the "why" part 
to the message log too, please.

thanks,
-- 
js
suse labs