Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a71ee5b3-2d17-e32f-45e1-0c351cdc501b@kernel.org>
Date:   Thu, 13 Jul 2023 08:01:46 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] TIOCSTI: always enable for CAP_SYS_ADMIN
Content-Language: en-US
To:     Samuel Thibault <samuel.thibault@ens-lyon.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Randy Dunlap <rdunlap@infradead.org>,
        Simon Brand <simon.brand@postadigitale.de>,
        Kees Cook <keescook@chromium.org>,
        linux-kernel@vger.kernel.org, Dave@mielke.cc
References: <20230710002645.v565c7xq5iddruse@begin>
From:   Jiri Slaby <jirislaby@kernel.org>
In-Reply-To: <20230710002645.v565c7xq5iddruse@begin>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10. 07. 23, 2:26, Samuel Thibault wrote:
> 83efeeeb3d04 ("tty: Allow TIOCSTI to be disabled") broke BRLTTY's
> ability to simulate keypresses on the console, thus effectively breaking
> braille keyboards of blind users.
> 
> This restores the TIOCSTI feature for CAP_SYS_ADMIN processes, which
> BRLTTY is, thus fixing braille keyboards without re-opening the security
> issue.
> 
> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> Acked-by: Kees Cook <keescook@chromium.org>
> Fixes: 83efeeeb3d04 ("tty: Allow TIOCSTI to be disabled")
> Cc: stable@vger.kernel.org

Acked-by: Jiri Slaby <jirislaby@kernel.org>

thanks,
-- 
js
suse labs