Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wang Ming <machel@vivo.com>
To:     Sathya Prakash <sathya.prakash@broadcom.com>,
        Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
        Suganath Prabu Subramani 
        <suganath-prabu.subramani@broadcom.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     opensource.kernel@vivo.com, Wang Ming <machel@vivo.com>
Subject: [PATCH v1] scsi:mpt3sas:Fix error checking for debugfs_create_dir()
Date:   Thu, 13 Jul 2023 14:01:06 +0800
Message-Id: <20230713060120.15330-1-machel@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?nxNe5d0Y7tkCkeJfLOkn7mIDxbW+QaL/NvDNyYwBnLqZ+3f167WcoJzLwSZs?=
 =?us-ascii?Q?aAcw2Ny/SCamK4nkg0AbJMXTg8/54YxUmOEBLxgYFBKEbV9uIAG1C09q+IG8?=
 =?us-ascii?Q?viNSj7LAPOKmFMwnRpCOPM8chvf4QjQsWsPXI5S/r2nX+AADO1wnXdB0XrOL?=
 =?us-ascii?Q?fbyls/GR5s9PDs1bdcpAKV9XLZ5zobwvMm5oskGRAmATzt4FEWltAkRcA58N?=
 =?us-ascii?Q?VazONX0BQ1E19b0Qhcdtfh4H4ILbTfiaItz1MERyGvqpK6rd2CRuvXb4GIp2?=
 =?us-ascii?Q?qTdScpB1z72+/7wBq+wnsdVhPUYKeziowItVNUzdIeLHYf4adR0XmusV0+HC?=
 =?us-ascii?Q?cfg7XBEw88WYkN7ujk3nkX/vytLl60EpEdYDbuQpUPHXlhO2MEflgLrTbmrG?=
 =?us-ascii?Q?dgHjp4ZaoW4HMNlMf9bbib81z7Fb9vAjxTCI21DaNOmV8/vp77qFCwBpJJmP?=
 =?us-ascii?Q?cGR7xxdR/BDvIXcc7co/iuIA6TVwHLuR4eLp9/65XmxT7mKjZ7y88khdIQ/P?=
 =?us-ascii?Q?xUdPOiu4IYL6aB0hC8x6Gest0lrsl3TZn+1E5MeEhNB1X1R7ORrPj8+FhVIN?=
 =?us-ascii?Q?joPGDlUrpNQ2kvWp2tbr+OlMIQJKPIjSNHMuvquSeU+cO+qKc/zH9gekKLiR?=
 =?us-ascii?Q?tyTyH+KM/UIkcaqF+NhTN50Yd5Y0WEm3L0T6ftNUT1iqvxnPU90UrsueRVrq?=
 =?us-ascii?Q?S3VIwl3couokuWcZy5qdMZj4CXOB3IN9bg3ESXS3Foomr0ORxULCxAV8Ch8i?=
 =?us-ascii?Q?eTKfQe7nQ20W1FQkpdZDNwpUdzTtw4WAB8gPDemnEf/mNs7B2M3pC5dfs3Ad?=
 =?us-ascii?Q?prsRnkpvptFsL0Th3BWdGLhZ+HR1SZAUwMsjwiZ2eIDN2WyL2zutNfGe3WTp?=
 =?us-ascii?Q?fSChdNeYl3M6XbGHF7pV/sP6y6DR85sABX0x+TCeKx5nwFt4mrZQvq3F2ljD?=
 =?us-ascii?Q?5Y9F8jVLyoZF3JXAon8U1iyxx8toeVZDwpUPTVPz1kIw2DlbgDB90y4HwDnN?=
 =?us-ascii?Q?4kytwLzxgOCGCMmAL2wLfJsqYDhfbXjv6Snoo1lxKD4qkRzcb+srhda+rDzt?=
 =?us-ascii?Q?KJcaNjJ5I5ErmRZxknu9ddO/nKlu/F6yrBoOr2GOBsA78h2B/SvPf326I9wr?=
 =?us-ascii?Q?bToSGd4teeTpBNi/OjLsTtb6pjr5Wwu26wp3unhHYs9iFAG/lpSffvnR1D9q?=
 =?us-ascii?Q?+M7MbEPlE4rmfG14eV9ctBkCOAxHq3PUQOmIwUDJ8XJsCQ+I0WD42onuUTWI?=
 =?us-ascii?Q?YhfLjFWdaCpT1CXJ0jGbkBv8bFy33roCE/jVZYnJotSf6jZoZk8XnaNKhc31?=
 =?us-ascii?Q?Ahixvrtlvobr9Efr+nzNdzw5e4bqb0oiWOJcaWU+XhNYbP/KQKxgNS5nYWiO?=
 =?us-ascii?Q?e5hS6T7x76fazLYLZX6ktOYbkuA3/L23FO3hmOuXTFd/xNMVD4zO0t6feqN2?=
 =?us-ascii?Q?EuatOcSORkQNVImC5ZJ8dkmffLzxo9DMeRbfGkzoJ9SCF1PETyTPh8tQy3Go?=
 =?us-ascii?Q?Sy0qciXejN9MDTcWivUrzgS7pbpts+Vnvekm32hIo63bERub31TIS3O7Vekm?=
 =?us-ascii?Q?DSSSpyyW0uo5Nd07MJIGtKau0UYa6smaOISpJ7n9?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 289dcc4e-7729-4ba1-c17a-08db8366c614
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3743.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 06:02:43.6991
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 02YUE6IecUI9zLeg1k8sa6yAQoWNIew4aYkNWqOFXluSlA9CkjhO6H04mQnOp/kh9ECtDuvZDg0kGfZDPWqkzA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR06MB5622
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The debugfs_create_dir() function returns error pointers,
it never returns NULL. Most incorrect error checks were fixed,
but the one in mpt3sas_init_debugfs() was forgotten,
the other one in mpt3sas_setup_debugfs() was forgotten.

Fix the remaining error check.

Signed-off-by: Wang Ming <machel@vivo.com>

Fixes: 2b01b293f359 ("scsi: mpt3sas: Capture IOC data for debugging purposes")
---
 drivers/scsi/mpt3sas/mpt3sas_debugfs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/mpt3sas/mpt3sas_debugfs.c b/drivers/scsi/mpt3sas/mpt3sas_debugfs.c
index a6ab1db81167..2ae7aef938d7 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_debugfs.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_debugfs.c
@@ -99,7 +99,7 @@ static const struct file_operations mpt3sas_debugfs_iocdump_fops = {
 void mpt3sas_init_debugfs(void)
 {
 	mpt3sas_debugfs_root = debugfs_create_dir("mpt3sas", NULL);
-	if (!mpt3sas_debugfs_root)
+	if (IS_ERR(mpt3sas_debugfs_root))
 		pr_info("mpt3sas: Cannot create debugfs root\n");
 }
 
@@ -124,7 +124,7 @@ mpt3sas_setup_debugfs(struct MPT3SAS_ADAPTER *ioc)
 	if (!ioc->debugfs_root) {
 		ioc->debugfs_root =
 		    debugfs_create_dir(name, mpt3sas_debugfs_root);
-		if (!ioc->debugfs_root) {
+		if (IS_ERR(ioc->debugfs_root)) {
 			dev_err(&ioc->pdev->dev,
 			    "Cannot create per adapter debugfs directory\n");
 			return;
-- 
2.25.1