Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a743d8e1-0460-775c-2a21-54a891d6a973@meta.com>
Date:   Wed, 12 Jul 2023 23:14:20 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.13.0
Subject: Re: [PATCH v2] kallsyms: strip LTO-only suffixes from promoted global
 functions
Content-Language: en-US
To:     Kees Cook <keescook@chromium.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Petr Mladek <pmladek@suse.com>, Song Liu <song@kernel.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Yonghong Song <yhs@fb.com>
Cc:     Fangrui Song <maskray@google.com>, kernel-team@fb.com,
        Leizhen <thunder.leizhen@huawei.com>,
        linux-kernel@vger.kernel.org, llvm@lists.linux.dev
References: <20230628181926.4102448-1-yhs@fb.com>
 <168920160691.3781136.7715367614867053724.b4-ty@chromium.org>
From:   Yonghong Song <yhs@meta.com>
In-Reply-To: <168920160691.3781136.7715367614867053724.b4-ty@chromium.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NnNVczE2bS9IeDJua3RWaFIvZUFwUDZXeFlWeG1XNStLWFB6ZmNCRDA5elA5?=
 =?utf-8?B?Y1o2cXMyVmNob0ZWS3BicVp5RGJXeHh0ZjY2UFRpY29mMm41MlV6QSs0Q0FW?=
 =?utf-8?B?TjlDVnl5TWlYdW1jR1I5eU5QaUJ1R2FaUmJ2K3g1UkhmekVrNnk1RlpDQXJ6?=
 =?utf-8?B?T3NncjNvYnJvV3QweE9yZ2lJc0V0YWpydDk0eUM1dUFMbFB4cHdJTmQ3aW9E?=
 =?utf-8?B?ai9JL2NjeHBBamhjZW9EWUptK1l0REl5eHlWc25yVnlUV3l6dUUxMlZ0eFZE?=
 =?utf-8?B?SVk4a2NWT1E4K1F4eVo4NmM0QXlQTHB3K2FRMWVZK1JsejZDSU9scXJ5TE5N?=
 =?utf-8?B?UjI0RFVrU0ZLTnZxR3ZjNzlkcGtUWUNhWEsvNXBwYnM5QnhGNi9naEdtd0Fx?=
 =?utf-8?B?cUJ6SU1VUWVtaldQRzNtNFhrYnFlOEhEMFBTK2tRelB1R2REeEJlbGxNck11?=
 =?utf-8?B?TjlaQmpBTERCZU9nbC8xK0wzTi82RUZQUFFheDIrTlVpVHB4NzFwYjhsa0ll?=
 =?utf-8?B?VEoxQ0xFOUVGVXd4ZHk2a1RvTWVyblN6V1ZIdUs2d0w2U0p2N29MUVFOSStq?=
 =?utf-8?B?ZC83NXBVRm1janN3UGZaVU8wM1U4RDgwVklOem5xMFFvOWdDYU50bU53UnNw?=
 =?utf-8?B?ODgvVU1jUHp3NEs4VFQwQ0FzbmZra09UZytpNmhHalptNGY4UnYxSE13RzRn?=
 =?utf-8?B?NnZlUFYzdUtaQko1THg5Y3h4SlJvaG4vVDV1L2lYR3ZrNXNINDF1M0pkN2Rq?=
 =?utf-8?B?WDlZSlRTRU4wcTZqaEo2ekNBcUFTRktmTnBwT0VvVFlQTmpuS04zZ1dzd0xq?=
 =?utf-8?B?a0NhWURFY2cyOGZiRFIvdEt2dHgwVkdmU01LREZYUldEUzNoM3A3UTluSUp6?=
 =?utf-8?B?WEtSUE1WMERkSktSNWg2WDhZTmZ3VXhMTEwxNnlCNXN0LzZGb1V0VGZSdWVS?=
 =?utf-8?B?cVpkVHVhNjdqRzZnSGs1RVZJRUd6NDI1NUttSFJhTDcxQTc0eTkwdHpGZ2Rm?=
 =?utf-8?B?L05pUnpYUlhXQ2VRcjNuTW5TR3NQOHh6OVVBWHE5QWgyckZ0ZkZPYW4vUUdY?=
 =?utf-8?B?QTdpYnNZU3R2a0t6enQ2cWhWcnNzajJ6UExTTWxGNk1sWjUwR2JOcXRIb1Vp?=
 =?utf-8?B?MllrYzlwWDUzSGxRY0VLa0w0UTNmVFlFbzc4ZEVMTi95QkdFQ2tNbEZnR1pY?=
 =?utf-8?B?OW1LSXpPcjBoSHRzeHpOcFZkdlJuaW13Z1JkTFVOdGRFK2oxaUNiNXkyZWE2?=
 =?utf-8?B?WkxqaDFEQklYWG9nUHNxVGZMeFp1K1ZVSXRMY0ZpbmNWYkh1eFZXZXFrN1lj?=
 =?utf-8?B?R3d5YVZGRTNjUWdUalAyb1VLbmNPclZ5OHRWN2ZUdGRGTVptTlhuQ2dFUXdL?=
 =?utf-8?B?dk5ad0RlWFlTVTdDWXYrVWlMc3plRldOUHJJSFFjN1cya1NaRjFLdU42Vis3?=
 =?utf-8?B?WnhCZ1pZWWtzZllqWEcyQUlhQkxCbnNFSGJYRVhhYTBIYmI0Y0E4T2doK05x?=
 =?utf-8?B?UTk3bHVmL2o2bTN3M3pDNk81bGJVcitqZXhRaHhtWFhtTkRicWNOaCt1Z0t0?=
 =?utf-8?B?ZEpFR2t1SmQ3ZzJBUVNmMWJ3dysyYjl3OUR2QWJiQUxFenhvUW5Zem1aZkwz?=
 =?utf-8?B?cDA0VDcrM0dSRWxiUWg1THhQVlRscFdFUEp6SXhyOXgvTEFRRncydE1ENzJk?=
 =?utf-8?B?MlFBSkFMZnlJOE5YSC9uNWFaRFB1WXk0aEo4dlJiVFJkU01OQkY3T2h6aE5Y?=
 =?utf-8?B?SjVVNUk5TzhOVUdzRm51RGpuUTBmMVMxV1EybE9wTjk2NlBidE0zdjhTWjh1?=
 =?utf-8?B?TlhEOE1iVHhkc1FpUkFhOEhJUmpOSDI1YVNTYno5c3F3aDV6ckRhcFp0TThm?=
 =?utf-8?B?amxwZkRBdFoweXo3SXU5MkhtWGN0eHBXbTFORkZnN05ma0d2UytTUHN4STlM?=
 =?utf-8?B?OFdpZDFSYWlraGxuczM3ZVp3alFDS3NhZXdHY0p6eFdCTVBHRWRKc1hKcjFI?=
 =?utf-8?B?RXl6N0VhS0J0NVFRRklhQzJKSzFpZDRlajR2NWh6R0E5S1ZkVFc2Uzd1QjBU?=
 =?utf-8?B?Mm1vWFlkd2hkZkUzazNjdDVYSFFPVW83NVZwQk9VajJCTHBNaUZpWGo2STAw?=
 =?utf-8?B?T0RHN3BjRi9qREZCTHFSUmNGdVYzQTZBdjVxVGpnbjdxZVhPcFBtU0RYUVpx?=
 =?utf-8?B?N0E9PQ==?=
X-OriginatorOrg: meta.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5f9edb1b-74b9-45a3-c6e2-08db83686791
X-MS-Exchange-CrossTenant-AuthSource: SN6PR1501MB2064.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 06:14:24.2272
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oY2UKxcpUA0S8pDwgr73RQVIaDmKEC50dkBYRtAYW14U+vaitLgAJEmb0UL2dAi+
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR15MB6208
X-Proofpoint-GUID: A_QONaASzyEv4YKDO8OYWwy9HcnpYEET
X-Proofpoint-ORIG-GUID: A_QONaASzyEv4YKDO8OYWwy9HcnpYEET
Content-Transfer-Encoding: 7bit
X-Proofpoint-UnRewURL: 0 URL was un-rewritten
MIME-Version: 1.0
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-13_02,2023-07-11_01,2023-05-22_02
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/12/23 3:40 PM, Kees Cook wrote:
> 
> On Wed, 28 Jun 2023 11:19:26 -0700, Yonghong Song wrote:
>> Commit 6eb4bd92c1ce ("kallsyms: strip LTO suffixes from static functions")
>> stripped all function/variable suffixes started with '.' regardless
>> of whether those suffixes are generated at LTO mode or not. In fact,
>> as far as I know, in LTO mode, when a static function/variable is
>> promoted to the global scope, '.llvm.<...>' suffix is added.
>>
>> The existing mechanism breaks live patch for a LTO kernel even if
>> no <symbol>.llvm.<...> symbols are involved. For example, for the following
>> kernel symbols:
>>    $ grep bpf_verifier_vlog /proc/kallsyms
>>    ffffffff81549f60 t bpf_verifier_vlog
>>    ffffffff8268b430 d bpf_verifier_vlog._entry
>>    ffffffff8282a958 d bpf_verifier_vlog._entry_ptr
>>    ffffffff82e12a1f d bpf_verifier_vlog.__already_done
>> 'bpf_verifier_vlog' is a static function. '_entry', '_entry_ptr' and
>> '__already_done' are static variables used inside 'bpf_verifier_vlog',
>> so llvm promotes them to file-level static with prefix 'bpf_verifier_vlog.'.
>> Note that the func-level to file-level static function promotion also
>> happens without LTO.
>>
>> [...]
> 
> Applied, thanks!
> 
> [1/1] kallsyms: strip LTO-only suffixes from promoted global functions
>        https://git.kernel.org/kees/c/8cc32a9bbf29

Thanks Kees!

> 
> Best regards,