Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp755546rwp;
        Wed, 12 Jul 2023 23:53:03 -0700 (PDT)
X-Google-Smtp-Source: APBJJlFwFEUB9eNw955+QYVcJVCu7rQumgMqPlfL6nRbwAy6QL+C0ZjmQm4oO0nS5vgjUdcz72yn
X-Received: by 2002:a0d:cb10:0:b0:57a:8de9:29e7 with SMTP id n16-20020a0dcb10000000b0057a8de929e7mr999021ywd.28.1689231182895;
        Wed, 12 Jul 2023 23:53:02 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1689231182; cv=none;
        d=google.com; s=arc-20160816;
        b=LmsQBSjcnL8dKc1ItBWbHLzfb8sn5FDOebKnsVwAHQgFEY7/Bs9CyeQHw26eYqe62S
         YJ9vDby273DG89fX+tERqLQDTiOMedqmgQxTHb/8QewbiqeN4CwCTVKGrzMpfK8lw64/
         JUtW9dpPHcNgpMafCV5eWUtxidjgFI4KAi7RgCWY4XQZp6aFVT729nlnEAz+9IP6reXE
         AdEcGX+bRlxGIbXEPUPkD/eRpm+H7uIy6i0OZsZo/qA2opaofS3IFK3/NnfopfkS3kCc
         AgfJgS1rYka8aM0H8ozBBoGhRhHv/avZRoI25HKuI8BEc6GaxLOksyTvKnFUI1vk4Nis
         Qf8w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:mime-version:user-agent:references:in-reply-to
         :subject:cc:to:from:message-id:date:dkim-signature:dkim-signature;
        bh=LQjoMOuDYWVyTBw8okmanAfIbcPTrQ1gl3sbWKCUhxY=;
        fh=MNyhopOxJgGZgAkHSUpYGCceJ8xS4MwG4SL5cMwVBJQ=;
        b=qg1+KTyVLBwul2C/NR48bHrP0ydKqMzr/iMTERT3ZlgmEFslHdKvicjaLPMN8ctUhg
         fd5RL4lEDiWXorP+90UP9RnxgJEjBme+ak902SuVeaviEmTP1tZlh1Vrpic85vBtbZBL
         AMZ8nbG4ZnuFlZMh61qIw37LGMRyg76Gf31LoRsEBc8eM2MWylPUml+Ek9HYw/qVO/2q
         spxOI/Tr/4CtcBFvi6RWm2MCumwPJQa3b0pfkCyEAK3z6vekAPRnlx6W8qyfQJtNsZd6
         1AdmAidgC955Ptikh71vS7EuUT5wz3HPtpLcXasK6ZdpopnpAOMdbIyqv9l8MVqjBo+y
         S0kw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=dXrwWQhM;
       dkim=neutral (no key) header.i=@suse.de;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
        by mx.google.com with ESMTP id x18-20020a170902b41200b001b8ac52a1b2si4472450plr.551.2023.07.12.23.52.49;
        Wed, 12 Jul 2023 23:53:02 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=dXrwWQhM;
       dkim=neutral (no key) header.i=@suse.de;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S230329AbjGMGId (ORCPT <rfc822;allen.lkml@gmail.com> + 99 others);
        Thu, 13 Jul 2023 02:08:33 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40918 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229573AbjGMGIc (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 13 Jul 2023 02:08:32 -0400
Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C322B1BC6;
        Wed, 12 Jul 2023 23:08:31 -0700 (PDT)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
        (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
         key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
        (No client certificate requested)
        by smtp-out2.suse.de (Postfix) with ESMTPS id 60D741F8D9;
        Thu, 13 Jul 2023 06:08:30 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
        t=1689228510; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
         mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=LQjoMOuDYWVyTBw8okmanAfIbcPTrQ1gl3sbWKCUhxY=;
        b=dXrwWQhMGcSaIhgFB3ZwGALWDt+omPHExLwdA0WE+EtnfRANm34FO5HMLxboq2ltsVweMi
        Dx1JeRQkaLZUwtscJr+IaFiies7a6gZabZirJzbmRR0OlglOCdzFbmrAkhyXlhrQHm3wnq
        c5F6pQZ+dvU5yg1zV8hsX7DuOx4If3M=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
        s=susede2_ed25519; t=1689228510;
        h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
         mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=LQjoMOuDYWVyTBw8okmanAfIbcPTrQ1gl3sbWKCUhxY=;
        b=Z4SirNNwXt4OQsKULKDcn4lRQ0PduBGfu7fDJ8kJ+dBfF2/Rv8JRLD32QJIQ9azxu+GY3L
        hvXnKSO0lraYG8Ag==
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
        (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
         key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
        (No client certificate requested)
        by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 24259138ED;
        Thu, 13 Jul 2023 06:08:30 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
        by imap2.suse-dmz.suse.de with ESMTPSA
        id YPLaB96Ur2TrOAAAMHmgww
        (envelope-from <tiwai@suse.de>); Thu, 13 Jul 2023 06:08:30 +0000
Date:   Thu, 13 Jul 2023 08:08:29 +0200
Message-ID: <871qhcgx7m.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Colin Ian King <colin.i.king@gmail.com>
Cc:     Ivan Orlov <ivan.orlov0322@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, Shuah Khan <shuah@kernel.org>,
        alsa-devel@alsa-project.org, linux-kselftest@vger.kernel.org,
        kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] selftests: ALSA: Fix fclose on an already fclosed file pointer
In-Reply-To: <20230712140122.457206-1-colin.i.king@gmail.com>
References: <20230712140122.457206-1-colin.i.king@gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,
        SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 12 Jul 2023 16:01:22 +0200,
Colin Ian King wrote:
> 
> In the case where a sysfs file cannot be opened the error return path
> fcloses file pointer fpl, however, fpl has already been closed in the
> previous stanza. Fix the double fclose by removing it.
> 
> Fixes: 10b98a4db11a ("selftests: ALSA: Add test for the 'pcmtest' driver")
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Thanks, applied.


Takashi