Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 13 Jul 2023 08:51:59 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Minjie Du <duminjie@vivo.com>
Cc:     Krishna Reddy <vdumpa@nvidia.com>, Joerg Roedel <joro@8bytes.org>,
        Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        "open list:TEGRA IOMMU DRIVERS" <linux-tegra@vger.kernel.org>,
        "open list:IOMMU SUBSYSTEM" <iommu@lists.linux.dev>,
        open list <linux-kernel@vger.kernel.org>,
        opensource.kernel@vivo.com
Subject: Re: [PATCH v2] iommu: remove redundant parameter check in
 tegra_smmu_debugfs_init()
Message-ID: <ZK-fD7inmxjwPyL5@orome>
References: <20230713025653.1540-1-duminjie@vivo.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="xgyxSMOb3u6QlwA/"
Content-Disposition: inline
In-Reply-To: <20230713025653.1540-1-duminjie@vivo.com>
User-Agent: Mutt/2.2.10 (2023-03-25)
Precedence: bulk


--xgyxSMOb3u6QlwA/
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Jul 13, 2023 at 10:56:53AM +0800, Minjie Du wrote:
> debugfs_create_file() will simply return early if
>  smmu->debugfs is an error pointer.

The formatting is a little weird here.

> Make smmu->debugfs check delete in tegra_smmu_debugfs_init().

I think something like this is better:

  Delete smmu->debugfs check in ...

Or perhaps combine both sentences:

  debugfs_create_file() will return early if smmu->debugfs is an error
  pointer, so an extra error check is not needed.

With that fixed:

Acked-by: Thierry Reding <treding@nvidia.com>

--xgyxSMOb3u6QlwA/
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmSvnwwACgkQ3SOs138+
s6FbVA/9FLgDdG1LKZ0l03k73D7pZ4qnDFuB6IVJdEl+WnEIIbuytEtjgVi3Qu3A
+5DGHteJ8CZAiBVtZit97kUvHSlWFvBV4Nk0wi2JMNtCZ4zhAoysEWwhlDuHqVGP
S6cDWlLP9mJqKV+K6TwONKbO1SeqcKiWPiFVuO+aqORu4KAQ2Yf71YmvaxfsTawk
UN6Fd/uLsTwnVv5/LJqJ1IUr6UbfRXbKTvlJAgcwncRE73bvI8zxt6dgFwl1WpIV
mmR9e5TPCo78r5qogRaUZPE8t8DkbRBJ4BSE/KMRyq4qxwrfAHwmJCCI3aPMHscw
Vp6QRO92vta0c/UxEIbyCvyMEG+2usGxlsYzjJNXWKXwi2MTZL/+GEhqO+FASnBL
xzRpd+3kKsoKDyTwBtN6HRrJfqtwjvYCAtq1EuZZMMXpNEZgnt5/Skt1Wo0QwYyo
UDotUuoUGECDlA/GP98R2htx7c+hIytmKV88WLK3NOL1QpnPiXHeR4h6obH7h9oc
MfgaSBN39KwsdKACFqSANMjhgJcO65apgelD0/OZDm1MHSkOsT5cPz9S4qpwtsUg
1T//VsYjA+lLfZNvoE+trCeIHqatZpAkouzJEqacc5vVGE0WqpAuDa9gvYa/MKcZ
s20oZW/FydwDx0IGCWyr3296bglGsmSicACaCVugDj5/OtuMHxs=
=oFY6
-----END PGP SIGNATURE-----

--xgyxSMOb3u6QlwA/--