Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp783576rwp; Thu, 13 Jul 2023 00:28:37 -0700 (PDT) X-Google-Smtp-Source: APBJJlFOp2DM+OiT1FaOIsoctHRAGjgPjr5Oyqi83QuodxnhRqUjKnVFjQ/zlKrUrAWfjeaiENFc X-Received: by 2002:a05:6402:b1a:b0:51b:fa0a:dc37 with SMTP id bm26-20020a0564020b1a00b0051bfa0adc37mr1109945edb.10.1689233317324; Thu, 13 Jul 2023 00:28:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689233317; cv=none; d=google.com; s=arc-20160816; b=pYyQj4sfqkM3ZgbPmvEGF7Gpv7hXzBbF+Ygzpvy1YSMqMBJ9SH4gRK/CoamUe+xgru HJOmFcBqkDBPxkJKR6PtKVTOdUdbRNP40QkHJ74YmjclePwpthGuJbdYcREIojhRpVbo PXI3TSy4gCADtQxA4JjK5czv9nKsAbxl8Bb3JPVLa1RyUqbo87Ba5d3oWjJMi7Hh/bHZ 49IBWkkGa9bff2zluH/bTz1VfwvVmkPVkMIwV2QnsDA8xFybqAnMc6EL/G8TshD3y+Jd sB6DemLG1QZw+nFITLnTI7UcoBzICpdyW7AzwQMfWVtU9ZlPy/MBXy7VjH69FEysGLWt +4VA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=ZDO68jZT0ZTH+b3zqYQI1EKldxdKdxhzMhCjT6ca8vE=; fh=RS4sSJAvXcFtJmPZOu89GKOjgD5PO/5nAqB8DgglZVc=; b=qkgLhIPjAzjtCp2tanOMyJ5IS+zv7kR03hYMfZNNcjqifTQ2/V08k5zBtN/74oGG7o z+mZoWXCuIR5vvMDGOcjF+xI/dNKAPn4OtvnqQCed+75dUYnTdHrdbnQct1OL5XxH1wL FlK4rHltmNcujiWlaA6TEwebY3Q7ypa83+/Ye8r3PnrDqNcXm41BhmAvLo2EIFL+L/p4 KD9HqWqSkHCStEdpjleSV7paXG07WWJkwRqCgOYZMbaOBCAAJVSs43P5K9Jw7o+gcU0M rBnw1I7G7VhwOdxB9xe8iK8WtO03Guk6c/1J7YGYFqETqMcOZZSK99Nkl0VRtlK5ZGF+ oRqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b="Ly/a27qb"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n19-20020aa7c693000000b0051e10991ea9si6341259edq.142.2023.07.13.00.28.13; Thu, 13 Jul 2023 00:28:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b="Ly/a27qb"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232348AbjGMHXO (ORCPT + 99 others); Thu, 13 Jul 2023 03:23:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234273AbjGMHW5 (ORCPT ); Thu, 13 Jul 2023 03:22:57 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE8F01BEC; Thu, 13 Jul 2023 00:22:55 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-4fb7769f15aso710743e87.0; Thu, 13 Jul 2023 00:22:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689232974; x=1689837774; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ZDO68jZT0ZTH+b3zqYQI1EKldxdKdxhzMhCjT6ca8vE=; b=Ly/a27qbWm3qnzDRfYBv4iH4P6cijdUjadNRwoKPK/KhYArh0x6LsU/QDC05GBtclw nESgKh9tkDdvPova6963LvehGtmrTTHXwBjx/K1/YNQnxCd1mG+2XiKXHmFnA5w8As7t OJapWE0i1xt1GlMWVZd4aIcKEdFofW21+tSVOuypoO95mH/YJ/7MZSqTJLsbwrJZEXgp LsCaEy8mJnnx2eLgLYw0YfLVC2MKdVQB/DsF/32i/Ez76hv2LhJSK4RYBaX+eTiUKhp3 hYkIJf+iXHSP4z9G0xlwztAJOa+fFFYMHSHVfxim3hT/HRJS2qGU1eUxz7d24YII0ZxI Yy4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689232974; x=1689837774; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZDO68jZT0ZTH+b3zqYQI1EKldxdKdxhzMhCjT6ca8vE=; b=d9svM6NHUje7o/cPcVNiAqxCIEfydGMaaeDJOJEcLKV+dzMn8VYn6AIm27ekhyBCCs DK9JSMCO2aTXlJUh5e+pt6JmDYkYB0N94IxQ2tlxVTklYMkSa1WovxAyZN1CdZKAP5mm h6C2TUe+7z/lVOCm1HBbbg5bSp99t5MieaBkzWueqaJnuQZwufr12iR8mQr4JHecnPGB f9J+4gQMuZUvbpgeZLCytr4y0QG0ReQg31x+l+HhjfhyvJUsqKv5x1DqPjskkwJfTX65 ut5OkHh2cFZsT7TkdKbd4SbPr1hJ0sMyKKkq7Uy5xs/PAhlZIAta7ia+6jXNKn1KS71q yVQQ== X-Gm-Message-State: ABy/qLazFQBx22PuBW7oOrBLX5dEOedM2p2PJ52cfPrV9YYcJuU819mG gdxjzJ041Fkwici7Cs1oZkcgayA08Rzfz53JawjKWi/mwCk= X-Received: by 2002:ac2:5506:0:b0:4f8:586a:8af6 with SMTP id j6-20020ac25506000000b004f8586a8af6mr498554lfk.4.1689232973781; Thu, 13 Jul 2023 00:22:53 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: linke li Date: Thu, 13 Jul 2023 15:22:42 +0800 Message-ID: Subject: Re: [PATCH] isofs: fix undefined behavior in iso_date() To: Matthew Wilcox Cc: Linke Li , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Jan Kara Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks for your reply. > This certainly fixes the problem, but wouldn't it be easier to get the > compiler to do the work for us? I don't know which solution is better, but it does avoid this problem. Like tz = (int)(signed char)p[6];