Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wang Ming <machel@vivo.com>
To:     Nilesh Javali <njavali@marvell.com>,
        GR-QLogic-Storage-Upstream@marvell.com,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     opensource.kernel@vivo.com, gregkh@linuxfoundation.org,
        error27@gmail.com, Wang Ming <machel@vivo.com>
Subject: [PATCH v1] scsi: qla2xxx: Remove error checking for debugfs_create_dir()
Date:   Thu, 13 Jul 2023 15:26:25 +0800
Message-Id: <20230713072640.1587-1-machel@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Ito6ZeeYs8mFPaYwf7C9KBUr88P7Dth029hk+24MjbB3O/6FLABOVnO4f11I?=
 =?us-ascii?Q?tDwdaRIY8QZZ6KXv3aMycvt5a5how1NxgckveYnuiSEjuClg1W+rRk3mGUc6?=
 =?us-ascii?Q?stDcGE6wqjEhHo6gOgMQcgQH7J1S0sNM1OTU9ujkluC1cDb6Fy4sdq+qMc0v?=
 =?us-ascii?Q?sJEs4+TnlKRCmIcsski4fB3Fd6a1/EboWtoYuQjYWHmAy3lXZn6/ZiwrM9lK?=
 =?us-ascii?Q?GO4tTH8uxf2G4eDUiOngpHF/d0ljzzjdlTY8BEB+akGXu5cjLN3rGkO8npNR?=
 =?us-ascii?Q?3PCn1Gls5hmLRhYcxIs1acV2w1mK2A4hmEBdVsHUIXgYqk0tWv5m4SVpiVT/?=
 =?us-ascii?Q?Zw0im4OjK8QYsRR/xJRLuL9e5OxKNX1CCKq3DgXo1HXXb8dRH9G/UVuMk+Cp?=
 =?us-ascii?Q?396Q0YgajUjvJqPTwpBphZRVVhGhB7Y4/+2S3zd8aU4L6hD7JnGMOrmEPcBS?=
 =?us-ascii?Q?PIdiWqlke0rWurWqDmNt4n4cnkuGsER+Dko/kdUNSbmD5Ckz7Dd0LXGHJnPr?=
 =?us-ascii?Q?OVZsK6WdkGlEXfkvrnAfRhaZuILEh1H694TZKruox8gwGwjg9DUrBhpapiyL?=
 =?us-ascii?Q?cXwByPmsVdJY280s2jNLfkz7D5TDDt9Ij+B6EPFGh+3Enw2CuJbGPxMOUYWD?=
 =?us-ascii?Q?/vQeHqQXPsZnrICUNN1UFCFIrjm0IAa8wtKi5aMnXO2SGI6JzfQHgmbRjJ1L?=
 =?us-ascii?Q?MfttwZVxbD9+qcdozYnmwXTdzPrF9eYkXRTq+MX/JhvrluD5kcQ34oiL2Ro/?=
 =?us-ascii?Q?XWPR2ApR4oW5WJT+1eHox9Ho77dqhAtuuYl3/dUhqDHy/v4XjlXtvH20stSj?=
 =?us-ascii?Q?iuUzpfRa1vi3ciX1foFQSdRcRjp9Ma6aMRqtxveda6+0rO+p+yrnhcje5tNL?=
 =?us-ascii?Q?CZWxboyi/J0LWUFYQHEXIeu1wOWAUrkbfO2Wl3ZwMkTQzszIOiRFtLcBOlf6?=
 =?us-ascii?Q?ZyzqO+K2y3RPTdFvAD8deXLkkI+mIcMEQfWMTMzMt4ziBugrh3CMxSTOXKxb?=
 =?us-ascii?Q?Gk/TJIowHq2ONG39CNADdKYi16TMFGNHZzIgIWskJpDeny9s/8xkZkLwWkey?=
 =?us-ascii?Q?rdRMTZjCwIp6tM6hWCEDVVpGAMK0oKrkSGC9mgVRIRUc7PYixhv7RFadGn3T?=
 =?us-ascii?Q?8HGws0y0q1kgdTMe4FzyREKYqi2MVX/ZypV2SJkrUuhPI92SS5DlNSnLH9Qy?=
 =?us-ascii?Q?8kmQtC3uIig+9OC8i2np/EQOQaoJYpQLyF6SqG0wemQRJQFOANWXBPg0CrfD?=
 =?us-ascii?Q?FoAQNzU4NshQmq/golpgMn8u3wSPIHYb0kVRpPQn7Xx1uzhcp6Uv4lOqI7Ek?=
 =?us-ascii?Q?pw3Z5hOOMKqaZnPh1fqWT3gPOlfcxOdnvIvZDTvyxRQCGjR4vyXTlD3tOrny?=
 =?us-ascii?Q?QIXbZ6fP5DiQY3PJmDnetnsJCT5YG8/fgMi1Og3uxFgk6BcryxN1fx72zaFf?=
 =?us-ascii?Q?DKCd/zIU2/mYEKJguxgHneNRU4QCitnN0RrdumJ5Oh0R+vsxRTSUYByaJNqd?=
 =?us-ascii?Q?IYJKC84EVQQJeq5ILPkmSXI0jNf/H4IviCKiX8TLiVuwDLQyx5J4r0OsvqSH?=
 =?us-ascii?Q?FTlJiYxMMQSLRxRJ3iKV9Cz7urvzQdsR3UC6ISux?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d36009a0-8c7a-4423-3f76-08db83728d2d
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3743.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 07:27:02.2610
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Cr+GiwVHPwcISUDLSIM8rNmX64RgMmCF5GXVTGzM/GbGOv+IQh63AC7aqVR9p+qt/OoSwAV6OoQkexIVQfQTow==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYSPR06MB6503
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

It is expected that most callers should _ignore_ the errors
return by debugfs_create_dir() in qla2x00_dfs_create_rport()
and qla2x00_dfs_setup().

Signed-off-by: Wang Ming <machel@vivo.com>
---
 drivers/scsi/qla2xxx/qla_dfs.c | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/drivers/scsi/qla2xxx/qla_dfs.c b/drivers/scsi/qla2xxx/qla_dfs.c
index 1925cc6897b6..8cd67092aff4 100644
--- a/drivers/scsi/qla2xxx/qla_dfs.c
+++ b/drivers/scsi/qla2xxx/qla_dfs.c
@@ -111,13 +111,8 @@ qla2x00_dfs_create_rport(scsi_qla_host_t *vha, struct fc_port *fp)
 	debugfs_create_file(#_attr, 0400, fp->dfs_rport_dir,	\
 		fp, &qla_dfs_rport_field_##_attr##_fops)
 
-	if (!vha->dfs_rport_root || fp->dfs_rport_dir)
-		return;
-
 	sprintf(wwn, "pn-%016llx", wwn_to_u64(fp->port_name));
 	fp->dfs_rport_dir = debugfs_create_dir(wwn, vha->dfs_rport_root);
-	if (!fp->dfs_rport_dir)
-		return;
 	if (NVME_TARGET(vha->hw, fp))
 		debugfs_create_file("dev_loss_tmo", 0600, fp->dfs_rport_dir,
 				    fp, &qla_dfs_rport_dev_loss_tmo_fops);
@@ -139,8 +134,6 @@ qla2x00_dfs_create_rport(scsi_qla_host_t *vha, struct fc_port *fp)
 void
 qla2x00_dfs_remove_rport(scsi_qla_host_t *vha, struct fc_port *fp)
 {
-	if (!vha->dfs_rport_root || !fp->dfs_rport_dir)
-		return;
 	debugfs_remove_recursive(fp->dfs_rport_dir);
 	fp->dfs_rport_dir = NULL;
 }
@@ -705,11 +698,6 @@ qla2x00_dfs_setup(scsi_qla_host_t *vha)
 		}
 	}
 	vha->dfs_rport_root = debugfs_create_dir("rports", ha->dfs_dir);
-	if (!vha->dfs_rport_root) {
-		ql_log(ql_log_warn, vha, 0xd012,
-		       "Unable to create debugFS rports node.\n");
-		goto out;
-	}
 out:
 	return 0;
 }
-- 
2.25.1