Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 13 Jul 2023 15:58:09 +0800
From:   Aaron Lu <aaron.lu@intel.com>
To:     David Vernet <void@manifault.com>
CC:     <linux-kernel@vger.kernel.org>, <mingo@redhat.com>,
        <peterz@infradead.org>, <juri.lelli@redhat.com>,
        <vincent.guittot@linaro.org>, <dietmar.eggemann@arm.com>,
        <rostedt@goodmis.org>, <bsegall@google.com>, <mgorman@suse.de>,
        <bristot@redhat.com>, <vschneid@redhat.com>,
        <gautham.shenoy@amd.com>, <kprateek.nayak@amd.com>, <clm@meta.com>,
        <tj@kernel.org>, <roman.gushchin@linux.dev>, <kernel-team@meta.com>
Subject: Re: [PATCH v2 5/7] sched: Implement shared runqueue in CFS
Message-ID: <20230713075809.GA24959@ziqianlu-dell>
References: <20230710200342.358255-1-void@manifault.com>
 <20230710200342.358255-6-void@manifault.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230710200342.358255-6-void@manifault.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?DtLT+mW+zMjTyHoLg5Xg0yXqynP7uRSJrlvqKd/4Y19JpAtwyFSyn2SKwUhq?=
 =?us-ascii?Q?vUddQtlF79s1bgEg0kaW8Eb2MhuEykDjIn17a0rW+v1K7hFhzCu4oOZBv0bC?=
 =?us-ascii?Q?oBYC0dCTkbbfnaPVx26mHmWMpP7GBoF0eJZ15e+IphY06noz+Dd0LbKxj2d0?=
 =?us-ascii?Q?kjdWcatoVEEXM0ceENe9WaYC1x+xOh8+ASvuRAZRsYNdCjqh8cIMwiFzI4vI?=
 =?us-ascii?Q?KZBrJbnbh+Gigk86mf3JsTvicLzCXn0kGlMuj+ZoIdYI2Aqa8tyJ8zduRQDp?=
 =?us-ascii?Q?tjd5QbvDxAIRAY5yzVXixn0RJCr0wXZ09oQ48pSVO/oACfykQi8jDr+s3CYY?=
 =?us-ascii?Q?x8EjOM87N9Jze+lAqLkGWpH6PrjM9NgT/6YY93tuZqD8cOEpeQbd0doTsyer?=
 =?us-ascii?Q?CqAS+9RrzIiQF41pz/rm0y8RIOsRLph5HeeKeKdzSJQ8wRdV/HI2JH6QMh3Q?=
 =?us-ascii?Q?JynjNdVZ+iDSy0tNEMLqWbI5F1sPocRLRmGjzjlxyt4arDwN6fzZFScA3S8V?=
 =?us-ascii?Q?Qa2HL2dx4ICrWjggrEfNVxxakG1CKW+p7YXEtl1PouepnOxikFaPLsNK3MgY?=
 =?us-ascii?Q?hTtHmjR0fgpZIjWiHMsC4SjvP1ddKikrU1wCWVppz8GqmglXVe6z1nSbHl/g?=
 =?us-ascii?Q?ts+oQWXTe1KJJpSZxQaWqx/HKfsW9A9qI2bOjNkSqdYNp0wL9BH1QNfcgjwx?=
 =?us-ascii?Q?93XmOZ0JcsiH79rx9+VHNbOWbiRowWv2Y8fwHD5OkOvcbhIs7Ue/etCx4nZq?=
 =?us-ascii?Q?MmRnT6kg47yHpLT8ZDMrNAJV7F6leqLJ8c6DNLkT3i0lr8OeaprMr0jYiYXn?=
 =?us-ascii?Q?p4cEke2cSk2pkdYbpHuKp2cWHHgc6sQGVPEefzUUINnGDzcxY5yVQwZblnA9?=
 =?us-ascii?Q?hdEtPeKnS8vSYIpIvvFGca7v1dmxAKkhELd3vLTnRkXRUBm0RF/vdhH6MMUO?=
 =?us-ascii?Q?C9sBYLj2lGaQ0BF8SyL5IwNPKGXQ7XBz2WQfPfGrq4r9TxjkXvZ4KOyvMdLb?=
 =?us-ascii?Q?A9mDdn4XBeJcPGaJJ05cswXTKor8UjcC4LVHH7Sdfe6vJntDjRiIKgLAe9bD?=
 =?us-ascii?Q?ju2bFtXtUaNxc7iayOnqnCOuzeKMKLmvFWUAuR5IYQ/GT3S4BBScrnvus3L+?=
 =?us-ascii?Q?2foIjeiIR+4alUBaQJ6dXCI6DgwQePfjES8H0tHqXEhjG3E8PHxE9k172/Fd?=
 =?us-ascii?Q?0SqU4YeAs4eIxcRL1+JQkDlwtIqbhBr8yIunwX3+T+6OYyzRGdAYcRg0d368?=
 =?us-ascii?Q?/Z03hNbJtxhLJlFim1jzggttXLmfnhfH9/3OJPNfy3oCp39QrC76NbooWue7?=
 =?us-ascii?Q?ND8vv6dkkvNeIUD6kZFmFqXvnK20Pvc5O6GZUxdBmUjSoc7ZxWZwOLB8igIf?=
 =?us-ascii?Q?K5R0mHR/APe76PlPsXrQXT4WuAHpyMUOiXu+T7JSU9QhCTcK0Y8l5eV4jh6v?=
 =?us-ascii?Q?xotlVPZbllzx/i7/baP2Y8QI6O0B2NX2saalybIbVbkVfVgw/K7R60vftI++?=
 =?us-ascii?Q?b+6qjHCh1/TGCt85IUiv+qOid046L/CCw1mR0TKFHoJCzjxNObuddjkIYrKW?=
 =?us-ascii?Q?FEVesP/KpeKT/WycxANpX90ee5p1WqGoV1IeluKS?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a1ff335e-7f85-47c2-f4a4-08db8376efd8
X-MS-Exchange-CrossTenant-AuthSource: BL0PR11MB3060.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 07:58:30.1544
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8qlXI0w0eaUJFWuch8YwK/JmRrZNnBEa3xJ9m5oVQytVGoDmZa87A6LK1IeVFdax+L8XI5tUK5PfU6Tx3wrhxQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB7000
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jul 10, 2023 at 03:03:40PM -0500, David Vernet wrote:
>  static void shared_runq_dequeue_task(struct task_struct *p)
> -{}
> +{
> +	unsigned long flags;
> +	struct shared_runq *shared_runq;
> +
> +	if (!list_empty(&p->shared_runq_node)) {
> +		shared_runq = rq_shared_runq(task_rq(p));
> +		spin_lock_irqsave(&shared_runq->lock, flags);

After taking the lock, p may have been poped by another newidle cpu.
Running list_del_init() doesn't seem hurt, but is this intended?

> +		list_del_init(&p->shared_runq_node);
> +		spin_unlock_irqrestore(&shared_runq->lock, flags);
> +	}
> +}