Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <67103218-8f89-f4ac-81b7-0d5c54a59220@vivo.com>
Date:   Thu, 13 Jul 2023 16:14:29 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.1
Subject: Re: [PATCH 09/18] mtd: rawnand: davinci: Convert to
 devm_platform_ioremap_resource()
To:     Miquel Raynal <miquel.raynal@bootlin.com>
Cc:     Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20230707040622.78174-1-frank.li@vivo.com>
 <20230707040622.78174-9-frank.li@vivo.com> <20230712140953.30b5309c@xps-13>
From:   Yangtao Li <frank.li@vivo.com>
In-Reply-To: <20230712140953.30b5309c@xps-13>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZmQ5bUJLQ3R6SEd1NmNMNXk4TDJKTVhlOGxGYm5XejNXOFFnQnNIRWU3STNV?=
 =?utf-8?B?QVVobWlwY2U1UHpOa0hRM09aRWZIVk9jNU9CTXVqMU03alc0YW8wcklxOWFB?=
 =?utf-8?B?WnR2Wk00V2tHbGVmQkg0cG1wa0MwV2VhR2VpeDVkdGI4MUFIUFRpZkNZY3Br?=
 =?utf-8?B?WkVVU1E1Wk1rSXdUUkZiZXlDdnFjQmxmV0xBcHJRcVh6SUJucUtNN2N3Y3l1?=
 =?utf-8?B?N3NyU2V2TFRQa1ArZm5pc1lFNFBSY0JIcklkNkZQR1RjV3VGMEhWV0NMQ3Jr?=
 =?utf-8?B?YkcyMFZXbUNuN29XNkoxSm1PRE85VlE0ajJWQjZ4TDd5WUd3aGJaamxyODBE?=
 =?utf-8?B?VnZQWkJxOGMrWkdPZEErVTErNEF0eitiQkRNa0FxaHJId2lXaTZ5cm5GUW15?=
 =?utf-8?B?VkFSUGhkOVFXbWIxRkxLeThNUFlYSzR5SHAvUW1TWW1CaVlWc2NJVTdGVDdR?=
 =?utf-8?B?SFMweVMvNlY3Y0ZxMktOazRDVkMyUEVDV1VPL1dVOStJZUlYV1JZUVdyRGlZ?=
 =?utf-8?B?WnNCYjNqK0kxNGxxaFhsY2JPWXBEWjJpU3NhUkxVMy9ucThxY1lBMll5ZVZC?=
 =?utf-8?B?WTE4SDdpMDhnekZhdE8wOHBFMGgwbnZmbmYwM2oxL1dxL3dqdUNUUVdxVFYy?=
 =?utf-8?B?QjFXRjdTTWkzT0FXMm5pK0dzdmVyd3M4Z3VpMDUyN05PblYrb3NBa3lGQURV?=
 =?utf-8?B?UWNKTlhldk5VeFo5b0huaFlTZDVKdjZkaGIrY0xkZFJjMHdESjJnWDNKYTVI?=
 =?utf-8?B?NnF1Rno1M0ZaUXNkb1ppd2k0bUk5Q2tZdHd6VHd1WVNueFg0VWpPR2IwU0ls?=
 =?utf-8?B?ZnB0b3czYkFyMjNZSVpwZTRYVTE3cWdwOFhydXRzRGdEQUhHOUdBczRxN1Nj?=
 =?utf-8?B?eDJ0alRHaTYzd1ArSWNTaytpUFJkNXg0cHhDVEdSdjFLVG9lWW5iS2U2OFdn?=
 =?utf-8?B?bko0aWtxa0x3TWRGdGdTNlA1eldQVWVsWUZ2L2NTa0RJQnZRMkU2L1p2T2FI?=
 =?utf-8?B?ajFMcVI5bCtzTDNSYkNFUFlZdlJ4bEovS3lZbDRHL1VlQjNoRlU3MHlMYzlv?=
 =?utf-8?B?WU01REI1TDhhSldSb3dGb1VOdHE0T1VwME1XY2NuSXVOTHhjS0F0RkhtUFA3?=
 =?utf-8?B?UHVsMmwzTDJHSHcwUEVEZE9xdEhsREEycFBQcVZENHExOXhXUjJJTTFoVnRi?=
 =?utf-8?B?UmFYTzVCSkF4SmxTRmJ2Y3E3Rm1CZXZ2MDR5L1BYdXpZL1dYSWk1R0dybFdn?=
 =?utf-8?B?WEVCYUNGanU0N0VUR1l6eEo0UXZ5RDd2T3RpUHE5K0JUNjhGVlhhK0VGdy9i?=
 =?utf-8?B?eGFEWGtBK29JbzZNUHh5K01kZHEvSytMZGhPQWtiK0NnV1dIM01LNERIb0dG?=
 =?utf-8?B?QjE1NGMzT3c4MGV1MDRybWtaSzYza1NGNTluQ3ByNmxTRkZLclBUS2lQUGo5?=
 =?utf-8?B?SFBFcU91RXBnT0F5WnVhdU00RkV2NTlzcy94ektiT1dNR212bjFxRFBBd213?=
 =?utf-8?B?SVBURmw2a1RLZFN3TlczK1A5R25yM08vdGFCUWg5ZDBLR2RMVXU2SHd2Yzll?=
 =?utf-8?B?QUM3eEQyWFdrc1ZVOU9xQVBMMW9saW52UERtL0dCSUpjOWJDb0dYVHQ3Q2FP?=
 =?utf-8?B?MmU4OGdXNCtPeUtZbXB1LzhPd2NBb3dUdEp6Tk5jWmNFN3hFTVNYc2d4bGRr?=
 =?utf-8?B?WCtXdjNia2M4cXpQalVhK0hYUE1PMGI2UEpyRkpvbFlYbTVRa084TVhDTmRY?=
 =?utf-8?B?bHZTME9nT3ZBSFk5VWdXRzIwWWVRckRSL0J3RXl5S3JPd0ZmZ0pZYjBDaXJU?=
 =?utf-8?B?UngwWWxaTjhQR0V2Y1F6ZFVwTWYzdThyYkQ1bUg4ZVFOcUtlQVRWM3UyN1Ba?=
 =?utf-8?B?bnFvYTFJcFA2d2p6UjVsSDJpWkp4N1hMZDluYndkMDNzWkNvUW1xa05rNElE?=
 =?utf-8?B?dXF3UWdKWGp5Z2VaSm83RGx1TExaVmtCMUpzK1FFK080dXUzUzUwNm15QWMr?=
 =?utf-8?B?ZDhOcDVtWFVYc0FIME1NWmRVME5YZEJTcDY3RTVYSTBJTUt1TVo2eFQ2V0lj?=
 =?utf-8?B?SUlIaUtqaVluYU01NnppdDFUN3NFTHh4aExXZzFRcGFNOHh6TTF5QThoOUJ0?=
 =?utf-8?Q?w6K7pmi5LoH1/x9UIAdva68eF?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2e53f0a7-db94-476d-80e3-08db83793026
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 08:14:32.6810
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FHVOh9CpaapwQsqR97lEJtECI+Zqxz2Ioq9ixOm4sM4F1E7mER/DL7h190J9dEhNqxJaSjWbZeaPmamKTfB44A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR06MB6349
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Mique,

On 2023/7/12 20:09, Miquel Raynal wrote:
> Hi Yangtao,
>
> frank.li@vivo.com wrote on Fri,  7 Jul 2023 12:06:13 +0800:
>
>> Use devm_platform_ioremap_resource() to simplify code.
>>
>> Signed-off-by: Yangtao Li <frank.li@vivo.com>
>> ---
>>   drivers/mtd/nand/raw/davinci_nand.c | 21 +++++++++------------
>>   1 file changed, 9 insertions(+), 12 deletions(-)
>>
>> diff --git a/drivers/mtd/nand/raw/davinci_nand.c b/drivers/mtd/nand/raw/davinci_nand.c
>> index 415d6aaa8255..2db1cd1d3d03 100644
>> --- a/drivers/mtd/nand/raw/davinci_nand.c
>> +++ b/drivers/mtd/nand/raw/davinci_nand.c
>> @@ -710,8 +710,7 @@ static int nand_davinci_probe(struct platform_device *pdev)
>>   {
>>   	struct davinci_nand_pdata	*pdata;
>>   	struct davinci_nand_info	*info;
>> -	struct resource			*res1;
>> -	struct resource			*res2;
>> +	struct resource			*res;
>>   	void __iomem			*vaddr;
>>   	void __iomem			*base;
>>   	int				ret;
>> @@ -736,26 +735,24 @@ static int nand_davinci_probe(struct platform_device *pdev)
>>   
>>   	platform_set_drvdata(pdev, info);
>>   
>> -	res1 = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> -	res2 = platform_get_resource(pdev, IORESOURCE_MEM, 1);
>> -	if (!res1 || !res2) {
>> -		dev_err(&pdev->dev, "resource missing\n");
>> -		return -EINVAL;
>> -	}
>> -
>> -	vaddr = devm_ioremap_resource(&pdev->dev, res1);
>> +	vaddr = devm_platform_ioremap_resource(pdev, 0);
>>   	if (IS_ERR(vaddr))
>>   		return PTR_ERR(vaddr);
>>   
>> +	res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
>> +	if (!res) {
>> +		dev_err(&pdev->dev, "resource missing\n");
>> +		return -EINVAL;
>> +	}
>>   	/*
>>   	 * This registers range is used to setup NAND settings. In case with
>>   	 * TI AEMIF driver, the same memory address range is requested already
>>   	 * by AEMIF, so we cannot request it twice, just ioremap.
>>   	 * The AEMIF and NAND drivers not use the same registers in this range.
>>   	 */
>> -	base = devm_ioremap(&pdev->dev, res2->start, resource_size(res2));
>> +	base = devm_ioremap(&pdev->dev, res->start, resource_size(res));
>>   	if (!base) {
>> -		dev_err(&pdev->dev, "ioremap failed for resource %pR\n", res2);
>> +		dev_err(&pdev->dev, "ioremap failed for resource %pR\n", res);
> I believe this is the only use of the resource, I am in favor of just
> using the regular devm_platform_ioremap_resource() helper here and just
> drop the reference to the resource from the message.


I guess maybe you can apply this patch directly?


It should be noted that devm_ioremap_resource is not the same as 
devm_ioremap,

here is devm_ioremap (devm_request_mem_region will not be called, and 
there are comments explaining why this interface is needed),

which means that we cannot simply replace it with 
devm_platform_ioremap_resource.


MBR,

Yangtao


>
> I will apply all other patches, please send a v2 only for this one
> once improved.
>
>>   		return -EADDRNOTAVAIL;
>>   	}
>>   
>
> Thanks,
> Miquèl