Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yangtao Li <frank.li@vivo.com>
To:     miquel.raynal@bootlin.com
Cc:     frank.li@vivo.com, linux-kernel@vger.kernel.org,
        linux-mtd@lists.infradead.org, richard@nod.at, vigneshr@ti.com
Subject: Re: [PATCH 09/18] mtd: rawnand: davinci: Convert to devm_platform_ioremap_resource()
Date:   Thu, 13 Jul 2023 16:26:00 +0800
Message-Id: <20230713082600.75251-1-frank.li@vivo.com>
In-Reply-To: <20230712140953.30b5309c@xps-13>
References: <20230712140953.30b5309c@xps-13>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?i53bSy6/tsAwzA+/dS8LBwfcXm+RRSPVEV+HPs1PXzfxBidBYO8SQiBUJrtF?=
 =?us-ascii?Q?ztzGbR8a46jEB9zDiy5qw3GkSBdPOpcj7uQATnBHWTJEcK0wBTT9GAjzTNsr?=
 =?us-ascii?Q?WaiMV3/DHmPoJpSgWD8X/W+h8uzztgCAfekB9aD9bu22HEu535v/5UIG1wRd?=
 =?us-ascii?Q?ZKSag/QyMCul+9cDPOhbRCtuBU6yYlphLaZ++o0dU/XL1WnYlDCGkBAsiDHT?=
 =?us-ascii?Q?tWw15naxMRD3A7oRmffQmW8dNGFqRrE/gs69C26xgkuu/cEj0xGMkErr/Bc+?=
 =?us-ascii?Q?Sqwf74Ri+MUa5D1gczetwWpp2XWogV1OYkCEeGrAc+QUtXS4UFLSpc6hhDqK?=
 =?us-ascii?Q?97F6E72fUOCjmsKDp+XXXEpMM9Nz+NzhVmv5f78lnQ8vd1giMoPU8mXuFSky?=
 =?us-ascii?Q?9zg8dLFx/3ZtZbqUFy9XATmRdlHLXl/J5M2E8nFzATm+03p3HmVzwwKHziwz?=
 =?us-ascii?Q?Qvcs/bHcUIP6dqSeUhLlsIzWSpLSjo5NhdyErYdQLozev17V+CQr8q2etu/S?=
 =?us-ascii?Q?myeOnqePzT/lcfarrZKYcyPbfDuq/ptvYry51TA6M47z7sGTJ9aD9mY18s/C?=
 =?us-ascii?Q?YSGasrDOFVHSi3c3E1n82Z6kITMEvswt+LZB8NrDQryRbsSYUt9Wh54d3QXB?=
 =?us-ascii?Q?exvX1Gyl8+WTxZLpMUrlFvBTQKvEHctX2ZBJYHDTKIyC8iumCLK0V5w1OYcH?=
 =?us-ascii?Q?B5YnJxHSyXHHAdK6E8PNXY5m5n3JwMQenM5u+OrrJuhH+Ww8fAz+tqBymnEg?=
 =?us-ascii?Q?VuZQyDsk+mMHXOBjtErsfTGfGsjX5zQjCmUl0VH080pPu68+bQOORsSuVt/S?=
 =?us-ascii?Q?UyhCpXVFUDLpkUko4T9c9RIBZ/C1YSk6gglbUe4bAyaPqsgAcD/9QLBXAScf?=
 =?us-ascii?Q?3DVrYmGSv5f8gkKNoDFNOtdM6wlH/VDMR/Ww/rYz51HPjnMzko/GW1WFm8Lb?=
 =?us-ascii?Q?oVvZLd6Wlv78SgxeTWuEdPrEKBtkYNYG4+UntK2e/PKf296x7LKwtDOwTfyB?=
 =?us-ascii?Q?TXlnq8AoUy08T5VecQeC/Eab2IYkvkCxtTSSKoxpsnMy5mbDu89ztO6SY1j3?=
 =?us-ascii?Q?FRwK2wENQpaxXJIYoAqckQxJi/qDPWnM3O1s3VsyFhhTlD6iRe48J8K7Y3UN?=
 =?us-ascii?Q?NlKv8GFiFHmubBI1tfZ862kuQYERUaKzQfBrXKddG+n9jVGRNFpLVfzVTE+I?=
 =?us-ascii?Q?+nhTCTquPvpUPPNsjLjFtCsYWnxNLbQibrO22G2lqHJBBAFBjtLB9YPJkLr9?=
 =?us-ascii?Q?SN0B7aLaeHmVOzXy5c1pWsZ6N/Z1HE/yUoS4pvF+6/QYd+yaqKdxz4KNSmup?=
 =?us-ascii?Q?OiYz99M/Kbkaq5jg4VuDw4wdsb046ylBXCOclAbr5NaDN1fXEb4XkQ9eQe0k?=
 =?us-ascii?Q?DCuI1Jg9h7KeqRQmN+OXtggtH+bVKrO8MWpLcVXOpGeEWm/8AYhX7GJEnoJj?=
 =?us-ascii?Q?0M79hrKH/s1CTlptNFxk5ZIBqfoddOSSDf0jqIiGmWGDck+cKMEpeOxTroXK?=
 =?us-ascii?Q?aAmJLNSBPN1Ovfnz/BpaRjEM/Ap9U8h0FGFE3AJWOma9QwEApwE9Aopaa4lF?=
 =?us-ascii?Q?oWalRs4SqpNsURRUm1VxU+th7ntBg4+oSSSbFV/t?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f577c24e-c38a-40d9-4200-08db837acf65
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 08:26:09.4134
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ybxhZTwID6G9yyojK/ydOltDSAka/B48VjUOmeq+6Ftcoqzm2l2fmeUmdTfOZ/uIdwKF+lLmSwZbdE9guAh4Sw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: JH0PR06MB6437
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> I believe this is the only use of the resource, I am in favor of just
> using the regular devm_platform_ioremap_resource() helper here and just
> drop the reference to the resource from the message.

I guess maybe you can apply this patch directly?

It should be noted that devm_ioremap_resource is not the same as devm_ioremap,
here is devm_ioremap (devm_request_mem_region will not be called, and there are comments explaining why this interface is needed),
which means that we cannot simply replace it with devm_platform_ioremap_resource.

MBR,
Yangtao