Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp842873rwp; Thu, 13 Jul 2023 01:48:07 -0700 (PDT) X-Google-Smtp-Source: APBJJlHYAtjsdmUIDWNMX/RbWCzBNCjN0EK60qEFxhlguaRIqmJl2zHIOS0sJ9F0EDk+c6CFxdcw X-Received: by 2002:aa7:db48:0:b0:51a:2013:583 with SMTP id n8-20020aa7db48000000b0051a20130583mr1051168edt.13.1689238087183; Thu, 13 Jul 2023 01:48:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689238087; cv=none; d=google.com; s=arc-20160816; b=PzqgLoethBu0D0b1hY74+s9wCGGSBc+PbCv6NYYKQchKJqJljTodtrFwqfc8EMnuCD DHzuxlLrZAkEJyHvTRdQS52kRrTMdiXHP2886kyu9vr5DLqAajjDG12E23PRRqchqINn IwjE71gDF8QRpBeAl9BITv+AzeMfcRwO3/HC6i4KttLcYd5IsnOg5Y/dN7Zjwu/VtCRN 8nnWjw2G025bLMakAiXqswWGgBRiFgBY0AlfqZNRWGUy11P98cRBNXI/hiKTlKLjPydm OgdCEXabgTWRBhjDWiypyF0TMjY4EcuUvQFCPgiCje1q+IXPFcDEPlePWHdE9if8dtrE O4gQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=p+KC7YWiKB5Mk9GoOmWmh5rqXfFb9ab0DdlkQ/N8CfI=; fh=oxPhYVaH3K6dRoBQR5dvft4TeBFawrKdpu+R4/k58+U=; b=gFoVGcQNaZQLPDde5q7EDm8qsvl9OQpKqCzODgY7GIHLVT8u0lVAQEYUXbSXdmFrsP cuD0/2xlZl6/rPGsBfgE8+x+5eDaf9k2nNm8CsXS8yQsp9pxTFseoyv/vBRIXUfH6Opv wxIyCH2JP6VQzWm1oqlVLCp0kpj/iFv5cV45tRD4V5/oykHYurmdJWFSGcqnfFeeb/0G rdGTPWYyaDykouKBMxH7jqiP95cX3tciFsNw3E6RyVynUu4V/TGGMsAsFV29RxUiEny0 +btR1xB1OGdbR5PFMifj13obc2bDQ4yZLFO7+4tMDkY8cGfdmpWasC+kDLHnSEF3syhj amLg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=n9HTMVi1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c2-20020aa7c742000000b0051df5bcf727si524545eds.297.2023.07.13.01.47.43; Thu, 13 Jul 2023 01:48:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=n9HTMVi1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234476AbjGMIhO (ORCPT + 99 others); Thu, 13 Jul 2023 04:37:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234545AbjGMIgn (ORCPT ); Thu, 13 Jul 2023 04:36:43 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72D1D30E8 for ; Thu, 13 Jul 2023 01:30:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=p+KC7YWiKB5Mk9GoOmWmh5rqXfFb9ab0DdlkQ/N8CfI=; b=n9HTMVi1MQoVYNyo+pYYEcYWVm PCJllK8dXF8/053ToDMmpLiQ3giHQNv7VUNsPXPorxhdjcAOACQWcO3BjPOhVGEMtGyUEPUO+8V6r DWh96+gYdGZMTKaDzVmZ/FjVFLSu+fFrPmRuOYL66vwmiC2fhb7zbEdG4YVtbMxakZtPuGGoIxqyM NnEapR51z4WWFhouispdGaiZrZgiikJ84anECV2u8UZwkAgYgzLXFDnsweYEW8Lh6z0PL/WtDQFwk IaXH2KEU+aFjFBilfEXVZ/81QeTAJ1aB0cIt5HDoLNp5UD1uAn44mjvvp7qrRlr4aux9gjG12NWea /2F+dzDg==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1qJri0-00HYlm-B6; Thu, 13 Jul 2023 08:29:56 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 413E6300222; Thu, 13 Jul 2023 10:29:55 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 20154245CA116; Thu, 13 Jul 2023 10:29:55 +0200 (CEST) Date: Thu, 13 Jul 2023 10:29:54 +0200 From: Peter Zijlstra To: David Vernet Cc: linux-kernel@vger.kernel.org, mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, gautham.shenoy@amd.com, kprateek.nayak@amd.com, aaron.lu@intel.com, clm@meta.com, tj@kernel.org, roman.gushchin@linux.dev, kernel-team@meta.com Subject: Re: [PATCH v2 5/7] sched: Implement shared runqueue in CFS Message-ID: <20230713082954.GE3139243@hirez.programming.kicks-ass.net> References: <20230710200342.358255-1-void@manifault.com> <20230710200342.358255-6-void@manifault.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230710200342.358255-6-void@manifault.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 10, 2023 at 03:03:40PM -0500, David Vernet wrote: > +struct shared_runq { > + struct list_head list; > + spinlock_t lock; FWIW, this really needs to be raw_spinlock_t. > +} ____cacheline_aligned;