Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 13 Jul 2023 11:02:30 +0200
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Yangtao Li <frank.li@vivo.com>,
        Jaehoon Chung <jh80.chung@samsung.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Alim Akhtar <alim.akhtar@samsung.com>,
        linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 14/58] mmc: dw_mmc: exynos: Convert to platform remove
 callback returning void
Message-ID: <20230713090230.iwhicjbirll5icec@pengutronix.de>
References: <20230713080807.69999-1-frank.li@vivo.com>
 <20230713080807.69999-14-frank.li@vivo.com>
 <75d2dc5e-4cbf-2519-cdf7-8fde374126ec@linaro.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="d6d7itv6cdabafnt"
Content-Disposition: inline
In-Reply-To: <75d2dc5e-4cbf-2519-cdf7-8fde374126ec@linaro.org>
Precedence: bulk


--d6d7itv6cdabafnt
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jul 13, 2023 at 10:11:15AM +0200, Krzysztof Kozlowski wrote:
> On 13/07/2023 10:07, Yangtao Li wrote:
> > The .remove() callback for a platform driver returns an int which makes
> > many driver authors wrongly assume it's possible to do error handling by
> > returning an error code. However the value returned is (mostly) ignored
> > and this typically results in resource leaks. To improve here there is a
> > quest to make the remove callback return void. In the first step of this
> > quest all drivers are converted to .remove_new() which already returns
> > void.
> >=20
> > Trivially convert this driver from always returning zero in the remove
> > callback to the void returning variant.
>=20
> You even copied Uwe's commit msg... Aren't you duplicate his work or is
> it being coordinated?

We communicated and I politely asked to not interfer. This series is
just what Yangtao had still pending. That's fine for me.

Thanks for noticing,
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--d6d7itv6cdabafnt
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmSvvaUACgkQj4D7WH0S
/k48vgf7B9pOCj8BEtBTeW/UjDXpN6Ydodk3PjPhDksAVMx3pfZiUm43bOVMgD/G
30npFfBBlwWgCrzx3XoBoJ2qFYHoq+pjTlH1EZcipdXN3/AONF5YUQ/OR3+CnwZd
CWFxvF6RFK/LwkErVlFsrF6WBHpSkJ14lfMvSkAIPtOZ3JoykZtHd+D3YsQJvceS
rikOZOHI3LJEKOmAPtfRNk+PjEfERw0T+2+/JiLIe4Cip7GZ2vOz5K+2YXRWHeRy
8vgSXOKRfegphqtSuE0qQxMrTafPsKsck4OKS5U8PC+ebYaW/MUwWTiU45RBiMiz
QqeKHVZV1Vp2TKVzQSkDkGgoNkxFOw==
=XV+K
-----END PGP SIGNATURE-----

--d6d7itv6cdabafnt--