Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 13 Jul 2023 11:08:40 +0200
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Yangtao Li <frank.li@vivo.com>
Cc:     Adrian Hunter <adrian.hunter@intel.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 24/58] mmc: sdhci_am654: Convert to platform remove
 callback returning void
Message-ID: <20230713090840.dc2ejoz6cieq4dyg@pengutronix.de>
References: <20230713080807.69999-1-frank.li@vivo.com>
 <20230713080807.69999-24-frank.li@vivo.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="hpncxr6mfxobixq5"
Content-Disposition: inline
In-Reply-To: <20230713080807.69999-24-frank.li@vivo.com>
Precedence: bulk


--hpncxr6mfxobixq5
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jul 13, 2023 at 04:07:33PM +0800, Yangtao Li wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>=20
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>=20
> Cc: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
> ---
>  drivers/mmc/host/sdhci_am654.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>=20
> diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am65=
4.c
> index 7cdf0f54e3a5..3cfaf7dca274 100644
> --- a/drivers/mmc/host/sdhci_am654.c
> +++ b/drivers/mmc/host/sdhci_am654.c
> @@ -866,7 +866,7 @@ static int sdhci_am654_probe(struct platform_device *=
pdev)
>  	return ret;
>  }
> =20
> -static int sdhci_am654_remove(struct platform_device *pdev)
> +static void sdhci_am654_remove(struct platform_device *pdev)
>  {
>  	struct sdhci_host *host =3D platform_get_drvdata(pdev);
>  	struct sdhci_pltfm_host *pltfm_host =3D sdhci_priv(host);
> @@ -874,14 +874,13 @@ static int sdhci_am654_remove(struct platform_devic=
e *pdev)
> =20
>  	ret =3D pm_runtime_resume_and_get(&pdev->dev);
>  	if (ret < 0)
> -		return ret;
> +		return;

This is changing semantics. You shouldn't ignore errors here. This is
one of the cases where a driver leaks resources. You need something like
22f407278ea43df46f90cece6595e5e8a0d5447c here.

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--hpncxr6mfxobixq5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmSvvxgACgkQj4D7WH0S
/k7zlQf/RvEu2cnSVXe7Hmj9SJ6zuFOhSBuFOikWudB536hrocckhd6f3Q5x8nBv
mZid4zWQ4+EPtyGwpRcMva1jw47HdS/SegY2DHazQxUKBPn18CigK220qnp56gz1
KXIsOgLqJa+zG6PDAWaL4JVAmmxIGE3SR0N0Oe1MJjp2RDXhLAVqHAMWAmwzlttd
xofRdoJBrzf0wxbkofT7DHYkwRTKlivRCi3d26Nm0AZgkTyDtDixMoVvuCzkmj08
EVIifzyeUixWthMwe+165BlJ2xrIhYLUp5U/60ZtZ2KDd+bfBCcu3udFTqAstIEI
m91KOQcrsbBBbEOpCf463yZvHFyjtA==
=RTtS
-----END PGP SIGNATURE-----

--hpncxr6mfxobixq5--