Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp876806rwp; Thu, 13 Jul 2023 02:30:58 -0700 (PDT) X-Google-Smtp-Source: APBJJlHzvOp2QI6CFeaD4iGtDJBoFyERS9CZrBU9urYqvzVGaqTpw2ptZRGJ/mc791f7pxonZxK+ X-Received: by 2002:a17:902:b210:b0:1b6:797d:33fb with SMTP id t16-20020a170902b21000b001b6797d33fbmr954556plr.64.1689240657809; Thu, 13 Jul 2023 02:30:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689240657; cv=none; d=google.com; s=arc-20160816; b=aGXddfjc2sEVDxhXoPy8+uPSjflGLz0dNTwicyGanBy1ETl83kE3PkZatMSdef74s7 bB6/uCxdsrdbwddKF+to7+koN9pgYkH4BrqbbT1vjVMi/MvUGNDuhmJdKXr5b/6hsw4k tja6T72xZceT5BVvXH/QrCjteKgoGSztVurtf0/mXi16LKUxqUMYdWWvv2ulcXHFq44J LrKEE5WVNfIgHm0HeK1C2S6Trz7tF3572qTdiK+M2ykxad6CEnDIC7IFDYrf+yduyAmC hpjivjTVqTI6XeFdloUl76xWMrOgcQLdvSn8l8rUxEBHoGQfnqJolmTbZfjN0HUNle0J OGjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:message-id:references :in-reply-to:subject:cc:to:from:date:mime-version:dkim-signature; bh=4YwY57T8gYw5hY125mIXRaBE0aBCOv2hc3oQ/aBKurc=; fh=sP7rMaS/5f9dU4JFVUp0cDpFXp/WP2Gat8NYkYYoJb8=; b=jRS861faAzMhKWNy6g+p0f0mnEXmp2SVcR0q7zCQCSqIsYqTj8miLGCIVBkZP1XsXo Ub0ldKNNXswT279wtNM4vdvLlb8qDlTPPJhZBh51akY2tuF/gNDBg9yupKFwKBZcHh3B BLOiq8BJFCJ6M3zAqGSz2V7pLwzgPfCvzTtuo/zUXXZ6/LsKr9GuV/B7ebD7UHki99PD 4X701+aoIcHptVg+gZ/Meqp0Ys9CsH1JLvAqpxT0smG1I5DDrDyX0HunDuDt9tbqWzjz O/bfmhsbGYshfD0zu6K9UIc1VAFXnb8a+A1XgHmP5cnpMkOIdvamZtzBpEFvobZI3oMG RkQA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QCOtMw1R; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y5-20020a17090322c500b001b80643d64dsi5057588plg.145.2023.07.13.02.30.45; Thu, 13 Jul 2023 02:30:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QCOtMw1R; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234134AbjGMJAe (ORCPT + 99 others); Thu, 13 Jul 2023 05:00:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234702AbjGMJAT (ORCPT ); Thu, 13 Jul 2023 05:00:19 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08CB31B6 for ; Thu, 13 Jul 2023 02:00:14 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 91CE461A98 for ; Thu, 13 Jul 2023 09:00:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE2E5C433C7; Thu, 13 Jul 2023 09:00:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689238813; bh=FS6IGHNIU+MsMLrPhkS4TbBRHtXLi8wWNk5j5osD+DU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QCOtMw1RQz6X/mHeK6QOPmbM+fyZdqhp0fggevlZYpEuq1pw1vpKcJ2uzfyxCpIua 3jagn/cfJzfeULxuMz1Tja3ZWYf32FI/VLi3zC4mrEvd6aOhyFZADhbRAnHVpgxsbg 4aBg4BZ1LUcjZhpUC+aENAYzbEhtrbjU0ldeuW7n3y3n2QDnmZOLpVw8bAy4ypsbVS XbckHjyyCkyrXjb5qOu8qa8s2LIIxF5MfnquOaItWrPLbIb7qHrwKXe6p4t6gJhy2s 0Uq9TL0WFJR20G1SKTWC3R8LQLqH4+umIzM258NPLNK+gtwnbKYfVXpiX5SNaktZ0p DBjTzeS2fAtwA== MIME-Version: 1.0 Date: Thu, 13 Jul 2023 11:00:07 +0200 From: Michael Walle To: Simon Horman Cc: Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Yisen Zhuang , Salil Mehta , Florian Fainelli , Broadcom internal kernel review list , =?UTF-8?Q?Marek_Beh?= =?UTF-8?Q?=C3=BAn?= , Xu Liang , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v3 08/11] net: phy: add support for C45-over-C22 transfers In-Reply-To: References: <20230620-feature-c45-over-c22-v3-0-9eb37edf7be0@kernel.org> <20230620-feature-c45-over-c22-v3-8-9eb37edf7be0@kernel.org> Message-ID: <1bef1179238e09cdfce281cc2428ba56@kernel.org> X-Sender: mwalle@kernel.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Simon, Am 2023-07-13 10:56, schrieb Simon Horman: > On Wed, Jul 12, 2023 at 05:07:08PM +0200, Michael Walle wrote: > > ... > >> @@ -780,6 +782,7 @@ static int get_phy_c45_devs_in_pkg(struct mii_bus >> *bus, int addr, int dev_addr, >> * the "devices in package" is invalid. >> */ >> static int get_phy_c45_ids(struct mii_bus *bus, int addr, >> + enum phy_access_mode mode, > > Please add the new mode parameter to the kernel doc for this function, > which is in the lines preceding this hunk. Ahh. Sorry. You've already mentioned that last time :/ Also true for get_phy_c45_devs_in_pkg(). -michael