Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wang Ming <machel@vivo.com>
To:     linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
        linux-kernel@vger.kernel.org
Cc:     opensource.kernel@vivo.com, gregkh@linuxfoundation.org,
        Wang Ming <machel@vivo.com>
Subject: [PATCH v1] block: Remove error checking for debugfs_create_dir()
Date:   Thu, 13 Jul 2023 17:14:39 +0800
Message-Id: <20230713091452.3997-1-machel@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?g4xL1ED7w8axDigEnmxbP2Gy5wJHzkyhW/QnI3k4gUbQvG5sdczsOVfRSJGp?=
 =?us-ascii?Q?QmjymD5TRbc8t8EYjHlAApJlChn3c9ixWike19a/59LrIVsFC6ReAZQil8Wf?=
 =?us-ascii?Q?1qswNqBIpLzXFUkYlXaEZiu7WfgWR7qNUn3Xgg3DDv95kYwx0Z6UmGoD+I4L?=
 =?us-ascii?Q?CqQ6sBnYGE8wFkqNWXdLnwFeKFJ3ndbRxos0SRskFo14s2axoNmrUpif+Am6?=
 =?us-ascii?Q?2wSmNYR0EOpCgGIKPxKJXd+AGFJAYpSh70vCZjVT09n9rBRITsh/AsKzGlj5?=
 =?us-ascii?Q?fJ9SYqNJGSa/jRlqhegj6MckWC9uF23OqedJvqRKDxYohocxh2y83xsORXir?=
 =?us-ascii?Q?/kk4OLd0huYDkuOd2X/q3uyDYi8TLyov3F00rJi5LcpI5r3iZlhoU98Y44o8?=
 =?us-ascii?Q?lDuiV+x00P6eTPCLV5DwhrurrlxSi/1II6dFAUoepjcUDt8HD+3gusYOfMZB?=
 =?us-ascii?Q?qTqQpKfdwhAHTp85zDL9Kqxqc0SqK+znU9oIBl0Yi2reNMWF+EBhWyz8y6vm?=
 =?us-ascii?Q?WxX+aFdi4zdW9tU/7G0jMfs1SIywkmiaxE57Qz4vd8zCzo71/M8j1W04m0Q6?=
 =?us-ascii?Q?uPngs/+2MUdEYK9DLpWac1yblU6xa0o93LUkw+toy/TaPlLyBwswGCmERLNp?=
 =?us-ascii?Q?Rw5sSzQyhHqZGvoFHspfMwBp6DA48JeaPqvpLyvi/JWJolw1uMB/49pzVlDw?=
 =?us-ascii?Q?4Xti/1G7lROsGJ45l+29W4hFhbi1q1I/xDphINx/cL9oeyIj5xjpD8Y5JVTa?=
 =?us-ascii?Q?oWzygeYoI6+972mwq9Le0Z6e+hdyhrijKX/jj5SEsYDrGjUcCjpT394ehIxo?=
 =?us-ascii?Q?IwGk52VEWGvj4SPrc2/hzToeF2G2hqLmOlzlORBi3KpXUYoTPSe2hVzDqJfG?=
 =?us-ascii?Q?O5JVECpfeLx5Zfq+T8WgnRUvUjLjuc+ij1WGlS7XcobULWQkP1wRPAmrDVTC?=
 =?us-ascii?Q?EkkQRQh7ZwLG4kyugetp35GXouUZOzTuKekavsJzdxE/udeB7d7YVindLag3?=
 =?us-ascii?Q?AJpGO2FCn0BNoHqc5m7J8JpvgSFdrp+Do9leFbGu7gjG8qdVHjYd0biaBQcB?=
 =?us-ascii?Q?vuxA4mvpPGH6UfKN/W4qqIPddJ3vQdaDyuSgfdICfXsUgN12KkFZXrm/nAy7?=
 =?us-ascii?Q?hB1QxWUAIUn0gc7adsvYGnIrJG6Cf8gxJPRaHNLqwslvHqE2XEZRTZMiC/IT?=
 =?us-ascii?Q?TaaQi6zCCwcu1UiGa5b6le8xDVuj1HwV9HuV3+lPNHp9JTarh/NYT0zE4sf5?=
 =?us-ascii?Q?WmbPEGB+PpF+4bXwh4Sxcw4ZVdFZ+YmG66Q9zoBUs3gIBX2hqLMDe6q21/gS?=
 =?us-ascii?Q?FLirrjl6f4VbjoLohM9f3w1PLZSLaG0+erqXOwPrFQzmvhAVUTytrBPpBnZH?=
 =?us-ascii?Q?tnL9gYktV2VjZhnhxVp0X1OIQaQ64Lzq0YGqXY8YL5CeWEkQR5bA5wNDwY8i?=
 =?us-ascii?Q?Put6qZm01ELxMAgxSehfeZvaAWUPP4Fr/gJctNs69ujYuA5XXiL+CLCSl0cF?=
 =?us-ascii?Q?LQXX9c/86gNPkYhveQBoEtJbGDWjK+ilY3Cpo+GHCUgaiUMbTTe+CDCh8vQt?=
 =?us-ascii?Q?lFDMkF2fACRcmvyKhm5s+LkRLpSUEulfHbcgt987?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8ccfc38f-65e0-47f1-a4e9-08db8381cf44
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3743.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 09:16:15.7754
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 08CPA6n7oTIo58d46yGdleKHX+x2bYXWmAxdY2m3KKuMskNCv4JRq/P5O9CoszKL4AOK0cr2mLW6e8eMFPu1Eg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY0PR06MB5612
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

It is expected that most callers should _ignore_ the errors
return by debugfs_create_dir() in pkt_debugfs_dev_new().

Signed-off-by: Wang Ming <machel@vivo.com>
---
 drivers/block/pktcdvd.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/block/pktcdvd.c b/drivers/block/pktcdvd.c
index a1428538bda5..1d07208faeeb 100644
--- a/drivers/block/pktcdvd.c
+++ b/drivers/block/pktcdvd.c
@@ -497,8 +497,6 @@ static void pkt_debugfs_dev_new(struct pktcdvd_device *pd)
 	if (!pkt_debugfs_root)
 		return;
 	pd->dfs_d_root = debugfs_create_dir(pd->disk->disk_name, pkt_debugfs_root);
-	if (!pd->dfs_d_root)
-		return;
 
 	pd->dfs_f_info = debugfs_create_file("info", 0444, pd->dfs_d_root,
 					     pd, &pkt_seq_fops);
-- 
2.25.1