Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230710032131.52747-1-xujianghui@cdjrlc.com> <decd9e6f68cbebda22d6648fa7b9b737@208suo.com>
In-Reply-To: <decd9e6f68cbebda22d6648fa7b9b737@208suo.com>
From:   Karol Herbst <kherbst@redhat.com>
Date:   Thu, 13 Jul 2023 11:11:05 +0200
Message-ID: <CACO55tut_20kwHC4-0fkkyGrh0sLrRO2e6TVCuUL_q7vuz+tPw@mail.gmail.com>
Subject: Re: [PATCH] drm/nouveau/nvkm: do not use assignment in if condition
To:     sunran001@208suo.com
Cc:     airlied@gmail.com, daniel@ffwll.ch, nouveau@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Jul 10, 2023 at 9:23=E2=80=AFAM <sunran001@208suo.com> wrote:
>
> Assignments in if condition are less readable and error-prone.  Fixes
> also checkpatch warning:
>
> ERROR: do not use assignment in if condition
>
> Signed-off-by:Ran Sun <sunran001@208suo.com>
> ---
>   drivers/gpu/drm/nouveau/nvkm/subdev/i2c/base.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/base.c
> b/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/base.c
> index 976539de4220..054fa42f1d04 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/base.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/base.c
> @@ -286,7 +286,8 @@ nvkm_i2c_new_(const struct nvkm_i2c_func *func,
> struct nvkm_device *device,
>
>           if (ccbE.share !=3D DCB_I2C_UNUSED) {
>               const int id =3D NVKM_I2C_PAD_HYBRID(ccbE.share);
> -            if (!(pad =3D nvkm_i2c_pad_find(i2c, id)))
> +            pad =3D nvkm_i2c_pad_find(i2c, id);
> +            if (!pad)
>                   ret =3D func->pad_s_new(i2c, id, &pad);
>               else
>                   ret =3D 0;
>

Reviewed-by: Karol Herbst <kherbst@redhat.com>