Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 13 Jul 2023 10:19:35 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Michael Walle <mwalle@kernel.org>
Cc:     Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Yisen Zhuang <yisen.zhuang@huawei.com>,
        Salil Mehta <salil.mehta@huawei.com>,
        Florian Fainelli <florian.fainelli@broadcom.com>,
        Broadcom internal kernel review list 
        <bcm-kernel-feedback-list@broadcom.com>,
        Marek =?utf-8?B?QmVow7pu?= <kabel@kernel.org>,
        Xu Liang <lxu@maxlinear.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 08/11] net: phy: add support for C45-over-C22
 transfers
Message-ID: <ZK/Bp5xIwzooTAYu@corigine.com>
References: <20230620-feature-c45-over-c22-v3-0-9eb37edf7be0@kernel.org>
 <20230620-feature-c45-over-c22-v3-8-9eb37edf7be0@kernel.org>
 <ZK+8M+FxJxY7UIyt@corigine.com>
 <1bef1179238e09cdfce281cc2428ba56@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1bef1179238e09cdfce281cc2428ba56@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jLuPrLHI5OH+p1RENinXgp3vrLIlOMnHo5Fanps6GLq2XNRPg4JgdXkXLPxR?=
 =?us-ascii?Q?61T24fv5j/DrO74tWd68CH2ecRX90imjKkEU7V2kiUN1QupUJOdF4T0bY8c0?=
 =?us-ascii?Q?9acHG3aCAqgVsnzFil1EkndImUm+QDD1U3habo6j7b3PmJnVEHUlK3BVDCTC?=
 =?us-ascii?Q?dPK/4TbZUAlUo++XU/6d5XSvNpHKrwht7iPL+n4TPTXxsSSAkBMfqcdwv7lE?=
 =?us-ascii?Q?hLZk4k20wWWzFJZ9gxSW7qRctfC6UTH2aLdJBvIBIVEPL07lfO9mzOrUgFH/?=
 =?us-ascii?Q?SfHpIEkDvSLh5+F9x5qplH1T9d9KLvQ6Xk3M7Yd/unWCAncCgrX7QB+OiHeG?=
 =?us-ascii?Q?sT91M4EKYGUGSjxbEVJOoYHUSERjqND1GN9e2QomJ8UNCFxkDsout06EFB9j?=
 =?us-ascii?Q?vaE9pSK7erRP9T+fPinTX41a11Jl25XRMup97O9TMu2dwoyp4aemXMNqgIXH?=
 =?us-ascii?Q?mU8uSpM3TneEDhc+jKvSmOhA9az9s8nUikefS6nqxIo/AnHyDkU2yeQ14eCy?=
 =?us-ascii?Q?/qkBFZaGwYkQsQyy8CjOL6JznMldo2YjV9PqwFuFY0oS+DbKpYTd7OaUWCnX?=
 =?us-ascii?Q?XF56H/9SmpwE2gIRIifGRljmP8kIK0TLvuPwX0R0ft7Z+kiYZFS1JCIwlQ7P?=
 =?us-ascii?Q?aDO8h8lf6B3gU+obzUsiM3Xbnj5qhP5tBd17YTK6UBxAmQQwH/nx2NeGgGJt?=
 =?us-ascii?Q?vOmwZuGXQsMskEhirv6kN7fwzCAVPZBPNwyp8J86hBw67uiPoefPhBeHoaG8?=
 =?us-ascii?Q?+0u0ILSlfshjQNTySq3y2ALZmRKcgSa0beFc1y7rmXhLm9ouTa8yY/NHj5JR?=
 =?us-ascii?Q?ChEZ0VqoQdhbdiXduRe545+hMdN3rU0qC7lrjpExTNXBJOuufPZa/D5rJzpX?=
 =?us-ascii?Q?flrhY+50gjHyULnNVlzvLny0QJb41s+fNi10PjPIh8CcY7BX/vNQvm8YY5n6?=
 =?us-ascii?Q?PAaO4FpEjr2YsPZ+IgelJsKtFj3QMJ9zQAUrb4MUmDlRazeN2I1RpTYvgAks?=
 =?us-ascii?Q?1/HSibXkbTeolMZW0oHy2BqDuwngrzPLU2UN4clUQ9Z1wcBIW8wU0dbmqYfF?=
 =?us-ascii?Q?Bx1oTBHkIiHt2xxwNR238E6Q+nD66681oqcDrbXsZZspcKLlIY98F4R+Ju/i?=
 =?us-ascii?Q?LDFEzfAbhopZ4zROsU0HvU08kXOXOt/r3KhgQQ25VevmjiP/jp4QbprWnWtI?=
 =?us-ascii?Q?sLj0AezsQTMC97hIPVdgmM58lfEeb2LYTexF2EXdCF7nXc1m/dDQYDvoxNux?=
 =?us-ascii?Q?n4beJNGYiHEBpNLWC0AnV9L7KoqFbnN0uQWPeVrqQf4DI4IW0L3c2FVJiIR7?=
 =?us-ascii?Q?fYs23L/Uw/GunwmdCff1/3NhqA2yGTPzGI0CSryaDMR8vXMYwF4M4dHdhiDY?=
 =?us-ascii?Q?VdlAQ9/kMchJxRet6+hU9ALEimEpIRXDUDBcVJr1wRAqnE/nIbSfCe1pjViM?=
 =?us-ascii?Q?XVaJ86dH1TahCBANxfr9uOgo1isutCeDmJm+Rku7K/tL8qeGAk6KOV9SNTyk?=
 =?us-ascii?Q?zztVxq1KDBnD6OcXf//96o0SZtfTyZCnorQWdQzTHEZL5rEd8LIsioGSZHef?=
 =?us-ascii?Q?79QmaL5//aAPj7fuYE6kP/kdRQ2shrmJ8sCsVCThAexFJJlQkMafFBuCuQfN?=
 =?us-ascii?Q?Vg=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 09b8670c-7443-429f-c2ee-08db83824ad5
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 09:19:42.8952
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iSa7NSNj4TB5fRdSUhN+6grm8wsHHae1IXwogZfUPJPDiFJui+d9gOLrRkFRwyVDWVMJuEs4jjvgVmtsNc6r+hegR1ah6/XnxieIg4F2vGg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR13MB6323
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jul 13, 2023 at 11:00:07AM +0200, Michael Walle wrote:
> Hi Simon,
> 
> Am 2023-07-13 10:56, schrieb Simon Horman:
> > On Wed, Jul 12, 2023 at 05:07:08PM +0200, Michael Walle wrote:
> > 
> > ...
> > 
> > > @@ -780,6 +782,7 @@ static int get_phy_c45_devs_in_pkg(struct
> > > mii_bus *bus, int addr, int dev_addr,
> > >   * the "devices in package" is invalid.
> > >   */
> > >  static int get_phy_c45_ids(struct mii_bus *bus, int addr,
> > > +			   enum phy_access_mode mode,
> > 
> > Please add the new mode parameter to the kernel doc for this function,
> > which is in the lines preceding this hunk.
> 
> Ahh. Sorry. You've already mentioned that last time :/
> 
> Also true for get_phy_c45_devs_in_pkg().

Thanks, I missed that one today.