Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 13 Jul 2023 11:02:41 +0100
From:   Lee Jones <lee@kernel.org>
To:     Jean-Jacques Hiblot <jjhiblot@traphandler.com>
Cc:     pavel@ucw.cz, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: Re: [PATCH v10 2/5] leds: provide devm_of_led_get_optional()
Message-ID: <20230713100241.GI10768@google.com>
References: <20230624084217.3079205-1-jjhiblot@traphandler.com>
 <20230624084217.3079205-3-jjhiblot@traphandler.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230624084217.3079205-3-jjhiblot@traphandler.com>
Precedence: bulk

On Sat, 24 Jun 2023, Jean-Jacques Hiblot wrote:

> This version of devm_of_led_get() doesn't fail if a LED is not found.
> Instead it returns a NULL pointer.
> 
> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@traphandler.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> ---
>  drivers/leds/led-class.c | 25 +++++++++++++++++++++++++
>  include/linux/leds.h     |  2 ++
>  2 files changed, 27 insertions(+)

What Markus said isn't wrong, but isn't a blocker either.  He's just
repeating Linus' preferences with respect to commit logs.  Ideally you
should be explaining what the problem is and what this patch does to
solve it in a manner that is more directing and less explanatory in the
past tense.

-- 
Lee Jones [李琼斯]