Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757305AbXJXULZ (ORCPT ); Wed, 24 Oct 2007 16:11:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753561AbXJXULO (ORCPT ); Wed, 24 Oct 2007 16:11:14 -0400 Received: from e33.co.us.ibm.com ([32.97.110.151]:45838 "EHLO e33.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753146AbXJXULL (ORCPT ); Wed, 24 Oct 2007 16:11:11 -0400 In-Reply-To: To: David Stevens Cc: Adrian Bunk , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, netdev-owner@vger.kernel.org MIME-Version: 1.0 Subject: Re: [2.6 patch] unexport icmpmsg_statistics X-Mailer: Lotus Notes Release 7.0 HF277 June 21, 2006 Message-ID: From: David Stevens Date: Wed, 24 Oct 2007 13:11:02 -0700 X-MIMETrack: Serialize by Router on D03NM121/03/M/IBM(Release 7.0.2FP2HF300 | September 14, 2007) at 10/24/2007 14:11:03, Serialize complete at 10/24/2007 14:11:03 Content-Type: text/plain; charset="US-ASCII" Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1361 Lines: 31 I took a look at the DCCP references, and I think they're just incrementing the wrong MIB variable -- e.g., it's incrementing ICMP_MIB_INERRORS when the skb length is less than the header indicates. That's not an ICMP_MIB_INERRORS error, that's an IPSTATS_MIB_INHDRERRORS error. ICMP_MIB_INERRORS is when you receive an ICMP error packet; an IP header error is something else entirely. That's followed by a failed lookup incrementing ICMP_MIB_INERRORS which should be an unknown port error in the transport MIB (assuming it has one-- it's not an ICMP error; could be an IP error, if the address isn't local, rather than unknown port). In SCTP, it appears to have similar problems. SCTP errors are not ICMP errors, though it perhaps should be calling icmp_send() to send one to the offending host for some of the cases. I haven't seen any ICMP-relevant stats correctly referenced in these yet. I don't want to patch them directly, since I can't easily test them; if someone who works with DCCP and SCTP would like to, I'd be happy to review. Any volunteers? +-DLS - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/