Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Ajay Kaher <akaher@vmware.com>
To:     rostedt@goodmis.org, shuah@kernel.org, mhiramat@kernel.org
Cc:     chinglinyu@google.com, linux-kernel@vger.kernel.org,
        linux-kselftest@vger.kernel.org,
        linux-trace-kernel@vger.kernel.org, lkp@intel.com,
        namit@vmware.com, oe-lkp@lists.linux.dev, akaher@vmware.com,
        amakhalov@vmware.com, er.ajay.kaher@gmail.com,
        srivatsa@csail.mit.edu, tkundu@vmware.com, vsirnapalli@vmware.com
Subject: [PATCH v4 01/10] tracing: Require all trace events to have a TRACE_SYSTEM
Date:   Thu, 13 Jul 2023 17:03:15 +0530
Message-Id: <1689248004-8158-2-git-send-email-akaher@vmware.com>
In-Reply-To: <1689248004-8158-1-git-send-email-akaher@vmware.com>
References: <1689248004-8158-1-git-send-email-akaher@vmware.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hhymFcnxW++7+3/AQLnOlGq0dtDdW2jBB/i8E+Y0DWzTprSZnK3Ec7kaIuS4?=
 =?us-ascii?Q?FuCCsLzHaPCxruQGQQP7G0NKNV76EFHD0j+BTLwCXIhjwBCbIkNG21ity0Ps?=
 =?us-ascii?Q?qB+icF15stuEZdI0fc/sFLeDpgz6QzSwfA0yFD1YZkbeGN6YDF8Lf6JMVFZl?=
 =?us-ascii?Q?VOqhBEeEQrW133TrQdRR/mzs0IyySsCmzb4Hje7Bs9RPvztfXXik3iO1JlO+?=
 =?us-ascii?Q?INIzTNQ1ZJystMXCR1u/fyA1JYP9bLZoAi7BTrBFekPYoBsZ54lIW46yrOpm?=
 =?us-ascii?Q?9pw2hYRORl7juruonm08apNn5T5aEiboUyZLmcUCz74jf9QyM5qaIAkKKbCS?=
 =?us-ascii?Q?pltGqVW8t0p1HoCgCmTIeHfikqlSJHrdTWSzv06pGD0zelo+5lTKo4SJiLDh?=
 =?us-ascii?Q?9g2/V3tegfOBeW3Qnde/vBJpuT+lX5kvDrknvqBz1vaz9q/bb6tubBmlt5jm?=
 =?us-ascii?Q?cPP6LZ8wXDBWDSMNlasyOBfAC1GLE05J/sJ8y/HcPKHbgm+p7HzWvAkp9Uqw?=
 =?us-ascii?Q?FkADXVfSp5AhAqZ2XpAfIjK7WDC9ypsTDV3iWIIkhXjwZXwtRGx7rLDjByg9?=
 =?us-ascii?Q?rrfEx8ieVaeE9dpzXXDKgZkr1yo2v+nt4JLuNozFpph/jkd4yusgVyqGFziq?=
 =?us-ascii?Q?Whb9Jx/B3Lz1ESrZKgn/EZdKsfzTxImWOWPUATmLwzoiAA6lKEf4Dk7YYP7q?=
 =?us-ascii?Q?WKn65NK7HQhPjv6aFrH1pBQg570mOSzUfDCEybMantSbijjKvOjrvWLtQg/A?=
 =?us-ascii?Q?POERN0PMLONlS6Rg2ebj+cJJWVsl24/tdhOWGO8XjwDI1K4QzA9IX7Bd4JCU?=
 =?us-ascii?Q?l59MGIlpFdIXSmVUPyAwtnks2qSB+/byac02P2kWzl83PJlYO0CPsH1Oxnmx?=
 =?us-ascii?Q?4mOpxaGJbmnCIyOYikeA5De7z5S+vWi3L3D8A0e1UmnU1RzhofUJFx7WR8ym?=
 =?us-ascii?Q?brr0V79rwm8qYO0c+bqpwYuolp2IcA8RdCVC6nRZbkZHMKj5N5a+VzQwWX+r?=
 =?us-ascii?Q?JZeE5YRYPXOrKIsw570gpQ6ykBxtXVsIJknE69KGMl2HDwJAlW5BaneuRAM2?=
 =?us-ascii?Q?DjN8ZzSuWsy4FQMR1z0+pRYzXaJmNHQpJeUjXYn43gCvwyrkjOSG0FlmvrvX?=
 =?us-ascii?Q?HdLrhamQaOOL4TA1zpHIymrn2Qqi3wkdWUk4Jr8XJ7zRSzk1yrbUvNJGmLv3?=
 =?us-ascii?Q?x2cfTIR7U5x08fN2IdL/H3Mhb8l3riQj4Ah5JS28440d4fVOZahSqa8avLFT?=
 =?us-ascii?Q?3mXibS3vM9SSzgKFROrmdmVfHoCpd7hWLYYYARzk12vp3ki1DadP6RLR2Rrd?=
 =?us-ascii?Q?T+OOWIo0DJo3NOEcOTJu1NuQWSkVfA74MOHoZtvZzfLhTgHvkzBaxbsIZV61?=
 =?us-ascii?Q?O3KpmbGnT5/FB/nn2kcO5RQoMYriK7XRPzA6mnqA9a4Lm2lLjsKhJLAA/zSp?=
 =?us-ascii?Q?RO+6fM8Mn+xpynAVh5M/qxcZELnTbXIWmhMdi5Foa/fkb56nVLIoZiv8z9zl?=
 =?us-ascii?Q?WAHUPkuAwOdOuPTyYwgtGc0ZOY0kMZIbGhn5uf01zcBG+Ek9Eybr5kfsffaf?=
 =?us-ascii?Q?lcFjGgHcnVaXHT/4/lAQJqH3s90Up7w8n09CBuu7?=
X-OriginatorOrg: vmware.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1b9e4ba4-9e69-4942-2750-08db83950b7d
X-MS-Exchange-CrossTenant-AuthSource: PH0PR05MB8703.namprd05.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 11:33:57.1132
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Pr55Gt8rHTiApn7kuFSz1gl3/MOMtlZA4uyc9oQkrgd7DLqRoTc6fIgKYci+na64uL/2xMJxB+9mmIMWK6GaOQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR05MB8719
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: "Steven Rostedt (Google)" <rostedt@goodmis.org>

The creation of the trace event directory requires that a TRACE_SYSTEM is
defined that the trace event directory is added within the system it was
defined in.

The code handled the case where a TRACE_SYSTEM was not added, and would
then add the event at the events directory. But nothing should be doing
this. This code also prevents the implementation of creating dynamic
dentrys for the eventfs system.

As this path has never been hit on correct code, remove it. If it does get
hit, issues a WARN_ON_ONCE() and return ENODEV.

Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Signed-off-by: Ajay Kaher <akaher@vmware.com>
---
 kernel/trace/trace_events.c | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
index 57e539d47989..12ed71428939 100644
--- a/kernel/trace/trace_events.c
+++ b/kernel/trace/trace_events.c
@@ -2426,14 +2426,15 @@ event_create_dir(struct dentry *parent, struct trace_event_file *file)
 
 	/*
 	 * If the trace point header did not define TRACE_SYSTEM
-	 * then the system would be called "TRACE_SYSTEM".
+	 * then the system would be called "TRACE_SYSTEM". This should
+	 * never happen.
 	 */
-	if (strcmp(call->class->system, TRACE_SYSTEM) != 0) {
-		d_events = event_subsystem_dir(tr, call->class->system, file, parent);
-		if (!d_events)
-			return -ENOMEM;
-	} else
-		d_events = parent;
+	if (WARN_ON_ONCE(strcmp(call->class->system, TRACE_SYSTEM) == 0))
+		return -ENODEV;
+
+	d_events = event_subsystem_dir(tr, call->class->system, file, parent);
+	if (!d_events)
+		return -ENOMEM;
 
 	name = trace_event_name(call);
 	file->dir = tracefs_create_dir(name, d_events);
-- 
2.39.0