Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759765AbXJXUna (ORCPT ); Wed, 24 Oct 2007 16:43:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756003AbXJXUnT (ORCPT ); Wed, 24 Oct 2007 16:43:19 -0400 Received: from e31.co.us.ibm.com ([32.97.110.149]:58582 "EHLO e31.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755919AbXJXUnS (ORCPT ); Wed, 24 Oct 2007 16:43:18 -0400 In-Reply-To: <471FAA03.9090003@hp.com> To: Vlad Yasevich Cc: Adrian Bunk , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, netdev-owner@vger.kernel.org MIME-Version: 1.0 Subject: Re: [2.6 patch] unexport icmpmsg_statistics X-Mailer: Lotus Notes Release 7.0 HF277 June 21, 2006 Message-ID: From: David Stevens Date: Wed, 24 Oct 2007 13:43:14 -0700 X-MIMETrack: Serialize by Router on D03NM121/03/M/IBM(Release 7.0.2FP2HF300 | September 14, 2007) at 10/24/2007 14:43:15, Serialize complete at 10/24/2007 14:43:15 Content-Type: text/plain; charset="US-ASCII" Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1475 Lines: 34 My bad -- I see what it's doing, and it looks ok after all. I thought I saw an INMSGS (but didn't). These are ICMP errors that went through icmp_rcv() and were counted correctly before getting to the protocol error handlers. These are failures due mostly to not having enough, or the right protocol info in the error packet being handled. I'm not sure I'd count those as ICMP errors, since the ICMP header itself is correct, but ok... SCTP doesn't look so bad, though I think the references are still questionable (but debatable) as ICMP errors. sctp_v4_err is incrementing ICMP_MIB_INERRORS if there isn't enough IP header to find the ports, I see. I'm not sure that counts as an ICMP error, but it's not so terrible. It's doing the same thing if a lookup fails to match "vtag" from the encapsulated error packet. Again, I don't know that those are ICMP errors (which normally are something wrong with the ICMP header). So, I stand corrected, and sorry about the histrionics. Since these are arguably ICMP errors, and since errors is the only thing being MIB-counted in DCCP and SCTP, then it now looks ok to me as-is, and also ok to remove icmpmsg_statistics from exporting. +-DLS - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/