Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wang Ming <machel@vivo.com>
To:     Alexander Viro <viro@zeniv.linux.org.uk>,
        Christian Brauner <brauner@kernel.org>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     opensource.kernel@vivo.com, Wang Ming <machel@vivo.com>
Subject: [PATCH v1] fs: Fix error checking for d_hash_and_lookup()
Date:   Thu, 13 Jul 2023 20:05:42 +0800
Message-Id: <20230713120555.7025-1-machel@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?unEIS/mH64WzGb09ObBlR0HDkC6h34okJMHQlNr0U9s4BzEMWNd0Fq4fjA33?=
 =?us-ascii?Q?YCHGO00Sqg75bjNGG+h/C+dMttedlAbS6Utctchq+7nNa1Pan/5seOxM35QV?=
 =?us-ascii?Q?hC5eTSk/gwrGVS/eJjZKyw27fbpRNhTr2KhMZzgyvO9+fusdXJ3+H2kMiLHq?=
 =?us-ascii?Q?imYSe5uU9XzZEXiQ7cxIo0Lb/rY7e6eWt5nQLACchMEjMchb1maCaKbV14oK?=
 =?us-ascii?Q?N9bxh5tqeSBKjx7+WdxzxRVp5SPdEHyJjXNjqVOgwLiMWIQb975jg71bcqEg?=
 =?us-ascii?Q?ye5lXEEjtqC8h0W7oX5bgVCiUr7b4ZAsJ9+hhHXtV8iJ7LIGT8UzcsjLNZXp?=
 =?us-ascii?Q?LALnU4rSj+lb9VWQRXHBMZmNKWIyiaDE1eTZGE+TZUVXAEj2MVWAVuVpNkXq?=
 =?us-ascii?Q?PtOREuixYdWDeMyi0lIvIKXWQKPjVZ+41QqEyZ9fnrDacxpAf+I8ZiJcNyZM?=
 =?us-ascii?Q?M6Vz504dBPcyEqi/kyK/f6nz4Kyb5NklVkN//xRAINOx9WFoDe6GfcR/j1Nv?=
 =?us-ascii?Q?BsYh1/OcxdQpK10qVoT6HVYUIzpILqByoAfn58jVRk9xub0xEf+UurBWH8G/?=
 =?us-ascii?Q?DZAgtQ6ARH1jlqZ0eLPemXp3Ztcv+O+VNKMF8I1SC++JVKApBOjp44DrRqIq?=
 =?us-ascii?Q?qeQvsQg7vlMhiNqOo14GWR+L/6wwaoLCXho8eqY7p9fWLrkenYhKQtg9nqD4?=
 =?us-ascii?Q?wivSocpYtoMAsN+CJhT5zabXZFA/WcDk80w2CiwNs+zX6fxpyUac8YMMLfNR?=
 =?us-ascii?Q?PA7PGOHuiP88kyDk9SCDk9yU7Kwy+J4xmCy3j4+im9vwrUIOK/eat8rF67Ap?=
 =?us-ascii?Q?jWX/Splq0g+kwUkBdmRNN4Md6lvf4q7PRZYHqZ/LtPJ15dubLRfc/C/bu9wn?=
 =?us-ascii?Q?/8d/GuTjLjDNe1yL2R0U3iGItF4jgZofgveHSCJrs5EfivmNUP8qJcYgNb3Q?=
 =?us-ascii?Q?Z58dhwqjihklHQPi2qNXosTwW/AB4WNXJKGdxcrEmsyg81+t48yLZ3ayzAHz?=
 =?us-ascii?Q?6Ub5ZJO+MnSEEDkeRqmVMMVaegcKlb+3HYdaLnOS9J21abvsuisRy/IgW3xa?=
 =?us-ascii?Q?BypJywrKBZt6LAzSYCxoAXko436bAMt8JVrX41o+blF74JstYwDixE2vOXe5?=
 =?us-ascii?Q?5P1Vewg4pt5B6yn4mFm8XqJAjvZgCpV5Zw3RFTUAlun0QGH1wwmmkwm7QRtl?=
 =?us-ascii?Q?xWtm8o8gE0K9Hmx+Q8Ekyprb6m6eojEOkRQ7rx7NZlAd0qeCZpEMRTR4kbWy?=
 =?us-ascii?Q?eRkZiVzef7uEMmTANDmmG5DHEzhn0xnspHJLBkCZSrN4fyZBxjo+xVwagr+H?=
 =?us-ascii?Q?mVGCfQfnA8DhKBLtw7p5w2Up7M6XCWiEM2sTCl9ssWGNWSHL2bndj38x8PNV?=
 =?us-ascii?Q?HfZc/Kl0GJVn/xk564QcfnHLVSYp9gyzyH9JI6512PpgZjcpDfy2Xxr3TO/r?=
 =?us-ascii?Q?eeATWr7ch4/creAMVENNY2Xx19iULp/UhbYf9Da1Hrd6vqPywqb0Eegl1Lif?=
 =?us-ascii?Q?nZZYMAMUgC4KbOQ4qegA4seutPcg2MvtTFdNhbUKl1rqDhhv+4kZyFsDBMVi?=
 =?us-ascii?Q?nqFBa1XdBI6bZq4o03o3roqYgfaWP3+mk3Nr6Cr2?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ab212972-cbe5-44c2-5647-08db8399892a
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3743.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 12:06:06.0462
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: esbRtmEFffytEfB2mooOXyk14DcdEW7gFYBXaajHQFOWjgCVM9f+Bt9cY1WnibvncDLKNn+jzn7Oz2CO6AF3eA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR06MB6757
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The d_hash_and_lookup() function returns error pointers or NULL.
Most incorrect error checks were fixed, but the one in int path_pts()
was forgotten.

Fixes: eedf265aa003 ("devpts: Make each mount of devpts an independent filesystem.")
Signed-off-by: Wang Ming <machel@vivo.com>
---
 fs/namei.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/namei.c b/fs/namei.c
index e56ff39a79bc..2bae29ea52ff 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -2890,7 +2890,7 @@ int path_pts(struct path *path)
 	dput(path->dentry);
 	path->dentry = parent;
 	child = d_hash_and_lookup(parent, &this);
-	if (!child)
+	if (IS_ERR_OR_NULL(child))
 		return -ENOENT;
 
 	path->dentry = child;
-- 
2.25.1