Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756922AbXJXUwI (ORCPT ); Wed, 24 Oct 2007 16:52:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753056AbXJXUv4 (ORCPT ); Wed, 24 Oct 2007 16:51:56 -0400 Received: from DSL022.labridge.com ([206.117.136.22]:3636 "EHLO perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752922AbXJXUvz (ORCPT ); Wed, 24 Oct 2007 16:51:55 -0400 Subject: Re: Stringbuf, v2 From: Joe Perches To: Matthew Wilcox Cc: Linus Torvalds , Andrew Morton , linux-kernel@vger.kernel.org In-Reply-To: <20071024195847.GE27248@parisc-linux.org> References: <20071024195847.GE27248@parisc-linux.org> Content-Type: text/plain Date: Wed, 24 Oct 2007 13:51:37 -0700 Message-Id: <1193259097.19617.18.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.12.0-2mdv2008.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 743 Lines: 22 On Wed, 2007-10-24 at 13:58 -0600, Matthew Wilcox wrote: > - Pass a gfp_t to sb_printk sb_printf As it doesn't actually output anything but extends a buffer pointer in a struct, perhaps it's better to rename sb_printf to sb_sprintf. I believe the common use will be GFP_ATOMIC. Perhaps a default wrapper define and a renamed function? void sb_sprintf_gfp(struct stringbuf *sb, gfp_t gfp, const char *fmt, ...) #define sb_sprintf(sb, fmt, arg...) \ sb_sprintf_gfp(sb, GFP_ATOMIC, fmt, ##arg) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/