Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 13 Jul 2023 13:10:14 +0100
From:   Matthew Wilcox <willy@infradead.org>
To:     Miaohe Lin <linmiaohe@huawei.com>
Cc:     akpm@linux-foundation.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: remove some useless comments of node_stat_item
Message-ID: <ZK/ppvBO00rbspa8@casper.infradead.org>
References: <20230713114915.74671-1-linmiaohe@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230713114915.74671-1-linmiaohe@huawei.com>
Precedence: bulk

On Thu, Jul 13, 2023 at 07:49:15PM +0800, Miaohe Lin wrote:
> Some comments of node_stat_item are not that helpful and even confusing,
> so remove them. No functional change intended.

No, that's very useful and important.  Why does it confuse you?

>  enum node_stat_item {
>  	NR_LRU_BASE,
>  	NR_INACTIVE_ANON = NR_LRU_BASE, /* must match order of LRU_[IN]ACTIVE */
> -	NR_ACTIVE_ANON,		/*  "     "     "   "       "         */
> -	NR_INACTIVE_FILE,	/*  "     "     "   "       "         */
> -	NR_ACTIVE_FILE,		/*  "     "     "   "       "         */
> -	NR_UNEVICTABLE,		/*  "     "     "   "       "         */
> +	NR_ACTIVE_ANON,
> +	NR_INACTIVE_FILE,
> +	NR_ACTIVE_FILE,
> +	NR_UNEVICTABLE,
>  	NR_SLAB_RECLAIMABLE_B,
>  	NR_SLAB_UNRECLAIMABLE_B,
>  	NR_ISOLATED_ANON,	/* Temporary isolated pages from anon lru */
> -- 
> 2.33.0
> 
>