Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To:     Yu Kuai <yukuai1@huaweicloud.com>
CC:     "mhartmay@linux.ibm.com" <mhartmay@linux.ibm.com>,
        "bblock@linux.ibm.com" <bblock@linux.ibm.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "hch@lst.de" <hch@lst.de>, "axboe@kernel.dk" <axboe@kernel.dk>,
        "yukuai3@huawei.com" <yukuai3@huawei.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scsi/sg: fix checking return value of blk_get_queue()
Thread-Topic: [PATCH] scsi/sg: fix checking return value of blk_get_queue()
Thread-Index: AQHZtYSQnzKxZ0Itxk6F+okOIyyKAg==
Date:   Thu, 13 Jul 2023 12:21:35 +0000
Message-ID: <byd2qxkpr3hfwbwqvyfhzme5tj22ysl73anejw6wcrqnq5eh7k@datuhqcrjprq>
References: <20230705024001.177585-1-yukuai1@huaweicloud.com>
In-Reply-To: <20230705024001.177585-1-yukuai1@huaweicloud.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?p/4vrI1psDXr/KlItKtqIa178UK7hNETodcnZAI9XxMx/tCBiCKETwxje1c1?=
 =?us-ascii?Q?fuH0W8LD6KX8L83jiFQ7Ts6CDxms5/gPe2oorbfkDNgO7YVjJUfWp437gZ7u?=
 =?us-ascii?Q?DVl6DEEsXmmbRNDLdPGunqd5UQCROIllZaPxO+My+VKoNcNnZj4AEx37rjSh?=
 =?us-ascii?Q?dhhyooX18u7XGsqZ1FRO3iuJ2F/Hz2Z8EiVc7hlVCOU8WyE+YKYhmYEdioxv?=
 =?us-ascii?Q?eHthvlaVyM4jGhVUrA6po1xXC+paYWtONor9YWIVTdvzlpzTcOThniQB8YTM?=
 =?us-ascii?Q?m+LVW/yRztq9Kr7jisMY6zQ6zCwso6eqCN/RlxR/uu7NOolCtNdXIcVniwMF?=
 =?us-ascii?Q?dVu7myDC70ZQAo5M+tWzCW/wU9wEyWzF6v21R1WcuFBbLek+S0pQPELOgEkp?=
 =?us-ascii?Q?CoUGMK48SpjV/uePxUNUH8xCaNx/rM51ACIpKrn8mfCJ1Q8U0M+q/7CafccS?=
 =?us-ascii?Q?up/Pj319X8HUD8Mk/xdtBpQUjy7WBHPKgNlmKyKjgCVRqGkVWQXlNLKn9msT?=
 =?us-ascii?Q?m0hkYZaPMtkLjb4mWLmClM8WZtAfcBxVbzvbO4btwhhOAuSYVoJiQ0+Ipygy?=
 =?us-ascii?Q?c/yjQyLcgArtvvhPqPmCnlyJpzKZLTA+PvGk1AKdbiPuEzIAPvALdUTQm/7+?=
 =?us-ascii?Q?6xPMn5dMczeDKCh8fitEM90jd/Q70Ti4caf3aye2pw2LFztoDFrmqHUVFIr6?=
 =?us-ascii?Q?MUO2R1vqePse/CXZeptw/OFpcTXYqaM/JrmnditLt5787zDlLfvv9mlZ0dFf?=
 =?us-ascii?Q?v25e/4wOFemDMl4dnbtXtCRhfXMBK56m0fe/jSnLSn+6K4aAxc5WN4zj9TmU?=
 =?us-ascii?Q?2EdKZqtA8tChPKlPjiMQYlAFkZqFSBYOA/eyfbeIbPkZHX3wYYsJgl/vGbLY?=
 =?us-ascii?Q?4RC86VGuivHUWbLSBt+jNgMeUoLB8V/TrK2aw9ZG+kG2c/LGRif0h2L+gpwX?=
 =?us-ascii?Q?6NrQgCb0oHvu/trUHMFFGtS3QNGdO2JNvQ49HbOM05O1l1tJykDsau2J8Mrr?=
 =?us-ascii?Q?GjyhcZm6pgkS1EUEcoNWKPsVvRhweZFNhjpqCXbbNqkdXn/JEksjJaW8azTp?=
 =?us-ascii?Q?zTop1s/sMVyb3x0f7eItyvCZu8wuqAbBa47O8EsQuWATvAnrxIZTBKARLVd8?=
 =?us-ascii?Q?XxRz6NbMNzzYC2kE6yA8KKtZPujM07FLGp59h7ECTAvkFNT45sSTDGlUyQgH?=
 =?us-ascii?Q?QRsbz+4if2GfKf24w7X7JqDoY+QWijBOluiuLUlmfgdt8WyU0oCsNU5GOOiA?=
 =?us-ascii?Q?I4RnzoMgczIS6K0z2yRV+68L+u77q2t2uXqLgsc925v/cc0769v2W437MkvC?=
 =?us-ascii?Q?Wge6YbdIUXGSpZQJD7hITs8sSa+nxn1lsj96RV7AbqzlEM2tNOXg36zkpkaK?=
 =?us-ascii?Q?ACQhks8CejjzJxDe1MgIYKbkXVLBFhdhBKwvJK5bBZsaEiStBytFbpvwV5jO?=
 =?us-ascii?Q?kvU6HKhiFTn5g9CPbu6NqH7pMy81djJQoUB+vZ1GlfsttsY+alQ1rvTM45/7?=
 =?us-ascii?Q?xK8pWFA73XnjUEdRt14aXXRqGpYfhqaJpYXkkrpqpJiKFWcwqU83msjYRw21?=
 =?us-ascii?Q?HmJsjeXP0gR+nkj65nYUSwHfq6q0SxCi0Uv18C8cLXa7cpq1c+dco15KYp8E?=
 =?us-ascii?Q?QO6ZW/5EUWhRSbfK7TnDYlA=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <EEC3775696798E44BF56A7A80766E444@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?Io6+QriZ7/NthSFj4Do/Sd9AnFVvLn0elztaayQrU5ZpdsITJp177H8mSuvc?=
 =?us-ascii?Q?PTFMprKD0fHMEAhYjOvzBTvPVMZYhfNBPe2hlp4nzKGZdNV7RPmUsSRp5Emo?=
 =?us-ascii?Q?fGPKQ2w0VlZ8l9yDMWL0hiyv9jMzQWG1GegjpBd+EgPJUpYAVDjkoQZ3+1zz?=
 =?us-ascii?Q?d13mqGZYMnNdu9GMxUMyhi20ju/kN3DNHDz68zHVAYoCgwae1IOMFTxWME0K?=
 =?us-ascii?Q?VN3IajPBFpRqOVJLract9y3WT+NX3ttdYElZmKzc/dYszv6A93mbU/dFNEFi?=
 =?us-ascii?Q?Pp8/da/MwxcewunDeQzry+HMLGFQWOq1dEMvLztka9n6Kfht3nspkKbytpDo?=
 =?us-ascii?Q?SnVZyAlTz6lk/YNhgmQMvnovRKu1nDZsqrYQPsYNq8o1IHoaJL0HBZWf7WQB?=
 =?us-ascii?Q?2/kePumiwIQ13xr//H+KSyBUzJGyuigFneahGNCtGuvIYDyRFqm84kFdmeWc?=
 =?us-ascii?Q?33dWZ9sAtiAlcaMlfnaCaH5elLoQDF7t9WrkleBJfjHlmzmLRrBvU8RR5ths?=
 =?us-ascii?Q?SmRHJKPhCGWIDnJDD6/bK0/rNC+r24WetuD3KfUu5ypw/1/ZXBOuhyl58RgI?=
 =?us-ascii?Q?2Q1rMpKXe9hK5wj8S3Y+xLH3UaheZA+KQ2KEd3gCb1E+ggNoJ0MHfD5kRK2V?=
 =?us-ascii?Q?R9f/LUmtcfMpNdULELX6Q6s5bWOP3kmDEDIXouvP6/0WHVm2xQIBruINF8gH?=
 =?us-ascii?Q?9R5PyLiXZq9uRCvA9QQ20Kp84vfMgjd9PQR/6G7/+U1K0i5vtfzrr5yITmle?=
 =?us-ascii?Q?NU6Xmhouks0+vl/E/KCSSXHz/PA3z20U6Q9rtDeW4Mk1AGtHlDfC6OKCqZut?=
 =?us-ascii?Q?M5SqTPkqyXMuFlju7CaIze0MtXMKLQKHT0m4Ozrj1BFQ9jlSmM3j7S0W76Kv?=
 =?us-ascii?Q?yYelvjVLzGEwbOlGXg3o10p90K+z7ooJi5VTR2RJuvI6NMAHLsU82sl/XFvv?=
 =?us-ascii?Q?K0/9JJtgGhlozmBsieiXHQ=3D=3D?=
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR04MB8037.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 010fab9a-0ab9-44f7-f291-08db839bb3a8
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2023 12:21:36.0039
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: uix41mkoB9S8hYcSlTWq9WlHGYKS1h4Pge7Hp7W5JxrD5Y6YDmInGphubI3CbfWtDEx2VrNWu4b5tsgXphQJqZAWvrkiLvzJrT4/+rjeO8U=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR04MB7705
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Jul 05, 2023 / 10:40, Yu Kuai wrote:
> From: Yu Kuai <yukuai3@huawei.com>
>=20
> Commit fcaa174a9c99 ("scsi/sg: don't grab scsi host module reference")
> make a mess how blk_get_queue() is called, blk_get_queue() returns true
> on success while the caller expects it returns 0 on success.
>=20
> Fix this problem and also add a corresponding error message on failure.
>=20
> Fixes: fcaa174a9c99 ("scsi/sg: don't grab scsi host module reference")
> Reported-by: Marc Hartmayer <mhartmay@linux.ibm.com>
> Closes: https://lore.kernel.org/all/87lefv622n.fsf@linux.ibm.com/
> Signed-off-by: Yu Kuai <yukuai3@huawei.com>

I observed that /dev/sg* files are not created with kernel v6.5-rc1, and it
causes blktests scsi/002 failure. I confirmed this patch fixes it. Thanks.

Tested-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>