Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp1085942rwp; Thu, 13 Jul 2023 06:04:29 -0700 (PDT) X-Google-Smtp-Source: APBJJlG7njdkXhVTgNjqr5E2Cc6Gd0liAdru03mLmOCg8dDpt0Kj8oS2FHHJDF5VgARs/9Q0/nA8 X-Received: by 2002:a17:903:22c9:b0:1b8:9b1b:ae8e with SMTP id y9-20020a17090322c900b001b89b1bae8emr978820plg.59.1689253468847; Thu, 13 Jul 2023 06:04:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689253468; cv=none; d=google.com; s=arc-20160816; b=xBv7RpCCSZ+CQr2b3leJYYscDSBwPFM8gowFRUY/zyzdLIVz3dBDvcN4qb/qy5uNnW fBK3l4aLjZseAXrMrfWW0UVVbrIX2GgvljIBlcfHYLhhzZJ4qv8xPlk+AjDKY3hbw2Ux W72yc9BkZq4mp/mzVTWAg3N1RrnsCR51+BZK9r8deqItQGNQ4tNIIWnc0Q6rzhuC2N2U 5JHY6OmCGQyBtYEKndQuH5wdODkhgZZqy9J0ZUWIQGP+Vw5WBtsSt4zfOfUEWFAMwJwY PxdO5+1etk9C2t2zkSt3qfk35t+8fp7Tih4Kb8kfNEkt/3T8wpZXjqELSeCCnbiDlrPO NRrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version; bh=axzPxQObOkm0Sf3nhhCi8xbN2CVN4Ns9hUBfq/LXKOU=; fh=NrvUiyToSCYKUzKYXSnUWkRKZijHK1He9PG9tJMC6u0=; b=jtYGeyLM4eA+6LbesO5cSolNJm0lG4aIoiOtoW3sNw1K7JmKJwShwLT+NthGqkSJM5 b0I5SLSOEKjyLnKVMMWaHIU70pj9dB8f1I1YESqD5Qa43Ac/MAKh5XzrYCkWOCipJVS6 cTmOPMHKWLePdo9NiitBPBcH2+fGYIng9k/wX8c3bP5e3RmnpQ2nCaMdYRGmFMVJCBzm rFfJ3crLRxR4H2rxv9dLqKLc+kq0c5s9qR1lUTE7ReaYhXQ5vSRUOibymP7hrbCHMhCa YbiNxQxc1PRqUb8QFHkWXzhYIMjKlr0VStv5uQ1rsk68t9bI2qQsnB++CmmgfiqNWClU Y05w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h185-20020a6383c2000000b0055c13ae86b1si4892381pge.597.2023.07.13.06.04.14; Thu, 13 Jul 2023 06:04:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233984AbjGMNDK convert rfc822-to-8bit (ORCPT + 99 others); Thu, 13 Jul 2023 09:03:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234443AbjGMNDC (ORCPT ); Thu, 13 Jul 2023 09:03:02 -0400 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BFA11734; Thu, 13 Jul 2023 06:03:01 -0700 (PDT) Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-98e1fc9d130so21648866b.0; Thu, 13 Jul 2023 06:03:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689253380; x=1691845380; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=P+QGNhyP5nUUkdoa2Q3ypYW8B85kMOs/GN5/k9obJ4w=; b=hxznlX6i6a7eP5IRrw28+/nsPCH09GHzg5C6AyhVIc5GxmxhuD36QbQhhla2CkHNPY HSVBcRdN9InrO70glIurDSUcTgXdpSQwWjslCQmdgphpmd0gm2TPnweReu4Gg3pOSiwT 9RRF053M1jqZirXskL+AcDj+zpfMBD3TQvSCRjGny6D7GTE3pQDoQZhyn7wU4CvJ/fzM MohEHB1aFVihV0jlpaKzGvd0QcbzMsNRwqmtD/Pr43uzJE68fZVWLVlxde4pJ0iU51BL APQdN/Z6YUI5yg1IuFgJ5B69sHzP+Az0m6bHcLoqNiaZZv3xSiWJ8dhaAM5QyNUmfyYu Khkg== X-Gm-Message-State: ABy/qLaYMmLjfHPtepVuanfT+/ZpblvBzCBbBmlYx/PsGEV0Q2GjOX+c tXxGO22+xjP7htwjg/lba4+ShmgudnShnoPnGEDJBN14 X-Received: by 2002:a17:906:77cd:b0:994:33b2:c32d with SMTP id m13-20020a17090677cd00b0099433b2c32dmr1261182ejn.5.1689253379483; Thu, 13 Jul 2023 06:02:59 -0700 (PDT) MIME-Version: 1.0 References: <20230707203731.848188-1-daniel.lezcano@linaro.org> <82b2d4dc-4583-925a-9e3c-77ae30d0d261@linaro.org> <032bda42-ba99-c207-c30d-a5f69bd10095@linaro.org> In-Reply-To: <032bda42-ba99-c207-c30d-a5f69bd10095@linaro.org> From: "Rafael J. Wysocki" Date: Thu, 13 Jul 2023 15:02:48 +0200 Message-ID: Subject: Re: [PATCH v2 0/4] One more step to the thermal zone structure encapsulation To: Daniel Lezcano Cc: "Rafael J. Wysocki" , linux-pm@vger.kernel.org, thierry.reding@gmail.com, linux-kernel@vger.kernel.org, srinivas.pandruvada@linux.intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 13, 2023 at 2:24 PM Daniel Lezcano wrote: > > On 13/07/2023 13:30, Rafael J. Wysocki wrote: > > On Thu, Jul 13, 2023 at 11:33 AM Daniel Lezcano > > wrote: > >> > >> On 07/07/2023 22:37, Daniel Lezcano wrote: > >>> The series provides more changes to self-encapsulate the thermal zone device > >>> structure in order to protect wild accesses to the thermal zone device > >>> internals, especially the trip points and the locks. > >>> > >>> The first patch adds a macro to warn at compilation time if the > >>> thermal_core.h is included in a file not belonging to the thermal core > >>> code. One warning will happen with the nvidia drivers but this is in > >>> the way to be solved. > >>> > >>> The second patch reorders the headers inclusion in the core code. > >>> > >>> The next patches makes the int340x drivers to use the thermal trip > >>> update above and the different accessors for thermal zone structure. > >>> > >>> Daniel Lezcano (4): > >>> thermal/core: Hardening the self-encapsulation > >>> thermal/core: Reorder the headers inclusion > >>> thermal/drivers/int3400: Use thermal zone device wrappers > >>> thermal/drivers/int340x: Do not check the thermal zone state > >>> > >>> drivers/thermal/gov_bang_bang.c | 1 + > >>> drivers/thermal/gov_fair_share.c | 1 + > >>> drivers/thermal/gov_power_allocator.c | 7 +-- > >>> drivers/thermal/gov_step_wise.c | 1 + > >>> drivers/thermal/gov_user_space.c | 1 + > >>> .../intel/int340x_thermal/int3400_thermal.c | 44 +++++++++---------- > >>> drivers/thermal/thermal_acpi.c | 1 + > >>> drivers/thermal/thermal_core.c | 7 +-- > >>> drivers/thermal/thermal_core.h | 4 ++ > >>> drivers/thermal/thermal_helpers.c | 1 + > >>> drivers/thermal/thermal_hwmon.c | 1 + > >>> drivers/thermal/thermal_netlink.c | 1 + > >>> drivers/thermal/thermal_of.c | 1 + > >>> drivers/thermal/thermal_sysfs.c | 1 + > >>> drivers/thermal/thermal_trip.c | 1 + > >>> 15 files changed, 45 insertions(+), 28 deletions(-) > >> > >> Applied > > Sorry, I did not think you may wanted pull them in. > > I can drop them from the tree if you prefer? Let me apply them directly.