Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp1106587rwp; Thu, 13 Jul 2023 06:18:38 -0700 (PDT) X-Google-Smtp-Source: APBJJlFYZ/Ry5g7fZTi8dIfDTN3bMSY/K7u9MCLFCHLTCpAhz7Yq351PTWuic+mpT2HreOn5uqaJ X-Received: by 2002:a05:6402:31e8:b0:51e:5789:a71d with SMTP id dy8-20020a05640231e800b0051e5789a71dmr1940646edb.12.1689254317851; Thu, 13 Jul 2023 06:18:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689254317; cv=none; d=google.com; s=arc-20160816; b=kkx9DGwYvVIau2oxRJMsaSG12X5OGQeW3QYLVZgl3OR03bM3TfMYrscQPFGnLWoym0 NfUOodgimK5tM8p/ebuC7g/3IWhqoNUXhVGEILHzgZZJ0q+2uLoXNx9wOW0/na/wEijN mNbcBT/68pLKmivFpf4LGTPMnDGM7o/FtZZP64OvtRYTlUPM/3HqIPustaZUehXPk9mH issnCTzRE9AoLm+ROPDDy3o/DGSXseJvQRkKqSywtw19QZ0g2QJS4YeA8IzGO4zBFASr TTBNpN2RfBiUVb+7RKGzuAN9RF8mBkj9MqpFKaQoRRge/mejxwEJnkX2sKCedNlxLfPr 5Rtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-signature; bh=fHWIv3bHRzrRKcyf/zVidbDkljZLPdxvWwq51ebKJX8=; fh=itT7reuc6h85ZJmmqIL6coAG2YeJKu+6hQVjL7UtYQU=; b=PTGveicuTIa4b4H+a1X7KAt4dL/Nf5bg0FBElSYt8NaNmmXZiOzNRnoZNldM334TGd h7CfpfNi81ChHwMnM58fedJl80CM7EXgJwHidH4F/uLmGjhPcChlce0gZM33YBONuHDs R37+oDnmscp21jewpWirwaSBG6W2zGStJWFHjQB4R6S9IUiFaugJwJTJ6J8XmEfQasS7 AOWMUyVaelzvOzJ87RoU+BGdV7mjIW9ca3HniR6rg25FgaX0x5SEHpTwnP3ocnLi++Bx XetKHiom84foBVAEtXw3U8yEOcA6xm8dMP76yqrO5r570Q7iIS1sMakHpP7Loj9sn59x EMDQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=KrLQ9ExO; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=cC+16BmI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r4-20020aa7cb84000000b0051e248ee5c1si582029edt.670.2023.07.13.06.18.13; Thu, 13 Jul 2023 06:18:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=KrLQ9ExO; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519 header.b=cC+16BmI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234883AbjGMNEx (ORCPT + 99 others); Thu, 13 Jul 2023 09:04:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234496AbjGMNDq (ORCPT ); Thu, 13 Jul 2023 09:03:46 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA208173B; Thu, 13 Jul 2023 06:03:45 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 78FA71FDAE; Thu, 13 Jul 2023 13:03:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1689253424; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fHWIv3bHRzrRKcyf/zVidbDkljZLPdxvWwq51ebKJX8=; b=KrLQ9ExONJd8bhA047RDMVgp8Yiinradv+N78bSluWIDLuNuCjwO2zbgMvNqTm8IS7N250 JZ5fXSwfj7hJEuerDqT9D7CxE/s/RJnnrWr1WqXO2CHJ8BE+WyygeHX7RAQ+pL/8CEkAnI a/XIFK0q7OmjfSmwD8XvVXiUP68WINE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1689253424; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fHWIv3bHRzrRKcyf/zVidbDkljZLPdxvWwq51ebKJX8=; b=cC+16BmIJtD67C1AxjAYu7NIDMLyAG1Ex+jDKT8ZOZ/w4pvouvA2SEwv/Yx2sRZxBO12WT 6pKuARZIpLfJZ7BQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1C65113489; Thu, 13 Jul 2023 13:03:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id cEQTBjD2r2TVPgAAMHmgww (envelope-from ); Thu, 13 Jul 2023 13:03:44 +0000 From: Thomas Zimmermann To: deller@gmx.de, javierm@redhat.com Cc: linux-sh@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-geode@lists.infradead.org, linux-nvidia@lists.surfsouth.com, linux-hyperv@vger.kernel.org, linux-omap@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, Thomas Zimmermann , Sam Ravnborg , Timur Tabi Subject: [PATCH v2 06/18] fbdev/fsl-diu-fb: Remove flag FBINFO_DEFAULT Date: Thu, 13 Jul 2023 14:58:26 +0200 Message-ID: <20230713130338.31086-7-tzimmermann@suse.de> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230713130338.31086-1-tzimmermann@suse.de> References: <20230713130338.31086-1-tzimmermann@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The flag FBINFO_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by dmam_alloc_coherent(__GFP_ZERO). So do not set it. Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed. v2: * fix commit message (Miguel) Signed-off-by: Thomas Zimmermann Acked-by: Sam Ravnborg Cc: Timur Tabi Cc: Helge Deller --- drivers/video/fbdev/fsl-diu-fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/fsl-diu-fb.c b/drivers/video/fbdev/fsl-diu-fb.c index 785eb8a06943..c62b48f27ba9 100644 --- a/drivers/video/fbdev/fsl-diu-fb.c +++ b/drivers/video/fbdev/fsl-diu-fb.c @@ -1476,7 +1476,7 @@ static int install_fb(struct fb_info *info) info->var.activate = FB_ACTIVATE_NOW; info->fbops = &fsl_diu_ops; - info->flags = FBINFO_DEFAULT | FBINFO_VIRTFB | FBINFO_PARTIAL_PAN_OK | + info->flags = FBINFO_VIRTFB | FBINFO_PARTIAL_PAN_OK | FBINFO_READS_FAST; info->pseudo_palette = mfbi->pseudo_palette; -- 2.41.0