Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp1109436rwp; Thu, 13 Jul 2023 06:20:53 -0700 (PDT) X-Google-Smtp-Source: APBJJlGS11f5R0igNwyDzL4VEIb4bseSSKUkd3pp51H7KyYH0GLAEUWXUnnxiuWVs4uoVB8oNHEE X-Received: by 2002:a17:906:7a17:b0:993:e81a:f093 with SMTP id d23-20020a1709067a1700b00993e81af093mr2649104ejo.26.1689254453243; Thu, 13 Jul 2023 06:20:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689254453; cv=none; d=google.com; s=arc-20160816; b=o2mwIcLCOg3m0Bc0GI9Dilpl6Ei+hkc2FcwO3odNcm7/S1dr1A+VxoLoDo0wiDhgN8 xu7Dh0vx65QtVjrRADB0okRUyAq74gTOiBPT6JZGE6WwPPw1VMz2SexCZSmfnJFqscAm P6/YxCEeB8+EjY0V36M3e1HMN33qtcCWzokEee4zdnQmf9bQvSlReM404VZ7frkNYJTw MHtU0hrtT9jcwzEdnCcl585d6EiJfP/ovkJ3HaI1ZqWv5YPnw8FgiEt3qumf8yCoyrYD TDZavRgkBbKt4rLakWw+AUpLE1kqJ/IApdrEBu01WAR2EaiakwAbFIUSz+ZUBB8tZG36 IW9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=xs/7FADKnAXVjA8+DrUAlRSwNfgpNlGEVv20ZizM5qc=; fh=zAFBK0UQhodNmxeMnf985beraTGxZ8uRkZJU2vCVrpA=; b=Vp0xA2RhvotWjiqQFI1ESHP5c0UI/psIDEYAgusM3eLPqViGyylVtUPf/xTVaL1mem w2wIxZj8qIoKRoT6eBMRjwGllcVlC0TLS9/BiJqGMAEd92OtzNWWaG9JPxLKBeV8qeQF HpJQZ3WXCeCa6mRrJxwzpqbdLtUphVKIUVprVstNUkfKkH4bXB+0fnkSQXWR2SC/Xu3A Tk9IE8wGghR3F7EsuutAMTVuwEUEQKuJTe2jFnKuucXwVTuoeOrEucYB8qz9cj3nD36u sBpVXPn0FCemVVz9YTRqLmv3KsHmz3XV24N7taGWU8cMGh0J5vt/hxNrNGYogIyuuwTF ijCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KkCvrT36; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hh15-20020a170906a94f00b009930253bc69si331546ejb.1011.2023.07.13.06.20.28; Thu, 13 Jul 2023 06:20:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KkCvrT36; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234808AbjGMMxM (ORCPT + 99 others); Thu, 13 Jul 2023 08:53:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234820AbjGMMwz (ORCPT ); Thu, 13 Jul 2023 08:52:55 -0400 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D01EB19BC for ; Thu, 13 Jul 2023 05:52:53 -0700 (PDT) Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-3fbf1b82de7so4148745e9.1 for ; Thu, 13 Jul 2023 05:52:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689252772; x=1691844772; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xs/7FADKnAXVjA8+DrUAlRSwNfgpNlGEVv20ZizM5qc=; b=KkCvrT36OXgG6AbaVd8y5Of2o3Kv7d1CGiRewm70RhIUk5kLjxtLh4ej+PWIN/uIPY UZW0d3DA6EyKL1upS2Z6i3MxXe9tnt90xJuezbrcsst5wLFxkYfn9BlrgS8ZZAQOyXYN EILOKEi2jp3PdRGK4BqlViWGX37UENVU2rn9u+OV9/WhHFYlUU9wjtsvi2YU23Fvbvxw vKu2jDH1toKrda7AdUkQcF1b2wE3bZBfO8yYuDHVVfW3iOyL2S5Bbq97Uhsgp8ucO1sM QulKQ0ttjTaDpB78QOQPf7+Gra7HaLBfeDEIwTGkm/l/XWewfTRP333lXVGu/K0v4eNK MVNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689252772; x=1691844772; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xs/7FADKnAXVjA8+DrUAlRSwNfgpNlGEVv20ZizM5qc=; b=coq+SoFtSUYnaA4/BsC7yV09KE5HabJefkdhXCf3Dl0xzkX2hXIAD3kqn/G4COmp9W wl37+2hK7pGX/JIqImleD3Dcc1IhOv79rjReY6GbaOLccSRsu+N+Lmed4agKPseqz5Xf V4hxch5Rc/gfCljQq3LBuQ3Jn0pnvY/FqiOPGonA/fQdZC65275lXvqF2/HS0ux1FDmw nVc/UWooOf9SZBzqeunGx3VUHQofwcnFkHDBqn57L606t4YbXH/H67PUK58Nmts2hI4I mhnrx3MluQOyMwOscLjxm7WQd0Uubn1L+iC75g1IUJ0ELsUWZcHDtvO1wqFUM38KIahx C6WQ== X-Gm-Message-State: ABy/qLap+C421+MerM9HTFEzvW2e5Bxx5hpljZQA225cj2eYkgfg1cVr vkbqaMbwxeB9dlrwHO4TWxbwXQ== X-Received: by 2002:a05:600c:444d:b0:3fa:91d0:8ddb with SMTP id v13-20020a05600c444d00b003fa91d08ddbmr4138119wmn.14.1689252772241; Thu, 13 Jul 2023 05:52:52 -0700 (PDT) Received: from [192.168.10.46] (146725694.box.freepro.com. [130.180.211.218]) by smtp.googlemail.com with ESMTPSA id t9-20020a5d5349000000b003143b7449ffsm7929562wrv.25.2023.07.13.05.52.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Jul 2023 05:52:51 -0700 (PDT) Message-ID: <913eebe1-1b84-ba34-7ed5-de3154ece666@linaro.org> Date: Thu, 13 Jul 2023 14:52:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 2/2] thermal: of: fix double-free on unregistration Content-Language: en-US To: "Rafael J. Wysocki" , Ahmad Fatoum Cc: Amit Kucheria , Zhang Rui , kernel@pengutronix.de, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230708112720.2897484-1-a.fatoum@pengutronix.de> <20230708112720.2897484-2-a.fatoum@pengutronix.de> From: Daniel Lezcano In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/07/2023 20:05, Rafael J. Wysocki wrote: > On Sat, Jul 8, 2023 at 1:27 PM Ahmad Fatoum wrote: >> >> Since commit 3d439b1a2ad3 ("thermal/core: Alloc-copy-free the thermal >> zone parameters structure"), thermal_zone_device_register() allocates >> a copy of the tzp argument and frees it when unregistering, so >> thermal_of_zone_register() now ends up leaking its original tzp and >> double-freeing the tzp copy. Fix this by locating tzp on stack instead. >> >> Fixes: 3d439b1a2ad3 ("thermal/core: Alloc-copy-free the thermal zone parameters structure") >> Signed-off-by: Ahmad Fatoum > > Daniel, this looks like a genuine fix to me, so I'm inclined to pick > it up directly. > > Any objections? > No objection Acked-by: Daniel Lezcano -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog