Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp1109895rwp; Thu, 13 Jul 2023 06:21:17 -0700 (PDT) X-Google-Smtp-Source: APBJJlHBS6hR7Pc+Ozr6iXiZ5jcaiRN/gAI+etyAXGUEfzcfzx9UVaTMVjwmT6ems6Ors9+/9xE4 X-Received: by 2002:a17:906:196:b0:98e:933:28fe with SMTP id 22-20020a170906019600b0098e093328femr1555420ejb.66.1689254477167; Thu, 13 Jul 2023 06:21:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689254477; cv=none; d=google.com; s=arc-20160816; b=HqKhsYsIm24QpfIx7uKhSwByhrRctkZOJp0Veqkoe26z3Y2kUfZC5DQsdIRzdjCoY+ RcksdPcUV/JrsJ3kq8YA/UDVLw3a0dLHUKEfVzwyEOZTJaojxGP3LmgOQm3j9nmXV23t gGjDIdGn/PZs4aHnCAwHEtNLKtj9gioagzwuvb/Z2bWO43/TilXiAopbEBZy/rMVG2KD EwiveTKMW5n/buT2bXl0IM9IJA56cDPEbmf8DTeuBEJhLjR932W7OCgYDAAPnafGubQw wPntuHSCsCMUVoJElwiuti832sK/GTAKiMlUsKgThgXSDPaGuMFBtw5fVMTtzs28lJKI l2eQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-signature; bh=85l2ukO3ODIPQ6vFxAUAj342VQosexDKbJyC6X6EE14=; fh=mvKkI/feN5uBvMvLKron+TT82pNBp6fnqUuM2n/jviQ=; b=GhDzDjqrTA89Aik+dIvfv7lEjYomZlwhI3FFa4vRBim3SZN/2xYMKVH9AThuZv5DIg E7zR2ly681qvbCN0MX/NFynyIpnRrN29bfZxOdy3UDitHPlka5zW3ziIXjw51MNSgLiv Duu1xk3YKjnyMUx2rgOD4CQPqq68g65wkARRqLf7CdWHjE0joCkyDX4Q3qC7VWA+YXBI ZF2zO/0jbRoCLBBzPubddW8jsGhmfJjHgXB7hOG8bUdCaOlJdeXp2V52ERgAq0cvyDuR Kkk6FqQ+OyCz2lvhEe8A03NDXAK61k/Z/PkEA+Fdt1fYlTIoCfS/jeOmzrfE7OyYtORy 1/Wg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=0IK9TnUE; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t5-20020a170906948500b00993664a998esi831034ejx.918.2023.07.13.06.20.53; Thu, 13 Jul 2023 06:21:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=0IK9TnUE; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235064AbjGMNEb (ORCPT + 99 others); Thu, 13 Jul 2023 09:04:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40552 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234761AbjGMNDv (ORCPT ); Thu, 13 Jul 2023 09:03:51 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59BFB26B0; Thu, 13 Jul 2023 06:03:50 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 045801FDF0; Thu, 13 Jul 2023 13:03:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1689253429; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=85l2ukO3ODIPQ6vFxAUAj342VQosexDKbJyC6X6EE14=; b=0IK9TnUEpskqaKwZeh1pvP4pAKAC8X7Tywu1Bkirku89cBCyjIV2o8ydHtFtKXBoYb6BcI bTczBLnuDR+geSwWv85O6hqT8UY5fU6nMvJ/kLbHDZmkdNHxfSteQbjRjWXv54svsXJYeh rVkA2Eg22IcEbQV65LDqv1SKkChTVUA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1689253429; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=85l2ukO3ODIPQ6vFxAUAj342VQosexDKbJyC6X6EE14=; b=uM0phW8ltWElCOt/XnllnXgL27+VCOMaHS0H7HW5xyXSxgAsD9bwfKYKM30HDj9lVbMaRN Ia2GVAkJmFLv8/CA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8A36013489; Thu, 13 Jul 2023 13:03:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 2Du8IDT2r2TVPgAAMHmgww (envelope-from ); Thu, 13 Jul 2023 13:03:48 +0000 From: Thomas Zimmermann To: deller@gmx.de, javierm@redhat.com Cc: linux-sh@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-geode@lists.infradead.org, linux-nvidia@lists.surfsouth.com, linux-hyperv@vger.kernel.org, linux-omap@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, Thomas Zimmermann , Sam Ravnborg Subject: [PATCH v2 16/18] fbdev/pxafb: Remove flag FBINFO_FLAG_DEFAULT Date: Thu, 13 Jul 2023 14:58:36 +0200 Message-ID: <20230713130338.31086-17-tzimmermann@suse.de> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230713130338.31086-1-tzimmermann@suse.de> References: <20230713130338.31086-1-tzimmermann@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by devm_kzalloc(). So do not set it. Flags should signal differences from the default values. After cleaning up all occurrences of FBINFO_DEFAULT, the token will be removed. v2: * fix commit message (Miguel) Signed-off-by: Thomas Zimmermann Acked-by: Sam Ravnborg Cc: Helge Deller --- drivers/video/fbdev/pxafb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/pxafb.c b/drivers/video/fbdev/pxafb.c index c8c4677d06b4..beffb0602a2c 100644 --- a/drivers/video/fbdev/pxafb.c +++ b/drivers/video/fbdev/pxafb.c @@ -888,7 +888,6 @@ static void init_pxafb_overlay(struct pxafb_info *fbi, struct pxafb_layer *ofb, ofb->fb.var.vmode = FB_VMODE_NONINTERLACED; ofb->fb.fbops = &overlay_fb_ops; - ofb->fb.flags = FBINFO_FLAG_DEFAULT; ofb->fb.node = -1; ofb->fb.pseudo_palette = NULL; -- 2.41.0