Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759042AbXJXVJd (ORCPT ); Wed, 24 Oct 2007 17:09:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754054AbXJXVJW (ORCPT ); Wed, 24 Oct 2007 17:09:22 -0400 Received: from smtp2.linux-foundation.org ([207.189.120.14]:57591 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753819AbXJXVJV (ORCPT ); Wed, 24 Oct 2007 17:09:21 -0400 Date: Wed, 24 Oct 2007 14:08:36 -0700 From: Andrew Morton To: Hugh Dickins Cc: penberg@cs.helsinki.fi, ezk@cs.sunysb.edu, ryan@finnie.org, mhalcrow@us.ibm.com, cjwatson@ubuntu.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, stable@kernel.org Subject: Re: [PATCH] fix tmpfs BUG and AOP_WRITEPAGE_ACTIVATE Message-Id: <20071024140836.a0098180.akpm@linux-foundation.org> In-Reply-To: References: <200710142232.l9EMW8kK029572@agora.fsl.cs.sunysb.edu> <84144f020710150447o94b1babo8b6e6a647828465f@mail.gmail.com> X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.20; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 732 Lines: 22 On Wed, 24 Oct 2007 22:02:15 +0100 (BST) Hugh Dickins wrote: > --- 2.6.24-rc1/mm/shmem.c 2007-10-24 07:16:04.000000000 +0100 > +++ linux/mm/shmem.c 2007-10-24 20:24:31.000000000 +0100 > @@ -915,6 +915,11 @@ static int shmem_writepage(struct page * > struct inode *inode; > > BUG_ON(!PageLocked(page)); > + if (!wbc->for_reclaim) { > + set_page_dirty(page); > + unlock_page(page); > + return 0; > + } > BUG_ON(page_mapped(page)); Needs a comment, methinks. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/