Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp1169862rwp; Thu, 13 Jul 2023 07:10:24 -0700 (PDT) X-Google-Smtp-Source: APBJJlEekyXd7fOEz8tc2m0ZP4ywkQ468AgS5A6t1vT5bohtX3H5OXaqYMj1fGjQRi0b0qVYunxl X-Received: by 2002:aa7:d7c7:0:b0:51e:1932:db07 with SMTP id e7-20020aa7d7c7000000b0051e1932db07mr2144000eds.34.1689257424666; Thu, 13 Jul 2023 07:10:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689257424; cv=none; d=google.com; s=arc-20160816; b=qwR/+4F8nOZNpkVesu5QxP2gMqMQwUyDF8doAElnJrEXF29U+EPClMJWPFym0FROEE dTBTo5nB67hGYVDlmZVVSUizDcFtcebQpjRLTQv8gsG/kLKxRC/eWJ8Wq3FB6c/I7lW8 b/ymNulvchdH05LSIcV6ztsgp0Ep6HjWnhjVEg75M4nCUX2S2/GW0Dx2k1lag5QSoYBI UdvwCqQXaOxFkq/Idvf+za0OdDH4kpT4BINiPIp3ZBL2wq/2u7LFS1lulMp/TaMFrIYn IM99XoFVKjpaJ/wSV3wZ6uVYYwMmrLVslPc2bB2wv1p8f5WR1WJ/ars/cxnVX3E0/LH1 2rHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:reply-to:user-agent :mime-version:date:message-id; bh=wgGaFxIF1oi2tTwFUOJ+nZCixN56kzvF7Rs9c5S+wOU=; fh=YnRgZyWh/06DCoZ+4oOXq9ObXLKvVqSxa8UuI8mpYd0=; b=Ta3oxO7c9TI8sADRWrR3tqmy7JHI6+vyRCnZ7f/79a5om4Mrmk7oHRtWJPyaG7Td7p sLPLFcp82ryrJepxWng+TEBlr4Sw9DMspR08N/7BVdjEmWrm3RjukHr6Z9YRChqLkubt O2eAeouIgk3FtE0edbgQTVRuaX/C6mVnb+QQzU/OzVeutNH5T+Stc1NgxBCAn93/y0fs h+VWvVnEtY4bGCYCwkUrrn0nm5CF+xYTcZ5wV/HPKByrvYD2qYBUDmIsnegSohVa21/N /MS+elvHqSbdKQ8v/Q/5YIVcpJb9Mx+SfDZHEoL/iheUU2uuxv23lv0BixBgeUThSUoM AjEA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d22-20020aa7d696000000b0051dec4bd870si7408135edr.101.2023.07.13.07.10.00; Thu, 13 Jul 2023 07:10:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229494AbjGMNsP (ORCPT + 99 others); Thu, 13 Jul 2023 09:48:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229436AbjGMNsM (ORCPT ); Thu, 13 Jul 2023 09:48:12 -0400 Received: from wp530.webpack.hosteurope.de (wp530.webpack.hosteurope.de [80.237.130.52]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6640719B4; Thu, 13 Jul 2023 06:48:10 -0700 (PDT) Received: from [2a02:8108:8980:2478:8cde:aa2c:f324:937e]; authenticated by wp530.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) id 1qJwfi-0003Ca-Qb; Thu, 13 Jul 2023 15:47:54 +0200 Message-ID: <573023b6-4320-2c8d-b1ec-75d542590db0@leemhuis.info> Date: Thu, 13 Jul 2023 15:47:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Reply-To: Linux regressions mailing list Subject: Re: [PATCH] sparc: mark __arch_xchg() as __always_inline Content-Language: en-US, de-DE To: Arnd Bergmann Cc: "David S. Miller" , Kees Cook , Mark Rutland , "Peter Zijlstra (Intel)" , Arnd Bergmann , Guenter Roeck , Geert Uytterhoeven , Ingo Molnar , Andi Shyti , Andrzej Hajda , Palmer Dabbelt , sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, Sam Ravnborg References: <20230628094938.2318171-1-arnd@kernel.org> <20230628155103.GA214400@ravnborg.org> From: "Linux regression tracking (Thorsten Leemhuis)" In-Reply-To: <20230628155103.GA214400@ravnborg.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-bounce-key: webpack.hosteurope.de;regressions@leemhuis.info;1689256090;9d0540f3; X-HE-SMSGID: 1qJwfi-0003Ca-Qb X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28.06.23 17:51, Sam Ravnborg wrote: > On Wed, Jun 28, 2023 at 11:49:18AM +0200, Arnd Bergmann wrote: >> From: Arnd Bergmann >> >> An otherwise correct change to the atomic operations uncovered an >> existing bug in the sparc __arch_xchg() function, which is calls >> __xchg_called_with_bad_pointer() when its arguments are unknown at >> compile time: >> >> ERROR: modpost: "__xchg_called_with_bad_pointer" [lib/atomic64_test.ko] undefined! >> >> This now happens because gcc determines that it's better to not inline the >> function. Avoid this by just marking the function as __always_inline >> to force the compiler to do the right thing here. >> >> Reported-by: Guenter Roeck >> Link: https://lore.kernel.org/all/c525adc9-6623-4660-8718-e0c9311563b8@roeck-us.net/ >> Fixes: d12157efc8e08 ("locking/atomic: make atomic*_{cmp,}xchg optional") >> Signed-off-by: Arnd Bergmann > Reviewed-by: Sam Ravnborg > > I assume you will find a way to apply the patch. Hmmm, looks to me like this patch is sitting here for two weeks now without having made any progress. From a quick search on lore it also looks like Dave is not very active currently. Hence: Arnd, is that maybe something that is worth sending straight to Linus? Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) -- Everything you wanna know about Linux kernel regression tracking: https://linux-regtracking.leemhuis.info/about/#tldr If I did something stupid, please tell me, as explained on that page.