Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 13 Jul 2023 15:55:14 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Vignesh Viswanathan <quic_viswanat@quicinc.com>
Cc:     mani@kernel.org, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, linux-arm-msm@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        quic_srichara@quicinc.com, quic_clew@quicinc.com
Subject: Re: [PATCH net-next 2/3] net: qrtr: ns: Change nodes radix tree to
 xarray
Message-ID: <ZLAQUhAw4yqEW6Y6@corigine.com>
References: <20230712112631.3461793-1-quic_viswanat@quicinc.com>
 <20230712112631.3461793-3-quic_viswanat@quicinc.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230712112631.3461793-3-quic_viswanat@quicinc.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?S2NkkFI2iW0RalOoDHj4L7tqq+/Ni/g3iZ6SPc8f6oyZN5eLVCzzl5/rquNU?=
 =?us-ascii?Q?nLdhKJODIzGXCsVd7PMhqQvWGnSSypflrwGfotPFpKrWAWNLlWo1nAag0rXL?=
 =?us-ascii?Q?vviYMrqP21+BYtCPcx0JvAogO9XPE9rP/pJDB4c8L5zKUgeivQy+NL5NnCbb?=
 =?us-ascii?Q?FykZr+Qkldk6g2SHNZ2vqXn/LcRaTfAXdmOVrWQkizYTaGFCjNzROhd3nGy/?=
 =?us-ascii?Q?GQLmbYq1qKneqe5Fi8MSizGST6yaCjjsZrulrbKDCwiJRELv2YbuRgqZK2mB?=
 =?us-ascii?Q?THTcNjcaLStGMYcQlaz470+j76AoxMVNYOdpg0Dn4bd5/69Y9Sc0tdEVDG8+?=
 =?us-ascii?Q?g4ludrb2XukVF+EI+R0Hk6IYDIqEuHGxnJJaOxixcWM2D5GbSS0ONbjAFsvq?=
 =?us-ascii?Q?updqEPIZvGqi3E44xEbNF/8h5A19pW9PVakcdZdC6My40HJMcGxk+XNBc2rn?=
 =?us-ascii?Q?WZnAs2Slf8/Auo4iuwhAVZwvitqWJTyHutDb65d2QFi22AgjoA0Vgc62UO29?=
 =?us-ascii?Q?BVbmYR20DniRwC0536fMuSvbJoGtuud2BgDmtB+5LhlVd+DnCTXOSTy9H56S?=
 =?us-ascii?Q?AjPH1o5A8NBCOZM7Hec6hmo5HXH8ZIf1wWD6l2W+7hCcGIqAfbd342BqjsuC?=
 =?us-ascii?Q?bYd7Gngn86DCqBrEUZTbTWie34dlOOWqezUC1Vqcd0hPPzhIzTyNfkoj7zPN?=
 =?us-ascii?Q?DS570qDdpHG6jbAKmx9XCwvFiJ5S80icxBF6mtPTwwpnmxdyaqIspYis0mTW?=
 =?us-ascii?Q?jBqcwXiB5hZz17IfG4p72cwadNejuR5xbsl9TlyYSPhU7nTuQYZ+M33iT/eD?=
 =?us-ascii?Q?qhdm7I5dWlU4Ihu45++K3ban4qq7UyZRRPs8LxPDb3cQjGdWhFs33tTK4tMU?=
 =?us-ascii?Q?R9zayFn4EJ9E3oeYuRUnOfRwhWagE5G8wFMZfM3qOlJRTK48lbzXQJsB7hEX?=
 =?us-ascii?Q?jZiWdUPtWelzMRkd9ip4mpNqYRJYcbgPuUHhbh8NOb+7ToyOk3zYaweGK6x/?=
 =?us-ascii?Q?DO57LeGMwAUpLdgwNeDBG7BlseMRWIO4dpXcertbWUauwhyQqhXiCxgyHkPy?=
 =?us-ascii?Q?LHQRP4AfQBqsgWboGG+ipEI70e19sf3BOVkBIZaFnK0C+U8AeHkJlxRndAJb?=
 =?us-ascii?Q?Gy0Q2cnh6DtPRc6/ngqga7PUhmuXBfFnghv6aEUsYZ0DNNWDQAGFtSTx2STs?=
 =?us-ascii?Q?FuCoK0x+dVkerdmcqDTvK9aDsMmG2vkVNcderxwyU7099yTF3lQdrrt2apmR?=
 =?us-ascii?Q?k+3SgznNJx70crY2w3G76kgVavxkSNbm2yrXva2CybAJGxBdPIm/f5s0zfwY?=
 =?us-ascii?Q?R/VELKF5s2A3eow85MGRJ3wfSgQ9tpe+MCGeRda9pwblVgBJAPKhuFTwrH0a?=
 =?us-ascii?Q?ROG3bO88fmIe9GT0KJJKRLLwy3nrsrI3PMtUlPHtsctLor9/Gd9BdKHvgAs1?=
 =?us-ascii?Q?3QmlYCYYI5EMZ5PtzaYti7c6okG34kdFMjAVUBDV/SG3URFAOU6QyFJA3KYJ?=
 =?us-ascii?Q?OGiMkax8dzOH/lKiSaWTSa1Uh+vR+6KB8iL0Lm0Q61+akR3xgF9+RQ5Bmqmz?=
 =?us-ascii?Q?2NZFIZJVxg5o0K1utnlfoJqVnGs2DDXtVT9aCjAeFiDs155bZXRjNsxzjgPw?=
 =?us-ascii?Q?bA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1c42915a-4a18-437f-edda-08db83b12e92
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 14:55:21.8490
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rWpjNFrmhdwNKMz9ygt8W0XqL4p1RC+JWYTtdrCweg8SQwbawuvx0wiLyN7UDpm5JG2yhl0Tfg7SnC5QPz7XxVThCz4OjiwGK/jwMItUjd4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR13MB3712
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jul 12, 2023 at 04:56:30PM +0530, Vignesh Viswanathan wrote:
> There is a use after free scenario while iterating through the nodes
> radix tree despite the ns being a single threaded process. This can
> happen when the radix tree APIs are not synchronized with the
> rcu_read_lock() APIs.
> 
> Convert the radix tree for nodes to xarray to take advantage of the
> built in rcu lock usage provided by xarray.
> 
> Signed-off-by: Chris Lew <quic_clew@quicinc.com>
> Signed-off-by: Vignesh Viswanathan <quic_viswanat@quicinc.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>