Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <04a96ba2-6952-e6de-93a2-dc2998ce519d@infradead.org>
Date:   Thu, 13 Jul 2023 08:42:53 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH net-next v2] net: tcp: support to probe tcp receiver OOM
Content-Language: en-US
To:     menglong8.dong@gmail.com, edumazet@google.com, ncardwell@google.com
Cc:     davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
        corbet@lwn.net, dsahern@kernel.org, kuniyu@amazon.com,
        morleyd@google.com, imagedong@tencent.com, mfreemon@cloudflare.com,
        mubashirq@google.com, netdev@vger.kernel.org,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230713112404.2022373-1-imagedong@tencent.com>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20230713112404.2022373-1-imagedong@tencent.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 7/13/23 04:24, menglong8.dong@gmail.com wrote:
> diff --git a/Documentation/networking/ip-sysctl.rst b/Documentation/networking/ip-sysctl.rst
> index 4a010a7cde7f..3de2dce74037 100644
> --- a/Documentation/networking/ip-sysctl.rst
> +++ b/Documentation/networking/ip-sysctl.rst
> @@ -694,6 +694,20 @@ tcp_retries2 - INTEGER
>  	RFC 1122 recommends at least 100 seconds for the timeout,
>  	which corresponds to a value of at least 8.
>  
> +tcp_oom_retries - INTEGER
> +	RTO retransmissions count of the receiver is recognised as OOM.
> +	Given a value N, a hypothetical TCP connection will enter probe
> +	state if N times RTO retransmissions performed and every
> +	retransmission gets a pure ack, who doesn't contain SACK block.

	                           ACK
> +
> +	The default value is 0, which means disable the OOM detection.
> +	If disabled, skb will be dropped directly, without sending an
> +	ACK, when rmem schedule fails. The function is valid only if sack

	                                                             SACK

> +	is enabled.
> +
> +	3 is the suggested value to enable this function. Do't make it

	                                                  Don't

> +	greater than tcp_retries2.

-- 
~Randy