Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 13 Jul 2023 17:23:16 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Sameer Pujar <spujar@nvidia.com>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [RFT PATCH 1/2] arm64: tegra: correct audio-codec interrupt flag
 in P2972-0000
Message-ID: <ZLAW5MbvvNDI5xVG@orome>
References: <20230705064903.12690-1-krzysztof.kozlowski@linaro.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="xksoUh4HTTxon0ro"
Content-Disposition: inline
In-Reply-To: <20230705064903.12690-1-krzysztof.kozlowski@linaro.org>
User-Agent: Mutt/2.2.10 (2023-03-25)
Precedence: bulk


--xksoUh4HTTxon0ro
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jul 05, 2023 at 08:49:02AM +0200, Krzysztof Kozlowski wrote:
> GPIO_ACTIVE_x flags are not correct in the context of interrupt flags.
> These are simple defines so they could be used in DTS but they will not
> have the same meaning: GPIO_ACTIVE_HIGH =3D 0 =3D IRQ_TYPE_NONE.
>=20
> Correct the interrupt flags to a value used also in Tegra30 Beaver board
> with this device.
>=20
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Sameer,

I can help test this if you're busy, but I don't know how to test
whether this work correctly. Can you share how we can validate this?

Thierry

>=20
> diff --git a/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts b/arch/ar=
m64/boot/dts/nvidia/tegra194-p2972-0000.dts
> index 64a3398fe7a6..7c400e024332 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts
> +++ b/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts
> @@ -2115,7 +2115,7 @@ rt5658: audio-codec@1a {
>  				compatible =3D "realtek,rt5658";
>  				reg =3D <0x1a>;
>  				interrupt-parent =3D <&gpio>;
> -				interrupts =3D <TEGRA194_MAIN_GPIO(S, 5) GPIO_ACTIVE_HIGH>;
> +				interrupts =3D <TEGRA194_MAIN_GPIO(S, 5) IRQ_TYPE_EDGE_FALLING>;
>  				clocks =3D <&bpmp TEGRA194_CLK_AUD_MCLK>;
>  				clock-names =3D "mclk";
>  				realtek,jd-src =3D <2>;
> --=20
> 2.34.1
>=20

--xksoUh4HTTxon0ro
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmSwFuQACgkQ3SOs138+
s6EF8hAAu0zsCKA2Yrn6/fsfj3JiENpzFXVJ6Yp5vT6S1nGw3AT8rC0z0Ex0GQnJ
/pFFGSRZxL5rvdEntN8p8vGiciXSe8Cq6GFVVY21nAhoBXRUtR/6P1gNQaXsOS8B
xy/ItfGo1eb4/lFb4tfei3wYDHtn2LphlpI3vaS0eHLgccIm3qpQfC/dAB7VZ7Dl
Kmup0EG9cbdMj/OOtRu8SDi05taM11mIafNIafY3qgVlSmb4myCfu4Na0ugoKfXE
t+072lN2PXlaCwEWDYk0Njsl+HD7aYF3vFE9vTcGlblIftRfSIQslN88VZLQ2Gnd
QAFYqRKsKr0zLWFqBMI5WXK/BZg2/JjvLld0apJ9G22JqumMETTEs66eLNWy37jn
z5jU51ZfM9iqx7DzNdcC+YwEjQr99JFp4LDP0Xj+i5/0rpl7s8JothGdRgSSPIBu
qYoNrQsl4OV65Vg3oZEye/bzhBz0XkuRX9IMqo9VWHZ1GfXpFqbpNhwphycqTiXh
UGEOa6nw3+bXpLToP4/x+3ixnp6ktQixFbbTpVeqqDWlvYEJE9igUffMubtKUvS4
J4N8ddNL5mnW1hy86F+csNnR9ubDUWtacaYOlasDRD2pWUn++EDaCMHqqt7yA3h0
zzdr5z9ZjBUb5hNMPq0Z4kJu9VZhp86EggIZE7zvJeCodSG46Y0=
=41Bt
-----END PGP SIGNATURE-----

--xksoUh4HTTxon0ro--