Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp1312766rwp; Thu, 13 Jul 2023 09:03:37 -0700 (PDT) X-Google-Smtp-Source: APBJJlHpVn1zy6uuW85Y7etOWFw4V6jVlo066h11asl8P0OD6SVCPa/7R+yicRe/BMv84JH4/PfT X-Received: by 2002:aa7:9307:0:b0:678:7744:31fd with SMTP id cz7-20020aa79307000000b00678774431fdmr211492pfb.0.1689264216888; Thu, 13 Jul 2023 09:03:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689264216; cv=none; d=google.com; s=arc-20160816; b=yBQr30IYKzGbafBXFSKy43w2VEOtNJDUkWqjxEQBBgwHEHzPkLqNJYMaRtCFr0YUVD 1KfaRwNICdxcN/drV1yhRvinii1/3N0sbP6qIcvTOKzn84Su2lRkk5lOrEFeXdKufYZ2 ncCT3pyGfRuU3zt8TmeB4uv8nVhCftfKtAOox+0FJC1L8+xKIZUrYlHtpTYDudu+fDpI j0A4kwvvs5EtbyDh3vBKpYiAJoSJOnfZ1qRWxZi/ikMfSq73O1ykv9zcyTjBZ70cEM6R 6Bm9Uc8o7TM281aOEsGV3yDy3iJAFMiU+nC3haBvy4UX8JV1hRImwxV7O25fCGSL0HFG rvvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=VyRH9MeI+JFFA7ahncFOE79xGcVfpSmVH0MWtNjM2Is=; fh=OYJWNq13xaBR9w6MscoFCmQBQnLw0Ogbc8Bn7ASxHyc=; b=jDf6g0vNG3p6qSFTEKXgWVrmjVdKpcGtwK7bzfzhH1AT9QHOGGq4bg8Wtnw12Yiqt4 i+6TS6gI3wtTsiZifQhzyieOyBhTlCj1R09YX58zZFYCK8QnLRQgq4EyNNEsNbaOmx6C LWnCrHdj9ZZZ8T1sVDrnCynjxespHVXKGn66F4sG16gYQeNSnJNxfqIcnfjEg1J6wuWo Vu+luEQ+rUS2W8iQP1jXkx9FCM3soNK0GKZJTeuDADLW3xXuP2gbyvG+Kpj0mPuUx1JT s9+u8W3lQtJ7rt16sVg2wiV+EOcLcuw3vUNORKUXgTemaAzkIJjmmKfAeDmGryB3+LnW df/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="VEfNf/xl"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a16-20020a056a001d1000b0067b51fca490si5221405pfx.248.2023.07.13.09.03.24; Thu, 13 Jul 2023 09:03:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="VEfNf/xl"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233454AbjGMPmC (ORCPT + 99 others); Thu, 13 Jul 2023 11:42:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229454AbjGMPmB (ORCPT ); Thu, 13 Jul 2023 11:42:01 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABCCD2682; Thu, 13 Jul 2023 08:42:00 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 40C0461993; Thu, 13 Jul 2023 15:42:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 11ADAC433C8; Thu, 13 Jul 2023 15:41:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689262919; bh=f7uSaM8HqDoMtq+Sp4ZbubCoj2iMR2/SgaP/2QzJxCc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VEfNf/xlW8ZmhIJIvKVCJCvbG/QMk3Gw0KqPagMlVi1zr/W3Y8M/zteVr3D08umt2 RgRjQ43OolpY9jWWjQ/E5gE8J30GEOYP97cISWrefkZm3QSiFrMmAe2aTfKJHFPU5B WtUFZnACcqaqsTWSJ2pksYOMVzuOyC/UBxPD5485zlXgSawwOhdgAzNF+BtQMkeExN olvCc1gY3yFT4wsT4HCB3UfKy8oT3c6bFKSXpe8QHG4FRjjOE2mWpxgvLjWn7KXla5 TTt3LcK0zAzwPM//FFhIZVs9wigEL/uacwD67bJ0sVgx3FYI/1NB754YbS4rQF3Nik 4K6ayrtFqCqzg== Date: Thu, 13 Jul 2023 16:41:55 +0100 From: Lee Jones To: Henning Schild Cc: Pavel Machek , Hans de Goede , Mark Gross , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: Re: [PATCH 2/2] leds: simatic-ipc-leds-gpio: fix comment style in SPDX header Message-ID: <20230713154155.GE968624@google.com> References: <20230706161040.21152-1-henning.schild@siemens.com> <20230706161040.21152-3-henning.schild@siemens.com> <20230712115252.GA10768@google.com> <20230712141013.67140778@md1za8fc.ad001.siemens.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230712141013.67140778@md1za8fc.ad001.siemens.net> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 12 Jul 2023, Henning Schild wrote: > Am Wed, 12 Jul 2023 12:52:52 +0100 > schrieb Lee Jones : > > > On Thu, 06 Jul 2023, Henning Schild wrote: > > > > > This was found with giving the file to checkpatch. > > > > > > Signed-off-by: Henning Schild > > > --- > > > drivers/leds/simple/simatic-ipc-leds-gpio.h | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/leds/simple/simatic-ipc-leds-gpio.h > > > b/drivers/leds/simple/simatic-ipc-leds-gpio.h index > > > bf258c32f83d..3d4877aa4e0c 100644 --- > > > a/drivers/leds/simple/simatic-ipc-leds-gpio.h +++ > > > b/drivers/leds/simple/simatic-ipc-leds-gpio.h @@ -1,4 +1,4 @@ > > > -// SPDX-License-Identifier: GPL-2.0 > > > +/* SPDX-License-Identifier: GPL-2.0 */ > > > > What prompted this change? > > > > % git grep -F "// SPDX-License-Identifier:" -- drivers/leds | wc -l > > 117 > > % git grep -F "/* SPDX-License-Identifier:" -- drivers/leds | wc -l > > 2 > > > > ./scripts/checkpatch.pl --no-tree --file > drivers/leds/simple/simatic-ipc-leds-gpio.h > > it boils down to header versus c-file, not sure why headers prefer that > other style Ah yes, that one. Okay. -- Lee Jones [李琼斯]