Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Jay Vosburgh <jay.vosburgh@canonical.com>
To:     Wang Ming <machel@vivo.com>
cc:     Andy Gospodarek <andy@greyhouse.net>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Yufeng Mo <moyufeng@huawei.com>,
        Guangbin Huang <huangguangbin2@huawei.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        opensource.kernel@vivo.com
Subject: Re: [PATCH net v1] net:bonding:Fix error checking for debugfs_create_dir()
In-reply-to: <20230713033607.12804-1-machel@vivo.com>
References: <20230713033607.12804-1-machel@vivo.com>
Comments: In-reply-to Wang Ming <machel@vivo.com>
   message dated "Thu, 13 Jul 2023 11:35:54 +0800."
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <24869.1689263355.1@famine>
Content-Transfer-Encoding: quoted-printable
Date:   Thu, 13 Jul 2023 08:49:15 -0700
Message-ID: <24870.1689263355@famine>
Precedence: bulk

Wang Ming <machel@vivo.com> wrote:

>The debugfs_create_dir() function returns error pointers,
>it never returns NULL. Most incorrect error checks were fixed,
>but the one in bond_create_debugfs() was forgotten.
>
>Fix the remaining error check.
>
>Signed-off-by: Wang Ming <machel@vivo.com>

	Seems fine to me; note that almost nobody uses this as bonding
debugfs is hidden behind !CONFIG_NET_NS.

Acked-by: Jay Vosburgh <jay.vosburgh@canonical.com>

	-J

>Fixes: 52333512701b ("net: bonding: remove unnecessary braces")
>---
> drivers/net/bonding/bond_debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/bonding/bond_debugfs.c b/drivers/net/bonding/bon=
d_debugfs.c
>index 594094526648..d4a82f276e87 100644
>--- a/drivers/net/bonding/bond_debugfs.c
>+++ b/drivers/net/bonding/bond_debugfs.c
>@@ -88,7 +88,7 @@ void bond_create_debugfs(void)
> {
> 	bonding_debug_root =3D debugfs_create_dir("bonding", NULL);
> =

>-	if (!bonding_debug_root)
>+	if (IS_ERR(bonding_debug_root))
> 		pr_warn("Warning: Cannot create bonding directory in debugfs\n");
> }
> =

>-- =

>2.25.1
>
>