Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 13 Jul 2023 11:52:51 -0400
From:   "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To:     Peng Zhang <zhangpeng.00@bytedance.com>
Cc:     maple-tree@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: Maple Tree Work
Message-ID: <20230713155251.etx3ypziiufunnmo@revolver>
References: <20230707163815.ns4kdz7iut5octjv@revolver>
 <0152143a-b105-a413-ddf2-47f688633d97@bytedance.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <0152143a-b105-a413-ddf2-47f688633d97@bytedance.com>
User-Agent: NeoMutt/20220429
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?KJXfmLTHbSvG1sM5YY2W+mhkf2+sZ2255wVWGRmJUM2Ycm79fzvgJ8DsPjOF?=
 =?us-ascii?Q?CRGgd+YEcxCGyta+Zv5iPwsokUMP3NyOg73/o6A3m2rUKqLdjXG0SI+idKfH?=
 =?us-ascii?Q?u/lDFBryyaCEK0vTH8R4vvwxeYJVC6Dvd09bbADIQk0uT7AqePUpRsXd+ZR/?=
 =?us-ascii?Q?BRfw0W7plRkujRpPyQEeafTGXOaC6C6ICAj+yj+pptLaZhC8ZpTkA+CZ9W+d?=
 =?us-ascii?Q?21uKHIx3uqmfDjETuKBPoixxT9HD34LyNV6qbcADYzh0TXajemZqRDw9NY+k?=
 =?us-ascii?Q?eNFSJKv082C/fUfc3CXQvbbhP3w6rj1xJPyFxqeslg7swEWb08lg2cDKF4X7?=
 =?us-ascii?Q?azpOfKlLsVDFYnsAaQkXegSo92Bnsud6oFNQivjDX1R+G59BOTZzCiGwA0Lu?=
 =?us-ascii?Q?TiwChD24rIpzAKqlJevEfBvOsR6ZgV5aUa8dyhNJSLrza5PECaRU/tgg3Wxx?=
 =?us-ascii?Q?jfXuvMByNxl0q0MRTDF8luYH3I3NyxHfCzJ261uq+acn74Z3ZLlyP+UoWAin?=
 =?us-ascii?Q?ofNPREy8ObhPVq16v0Ao6huG5Ack9/z8rHADm9CwWTJs+rkLxXONoRdJk+9g?=
 =?us-ascii?Q?9BVFOIQeB95Vswxrn3mCYQUZkUB75jyzFV2jalDCB5w3BE2mL/PchEq+ACn2?=
 =?us-ascii?Q?XgjyB9hAThjTnoBJl+SftSEjPAH8yucRKffPIsvZyoYtUxpVhzwA0UgLijA/?=
 =?us-ascii?Q?vf7QQCw+zw6tgADUGHaQcmQLa0s79nACrkqekL0bu+Oi5gzX64SJN9QhG1KV?=
 =?us-ascii?Q?2dbp9druy1s4qCbE5xBbeSUbDQM1Rwzq4SqEAqiSYvxyJyTzDyL157Yw+jHp?=
 =?us-ascii?Q?aIQBEXftfsPCZ667rM2l4U3NDtn3/er+/7JKc+fINsSinatYIkom6WxGAIZa?=
 =?us-ascii?Q?IkA9cDf7XYpgz7xmugrpLyAs4PqfSB9Wn73x3Pj1/vmAgdWcdRvE/2oL44Gs?=
 =?us-ascii?Q?kDsBla5CR4saNYhhRUTrP5vbs0QZN51TJi/t4mIdualkOtghY5E1YSDHhBA2?=
 =?us-ascii?Q?rodqXyRuSrYQTFoBWbnGypm2B78FStukphbTkltzQDRQI3JBrOk60SIpww6k?=
 =?us-ascii?Q?DVg9E9aQ4bMTwO68YZ8mSDMp3bOSVL6OMBO/aZABG4fpy8ZBBAxh+o3VsIMT?=
 =?us-ascii?Q?CnE8ACYDNoyk2mD2vxPT/OSCXhBx9TnQwtobuw/ea/2i8FMbCiWwgqVIe0ps?=
 =?us-ascii?Q?hDTe3frl5hrTcKS41pM+6FVQNcgTsahOSkyklsnGZVY2SsDyI2btfRJ78DNQ?=
 =?us-ascii?Q?cSCMb5rgd5levMZMNvJqIz/B1GKDR6nwQmht+J6YvWlIHEiDfeqjbVdGis3I?=
 =?us-ascii?Q?EgzKgxk+BpSMDYqqxuMs3apdqv2IK2Hg7BHoCcwCuzlcRvMdZVPKSkvow3zY?=
 =?us-ascii?Q?1VKa2cxQx+iVxb4/ldrG/IfM1eZA17R2XBeaoRQYsNDYa2+uh4Z03NLhmW78?=
 =?us-ascii?Q?LCpIAfkNc+jiku2n4divOsmfdDFcxZB2r7SY+vaRcoacvyToeJjiGxntoHG/?=
 =?us-ascii?Q?G1mXs1TdEN9dfwxWxaLv866ymjI+bLqclbK7oe/1h/7nzcDqn202iyn3ngxW?=
 =?us-ascii?Q?2GnFG2S1+glqf4RENDT2hED2eGa14nsMXWWXgfpwC3/SNKkMhJ/Q1OQ/Ejow?=
 =?us-ascii?Q?qw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: LvYRlBASVTdEclmlSJXFNNmWAXnjiq3RdYr/x5Kw5+SD8AWXZQVYPJx8mIFmefvPVYuywV0sOx7m9soAFptInUWaC7XBEAxLmq2oAYiuk3LprgSsMV5RCLDjTb7bOARUsc76XMrm0Fdlemd0nldSlttJbqRJicF1X6MNMFxWz+9ibTvl4AFLCSQXDt8b0lcrPusKYr0XS1wid4JS/Fje2MAfJniKocHQO6jI+V93ba9Uxz2X5+hn9Js6L7iojQ/Ok20gN4hFp6jL/f0DguBdJQ8cenzgu9EP5fs6bd3WPViNZ8a54GBwKcbCeocYkC/KFZloI2FC9f7o8TGTXq0rBn7HZu3HsokXZodYQHEN70EXzEl6Rn/XOcCIOV7HSuBEbzQBNGvVdU2tYBQPvFpAwoKmTzp6uYMIOzKTumRWUDfvJ9e1Mez4Pwi5OpRQxMm25ab5wxyKEi65Hl6ykJXPZmuReZ4dY2Juo70ASJDUVlJV5V5gllRkiaBL9/tGHQQ6rG9vfI04+O6wFKrE0o5w+OPNu5l/oijtyZtEqQpym7OhnDSBOYLg04rO6jxmIqBathcnDQ6ysdL3PJ3ej9/ZqwQX5QdeR+5rRuxyKtqxpQI5AGvZhr/PGNlbwJmDc7H+H0b+Gc/SkXBYE0bsk5xFVQquSk2SdDpIJffUPdqj/b6tLOr4610DS8/tagT+as4wnU6IKGcEH7t+EHbsbIPWE/icjwqPVSkp9FxaDbXa27RgbDMibD4HRxEgZwR1JKwnYJo3Mt8rbO1Xa2gWeKu2gJFCvTm7j9knOHSR313o7aopqeZnJSc7VKHjYJVOaeWnWfdWDefk6noHweomoLPbxXQrbPNmI2dMBYcBSFvOjhc=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b5fe44c-000b-4151-35e4-08db83b9380e
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 15:52:53.7374
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oafYE+mIrdZhcDJ1D/6r4sz1mkOJV212+bJsv1AFf5FLxSBy+1OOcxd0IIv04gtAxRflV5fMUiPB3T8vaiTFow==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4590
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-13_06,2023-07-13_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=521
 adultscore=0 mlxscore=0 suspectscore=0 malwarescore=0 phishscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2305260000 definitions=main-2307130140
X-Proofpoint-GUID: aIyjw1cAfstvYq8n77MmyqLLwu6jjjov
X-Proofpoint-ORIG-GUID: aIyjw1cAfstvYq8n77MmyqLLwu6jjjov
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Peng Zhang <zhangpeng.00@bytedance.com> [230713 05:58]:
> I have a question I want to discuss here. I noticed that the interface
> of maple tree has three different prefixes, namely mtree_*, mt_*, mas_*.
> I am curious why the interfaces prefixed with mtree_* and mt_* cannot be
> unified? I think they can be changed to mtree_* to avoid two different
> prefixes.
> 

I am sure there was a reason.. looking at the documentation, it may have
been to indicate rcu/write locking..  But the entire interface doesn't
fit that reasoning.  We can probably align the mt_ and mtree_ all to be
mt_.

If we do, and we probably should, we'll have to change other places in
the kernel and the documentation.

The mas_ is the advanced interface so locking isn't handled, and
internally, the mas_ indicates the first argument is a struct ma_state
pointer.

I can add this to the list as well.

Thanks,
Liam