Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9a1062c3-f5be-ea69-0672-cf1a44be7e03@intel.com>
Date:   Thu, 13 Jul 2023 09:05:03 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Betterbird/102.12.0
Subject: Re: [PATCH v3] ntb: Remove error checking for debugfs_create_dir()
To:     Wang Ming <machel@vivo.com>, Jon Mason <jdmason@kudzu.us>,
        Allen Hubbe <allenbh@gmail.com>,
        Serge Semin <fancer.lancer@gmail.com>,
        Dan Carpenter <error27@gmail.com>,
        Jiasheng Jiang <jiasheng@iscas.ac.cn>, <ntb@lists.linux.dev>,
        <linux-kernel@vger.kernel.org>
CC:     <opensource.kernel@vivo.com>, <dan.carpenter@linaro.org>
References: <20230713085621.3380-1-machel@vivo.com>
Content-Language: en-US
From:   Dave Jiang <dave.jiang@intel.com>
In-Reply-To: <20230713085621.3380-1-machel@vivo.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?clU4K09LSTd0ZW5WbFZqTWZseEhPc21RblpDZHF6UDVJVXE0Nkc5d0IwSHNW?=
 =?utf-8?B?OWNJNCtMRmk5aUVyYmw4SUJQV1piSnpyeW13NVhrVGNCYVB3M2JFVXRhMEg1?=
 =?utf-8?B?Ris1angwUnI5dTZYVGhyMm5Vd2djUGc1NHVYVlJDOHN1OE9SNld3ZWxRdnNw?=
 =?utf-8?B?TEc2aEdReGlHQ0QyOUxsTFMySGEwQ2hWajFER3lYZkVhSVp4VmRCV3hQMnJG?=
 =?utf-8?B?S3hXbjkySkJKSUZnU2xjY093THNKSFNwYUtIK21OVHdacks3ejRaOFBjRml2?=
 =?utf-8?B?RnFRYnJDczdURXRibW9qaEdCd1JOUUJCZGlXQWd2aWoxUzJwZzlTdEpMRDIw?=
 =?utf-8?B?OXJWN2pacVpZWWJVTWZHY29mV0s5Vk1mSEorR1VYVFV2dGlsb3pybkp3SUxm?=
 =?utf-8?B?ak1XRExVcUltcEUxL255VnVBRTgvRkZJV0VabzZnemRRaWtETTNNRjVQTnBL?=
 =?utf-8?B?bytyYnRuUkdRd29RUTZwalhRZk4xUDhPTkJqYmwyTXRIL3R6RGdlcGpNR044?=
 =?utf-8?B?ak0zc3kySUtRWVpxeUtLQTEvNHBuYkV1MVVuNTZJOHc1Mnhwam5lL1FoQk5F?=
 =?utf-8?B?Zkt3UHJURTVHc2RwdFhEUGgrbkhLUyt0RHZ5K1ZuZXJRdzd3c2tiZzkxY0Y5?=
 =?utf-8?B?YUtlK3YwRGwyQWFRL1cxemFpR0ozbUNQTkV0ZWdqK2crTkRaY2ZObUd1a0k1?=
 =?utf-8?B?VS9UekN0UWJSMWZBUkl3anB4aTVIZGk5NnQ3SU1PYzVocnJzV1k5QW5qTTJY?=
 =?utf-8?B?UHB5T1JndHUzWERwZzkwQUhkNnc0YmdsWHBiU0RIc3VuNlJudk85U3JuYk85?=
 =?utf-8?B?TG9JR0VqaTEzYnhGVnFtUXI1VHE1V1dhQmFLaExzdlVWUkZjWVBQM042WE5w?=
 =?utf-8?B?ODA1dXJmc1g1NTRoM3RtMXVoM3czL2dvdmlsRWIybHd2bDhIczlORnZCY2h6?=
 =?utf-8?B?Q1NWQndxbVpaUVQwUU42L1FDWDQxaUZWOTl3eHc5eW1BdmdJOFh3eU9KWGsx?=
 =?utf-8?B?dVNpR0xKZ0dmTWRXUEtyT0oyZ3ppcXBObDlkR2hlSXBEQ3RzOFBIRU95M1B3?=
 =?utf-8?B?ZCtqcW92ZXU2VzB5bVhpVDJROVFjbWp5a0RUWjdnMHdvTSt3ZFgzb1dlODJ3?=
 =?utf-8?B?R2tpVXNLUUdSc1YydEhyVWZZTVlON21FNC9mSnRrZEhiQURWSytFdGRBMFlQ?=
 =?utf-8?B?TjBRcitGdXVRNHd1eFJ0K09YQStkbmY5VHh1SVZDRUpFMEpPVUR3aHpreDFy?=
 =?utf-8?B?c0E5djQ4VVpjZVRJUHVJMFZwWEl2VmxlUFlzT2hESHg0RXUxb3VEWmkzZDNM?=
 =?utf-8?B?V2RXZ2pBYjRnU3ZwTmJlanFXajdjZlZ2RjlSVGJuRC8zK3lCemE0UGlZemtH?=
 =?utf-8?B?THE0QjBJNjNrek10aHYwNkdVSUdPZzZVRU41SDloTlVGdit5UkdKMFBjdE5p?=
 =?utf-8?B?R2xzbkRKZU00cmNzK0lsbHZORmtQbU5mbjkxUlVRUmlDZTBKMEh5MmI1VU1V?=
 =?utf-8?B?TmxjSlZtTzduQXA3Wmt1SjRHaUE0QTd6UmF5OC81bEFVT1F0ZmxhSkxrMUZo?=
 =?utf-8?B?TkVoLzVkemVPazRwVVpJSENXQUFoRXRLOVp2YURaejQyajNrNFEzejBuNHZn?=
 =?utf-8?B?ZTlodDlXWEhjRmFtQmtIL3QydmQvSHBHQ2E3QkpxOVFTdmdVNWpTWXZpNE50?=
 =?utf-8?B?MnAwa1dwemtYU1ZldnpCZmxOdllGTCtZVHJHVjlsT2FBOERwSGs2enQwb2d0?=
 =?utf-8?B?b05tMkJEU0ZuL1pyQ2VKMXk5aGlNemVHb21YaHFNbU5kQUI1MWtDMGJoZmtJ?=
 =?utf-8?B?R2dhZSsrMlBBVlAwUnZqMFdYbVQ5ZTd5WkZ5VXU1TElhcnNXYlBNMXpZOUFI?=
 =?utf-8?B?NWFMalE4Wm4yYmFBRUVGdUV5Qmd3MmdhRVB6dml5a0JRdUtiVS9mZFBTYWhT?=
 =?utf-8?B?b2p3YTFtd0tuKzhZNFQ5Qld4Z0p5ZlBtRE5QT29VamdWeHRuY3FXVzdnRHd0?=
 =?utf-8?B?Ykh2bDNLWEphK0loV3RlcjF4OVNjS085QkIvZlFiMDBhbllqM1hlMUNncWd1?=
 =?utf-8?B?bTRURkNHcVBucjQ5djBmMFd0U0srd1FQeHJuYjU4TGNZTkUvVndvYVpuUFha?=
 =?utf-8?Q?Oi3cKyf7//KHfDXzheWOdHey0?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 21aa58dd-ef01-43de-22d8-08db83baedd8
X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5984.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 16:05:08.3512
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2NstgdwT1ArZCicDFoKAhoVGFt9+YX0o6rUdOvMHbLrtgweyj2JSZaq35bMGqewIPYDF9xEg6vsHk10++6rbiA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7388
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/13/23 01:56, Wang Ming wrote:
> It is expected that most callers should _ignore_ the errors
> return by debugfs_create_dir() in tool_setup_dbgfs()
> 
> Signed-off-by: Wang Ming <machel@vivo.com>

Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
>   drivers/ntb/test/ntb_tool.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/ntb/test/ntb_tool.c b/drivers/ntb/test/ntb_tool.c
> index eeeb4b1c97d2..e0acc11d29ba 100644
> --- a/drivers/ntb/test/ntb_tool.c
> +++ b/drivers/ntb/test/ntb_tool.c
> @@ -1495,8 +1495,6 @@ static void tool_setup_dbgfs(struct tool_ctx *tc)
>   
>   	tc->dbgfs_dir = debugfs_create_dir(dev_name(&tc->ntb->dev),
>   					   tool_dbgfs_topdir);
> -	if (!tc->dbgfs_dir)
> -		return;
>   
>   	debugfs_create_file("port", 0600, tc->dbgfs_dir,
>   			    tc, &tool_port_fops);