Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 13 Jul 2023 17:34:24 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Christoph Niedermaier <cniedermaier@dh-electronics.com>
Cc:     "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        Support Opensource <support.opensource@diasemi.com>,
        Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Marek Vasut <marex@denx.de>,
        kernel <kernel@dh-electronics.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V5] regulator: da9062: Make the use of IRQ optional
Message-ID: <8558f2aa-09fd-4cd3-ae1e-c80893e00aa1@sirena.org.uk>
References: <20230713090328.3879-1-cniedermaier@dh-electronics.com>
 <d8f60e51-2d62-4370-9032-51eda744239d@sirena.org.uk>
 <9629970cc2c3452e83a43660823319e5@dh-electronics.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="altLkxuEsntrmcoR"
Content-Disposition: inline
In-Reply-To: <9629970cc2c3452e83a43660823319e5@dh-electronics.com>
Precedence: bulk


--altLkxuEsntrmcoR
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Jul 13, 2023 at 03:36:38PM +0000, Christoph Niedermaier wrote:
> From: Mark Brown [mailto:broonie@kernel.org]

> > Are there any dependencies for this patch?  The fact that I acked it
> > makes me think there were MFD parts

> It's a patch series. This patch is the last one in this series, that is
> missing to have the ability to run the DA9061/62 without a connected IRQ
> pin. The other patches are already upstreamed and yes there are MFD parts,
> see below:

Oh, dear.  Why weren't they applied, it's not even the confusion there
was over what Reviewed-by means...

> >> Reported-by: kernel test robot <lkp@intel.com>
> >> Link: https://lore.kernel.org/oe-kbuild-all/202303082246.GuLdPL0t-lkp@intel.com/

> > I really doubt that the LKP bot ran into an issue due to a system with
> > this device without an IRQ wired up...

> In V3 of this patch the kernel test robot found an issue. I had really
> overlooked that. Thanks to LKP. I forgot to replace the irq variable in
> the function devm_request_threaded_irq(). So it affected the path with
> IRQ. In V4 I fixed that. In V5 I only rebased it on the current next
> 20230713 and add Marek's Reviewed-by tag.

That doesn't mean you should include tags like this, it makes it look
like they reported the commit...

--altLkxuEsntrmcoR
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmSwJ48ACgkQJNaLcl1U
h9Dq2Af+JAGbntNGDLrRx3J0Mp22kYyvYDnvqfOTote2xsxDWunWrXEkSXTDp1LB
nKTTchli1wMXiQfQjtjGYlgkSu5rfetldWH+W3+pbrBkGg35l9J2Gmn77SPZqDvW
SZLVrsN2CVwuOods3ZK1kkKw4ZbFE3TC/Y3sQ0B/iK66cv2OEuzTk5Wx3wlvUNhj
pX/4cq3Y/9vgpp11fr2l5wxhllWZ0jgE413QgTBnUinO89zht6AlgLVnGIrUfuwu
YA+l4V6jmzTXj1Z+FCQJxKFfnAyOGmUYCHeq2QIgWQ7UxO2FoSXJpt6HiA4H7D64
rJQtHR6rtylZEgHFHVn7u34JjhWz8w==
=JMDM
-----END PGP SIGNATURE-----

--altLkxuEsntrmcoR--