Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp1493192rwp; Thu, 13 Jul 2023 11:40:15 -0700 (PDT) X-Google-Smtp-Source: APBJJlGXp6mzhu9mAL3WszNdf/Wl6Ds0721uxsmu1Vfihg4DmkFP/IAiVUX41FpAFDWDeQHF6K/g X-Received: by 2002:a2e:9010:0:b0:2b7:3b6c:a5e4 with SMTP id h16-20020a2e9010000000b002b73b6ca5e4mr2021950ljg.38.1689273615105; Thu, 13 Jul 2023 11:40:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689273615; cv=none; d=google.com; s=arc-20160816; b=gWAppNSam8uFmP0YLTbRL7LYqaMFDFA7K4ZbvvocRMaVXSNShk4rZFfeqFbaITyA/c mE+20uxtBr3GsVzFQbVdmDhNF7Icy1mK6NSOFTFJ0DtfJTjnP5CTWaC4kaehtgV8iH4H rSPJ60kpboQkefHNXCSi0++1eouhHPC9fz1zl/kcjBmNy0r5Ey2hgoc0nWfg/I7Jx21d eIxwl/bas/9zPOdm+miMeM4UZVm5BqOMsCAhL+DnChDttac92MBlKXLa3957oXU9rzon 37FTlM1Vpnlim2A/aeVvrXPQiUxOSJO7/bGv9zkO9qVsKF1VehvwWAh0hH3KtMLnxS/V QqQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Lcuq+6kjo4mMWqUyVwg1wc/5NDWoQqDRDI/cikwpMs0=; fh=ck/ydA466UyvpoSgT4fPVDQ8jMZyGeXjEApeeAp8qQs=; b=XU5flZ1oEsZqMnqSN0N60CT4afTJrif3u2KZj7l17MXOP/miPsWA0/xA9VLKtA/Hja kjZTtZ6f7XfgBGcHDZ8yuOW9hpaOvm1R5CKLSDBRc9OQZESmfvrnjuGe1lF0CP2BZYrz hz0NPYDgmRx3A/aOp85VEgo5opaDNSSY4rEh8VoKl979V7vaBuZPFe4TxXmftBuFpVgK boa6cGWYgIV6ykoGVl55KtuwrvIY50FQPo/9L5H3BSJFA1K0DtKv2pmcN6qlg065jeh9 ZUZ56Pl02pKNv/FrxyiemY9ljkvkMLWx8ncPMImUyf3Dygj54Tsx1Q7JufTlcqtmGYuJ 8A/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=l+RUf9Sk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p9-20020a170906140900b00993689daad1si8013830ejc.116.2023.07.13.11.39.43; Thu, 13 Jul 2023 11:40:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=l+RUf9Sk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229715AbjGMRzl (ORCPT + 99 others); Thu, 13 Jul 2023 13:55:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229953AbjGMRzk (ORCPT ); Thu, 13 Jul 2023 13:55:40 -0400 Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8BBDC2724 for ; Thu, 13 Jul 2023 10:55:39 -0700 (PDT) Received: by mail-pg1-x52f.google.com with SMTP id 41be03b00d2f7-55ae2075990so628390a12.0 for ; Thu, 13 Jul 2023 10:55:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1689270939; x=1691862939; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Lcuq+6kjo4mMWqUyVwg1wc/5NDWoQqDRDI/cikwpMs0=; b=l+RUf9Sk1CRCyytEozXVY9Zh9d+5T2wtWB6i64A9tVvsjRLq53C8QWmIkid+xfjOBm FVrc/hxHiBHVvJNqbXXjO7H0OSyHNWJLO0Lw5POjXgWqFhp3PJ1BWCnQoJDZOqKaTXcM clsQhopvW5e8UTjlJT5c40ztVAWNyqOutqXWA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689270939; x=1691862939; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Lcuq+6kjo4mMWqUyVwg1wc/5NDWoQqDRDI/cikwpMs0=; b=khHv0rd4H9UMyx5KR2Lm8uy96fNR3Oqg8scz08ta0BC6TC7MWmbLPYCU/HS1tHI9zD RZvHmJGUd/u4vsHMZXCt10a/dUa0bUGNKJOw1QihsvEI5MPkk3uC+v/UayXS8NJi5fp+ 782ZWF90Z+zKdA7+o/Khh/AYitYH3VmZIvOU5ZWpapludV1VxmtsUBwThXVKk8+LChN1 ADAvbNzc/NPBWGEfLfGJ2lq2uVxBKdDExvLsRKHnVHH39zp7JjYqdYukw3C/Tpx/0qo2 SaQhfuwZu6VA08r9wDWBCS1MZ1L4NX0Rq4jI/iDLP0VpJP7f72qYOpVFrmzFPxfJ9cwc hxFw== X-Gm-Message-State: ABy/qLZ6eSBKWWLxqH37Voq12s3Mxek+Q1RrdAl14rcwIVZu70ahAn1R KzVnJXwoj3l04tnAcOTiq2Dt0A== X-Received: by 2002:a17:90a:cb04:b0:263:3386:9da8 with SMTP id z4-20020a17090acb0400b0026333869da8mr1265390pjt.49.1689270939075; Thu, 13 Jul 2023 10:55:39 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id w4-20020a17090a6b8400b00263fd82106asm6166532pjj.35.2023.07.13.10.55.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jul 2023 10:55:38 -0700 (PDT) From: Kees Cook To: "David S. Miller" , Mark Rutland , "Peter Zijlstra (Intel)" , Arnd Bergmann Cc: Kees Cook , Arnd Bergmann , Guenter Roeck , Geert Uytterhoeven , Ingo Molnar , Andi Shyti , Andrzej Hajda , Palmer Dabbelt , sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sparc: mark __arch_xchg() as __always_inline Date: Thu, 13 Jul 2023 10:55:24 -0700 Message-Id: <168927092021.199206.6500280471313894142.b4-ty@chromium.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230628094938.2318171-1-arnd@kernel.org> References: <20230628094938.2318171-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 28 Jun 2023 11:49:18 +0200, Arnd Bergmann wrote: > An otherwise correct change to the atomic operations uncovered an > existing bug in the sparc __arch_xchg() function, which is calls > __xchg_called_with_bad_pointer() when its arguments are unknown at > compile time: > > ERROR: modpost: "__xchg_called_with_bad_pointer" [lib/atomic64_test.ko] undefined! > > [...] Applied, thanks! [1/1] sparc: mark __arch_xchg() as __always_inline https://git.kernel.org/kees/c/ec7633de404e Best regards, -- Kees Cook