Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6e73aaab-fd2e-f9c4-0826-16643717694e@kernel.dk>
Date:   Thu, 13 Jul 2023 12:13:58 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v5] blk-mq: fix start_time_ns and alloc_time_ns for
 pre-allocated rq
Content-Language: en-US
To:     Tejun Heo <tj@kernel.org>,
        Chengming Zhou <chengming.zhou@linux.dev>
Cc:     hch@lst.de, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org, ming.lei@redhat.com,
        zhouchengming@bytedance.com
References: <20230710105516.2053478-1-chengming.zhou@linux.dev>
 <aa813164-9a6a-53bd-405b-ba4cc1f1b656@kernel.dk>
 <63f93f1c-98da-4c09-b3d8-711f6953d8b7@linux.dev>
 <ZLA7QAfSojxu_FMW@slm.duckdns.org>
From:   Jens Axboe <axboe@kernel.dk>
In-Reply-To: <ZLA7QAfSojxu_FMW@slm.duckdns.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/13/23 11:58?AM, Tejun Heo wrote:
> It's a bit out of scope for this patchset but I think it might make
> sense to build a timestamp caching infrastructure. The cached
> timestamp can be invalidated on context switches (block layer already
> hooks into them) and issue and other path boundaries (e.g. at the end
> of plug flush).

This is a great idea! Have the plug init start with the timestamp
invalid, and use some blk_get_time() helpers that return the time for no
plug, and set it in the plug if not set. Flushing the plug would mark it
invalid again.

This obviously won't help the no plugging cases, but those are not that
interesting in comparison.

-- 
Jens Axboe