Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230516122202.954313-1-alex@shruggie.ro>
In-Reply-To: <20230516122202.954313-1-alex@shruggie.ro>
From:   Alexandru Ardelean <alex@shruggie.ro>
Date:   Thu, 13 Jul 2023 23:07:40 +0300
Message-ID: <CAH3L5QoBqSOBHhoxSrYw6U34gqTPEhi_RB_Cve-YmBzYj3LXAQ@mail.gmail.com>
Subject: Re: [PATCH][V2] sched/rt: Print curr when RT throttling activated
To:     linux-kernel@vger.kernel.org
Cc:     mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
        vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
        rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
        bristot@redhat.com, vschneid@redhat.com, tian.xianting@h3c.com,
        steffen.aschbacher@stihl.de, gregkh@linuxfoundation.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, May 16, 2023 at 3:22=E2=80=AFPM Alexandru Ardelean <alex@shruggie.r=
o> wrote:
>
> From: Xianting Tian <tian.xianting@h3c.com>
>
> We may meet the issue, that one RT thread occupied the cpu by 950ms/1s,
> The RT thread maybe is a business thread or other unknown thread.
>
> Currently, it only outputs the print "sched: RT throttling activated"
> when RT throttling happen. It is hard to know what is the RT thread,
> For further analysis, we need add more prints.
>
> This patch is to print current RT task when RT throttling activated,
> It help us to know what is the RT thread in the first time.
>

Adding Greg on this patch, since it 's been a while.
And also: ping :)

> Tested-by: Alexandru Ardelean <alex@shruggie.ro>
> Signed-off-by: Xianting Tian <tian.xianting@h3c.com>
> ---
>
> Initial patch submission:
>   https://lore.kernel.org/all/f3265adc26d4416dacf157f61fa60ad6@h3c.com/T/
>
> We've been having some issues of our own with some applications + some RT
> configuration =3D=3D some threads endded up taking too much CPU time.
> This patch came in quite in handy to see in logs which thread is more
> problematic.
>
> We've applied this patch onto a 5.10.116 tree. It did need a bit of
> re-applying since some context has changed since the initial version (hen=
ce
> the V2 tag).
> Since 5.10.116 (where we used it), it applied nicely to the latest/curren=
t
> linux-next tree (hence the Tested-by tag).
>
> It would be nice to apply this to the mainline kernel and have this handy=
.
>
>  kernel/sched/rt.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
> index 00e0e5074115..44b161e42733 100644
> --- a/kernel/sched/rt.c
> +++ b/kernel/sched/rt.c
> @@ -995,7 +995,7 @@ static inline int rt_se_prio(struct sched_rt_entity *=
rt_se)
>         return rt_task_of(rt_se)->prio;
>  }
>
> -static int sched_rt_runtime_exceeded(struct rt_rq *rt_rq)
> +static int sched_rt_runtime_exceeded(struct rt_rq *rt_rq, struct task_st=
ruct *curr)
>  {
>         u64 runtime =3D sched_rt_runtime(rt_rq);
>
> @@ -1019,7 +1019,8 @@ static int sched_rt_runtime_exceeded(struct rt_rq *=
rt_rq)
>                  */
>                 if (likely(rt_b->rt_runtime)) {
>                         rt_rq->rt_throttled =3D 1;
> -                       printk_deferred_once("sched: RT throttling activa=
ted\n");
> +                       printk_deferred_once("sched: RT throttling activa=
ted (curr: pid %d, comm %s)\n",
> +                                               curr->pid, curr->comm);
>                 } else {
>                         /*
>                          * In case we did anyway, make it go away,
> @@ -1074,7 +1075,7 @@ static void update_curr_rt(struct rq *rq)
>                 if (sched_rt_runtime(rt_rq) !=3D RUNTIME_INF) {
>                         raw_spin_lock(&rt_rq->rt_runtime_lock);
>                         rt_rq->rt_time +=3D delta_exec;
> -                       exceeded =3D sched_rt_runtime_exceeded(rt_rq);
> +                       exceeded =3D sched_rt_runtime_exceeded(rt_rq, cur=
r);
>                         if (exceeded)
>                                 resched_curr(rq);
>                         raw_spin_unlock(&rt_rq->rt_runtime_lock);
> --
> 2.40.1
>