Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f17f5330-9b8f-81a2-508f-8cc25c355590@linuxfoundation.org>
Date:   Thu, 13 Jul 2023 13:33:48 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v1] tools: timers: fix freq average calculation
Content-Language: en-US
To:     John Stultz <jstultz@google.com>, Minjie Du <duminjie@vivo.com>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Stephen Boyd <sboyd@kernel.org>, Shuah Khan <shuah@kernel.org>,
        "open list:TIMEKEEPING, CLOCKSOURCE CORE, NTP, ALARMTIMER" 
        <linux-kernel@vger.kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>, opensource.kernel@vivo.com,
        Shuah Khan <skhan@linuxfoundation.org>
References: <20230706032257.1662-1-duminjie@vivo.com>
 <CANDhNCoJ2ZjGCY3yZ3K4XZF8-bNTExOUWNkqWtJ2FZW=bYFwzw@mail.gmail.com>
From:   Shuah Khan <skhan@linuxfoundation.org>
In-Reply-To: <CANDhNCoJ2ZjGCY3yZ3K4XZF8-bNTExOUWNkqWtJ2FZW=bYFwzw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 7/5/23 21:46, John Stultz wrote:
> On Wed, Jul 5, 2023 at 8:23 PM Minjie Du <duminjie@vivo.com> wrote:
>>
>> Delete a duplicate assignment from this function implementation.
>> The note means ppm is average of the two actual freq samples.
>> But ppm have a duplicate assignment.
>>
>> Signed-off-by: Minjie Du <duminjie@vivo.com>
>> ---
>>   tools/testing/selftests/timers/raw_skew.c | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/tools/testing/selftests/timers/raw_skew.c b/tools/testing/selftests/timers/raw_skew.c
>> index 5beceeed0..6eba203f9 100644
>> --- a/tools/testing/selftests/timers/raw_skew.c
>> +++ b/tools/testing/selftests/timers/raw_skew.c
>> @@ -129,8 +129,7 @@ int main(int argc, char **argv)
>>          printf("%lld.%i(est)", eppm/1000, abs((int)(eppm%1000)));
>>
>>          /* Avg the two actual freq samples adjtimex gave us */
>> -       ppm = (tx1.freq + tx2.freq) * 1000 / 2;
>> -       ppm = (long long)tx1.freq * 1000;
>> +       ppm = (long long)(tx1.freq + tx2.freq) * 1000 / 2;
> 
> Huh. So yeah, I looked back in my own history and this has been there
> forever. I'm guessing I was intending to average the two samples and
> then due to reasons I can't remember decided to just use the first in
> the short-term for some debugging (with the second assignment) and
> committed both.
> 
> I think it should be safe, because if the freq values are not the same
> the test will return SKIP, so it's unlikely changing this would cause
> new test failures.
> 
> Acked-by: John Stultz <jstultz@google.com>
> 
> Thanks for noticing this and sending this out!
> -john

Applied to linux-kselftest fixes branch for next rc2 or rc3

thanks,
-- Shuah