Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates
 216.228.117.161 as permitted sender) receiver=protection.outlook.com;
 client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C
Message-ID: <785e1c1c-84d8-e87d-f22f-9a53d27f30f6@nvidia.com>
Date:   Thu, 13 Jul 2023 13:16:55 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH] selftests: Fix arm64 test installation
To:     Shuah Khan <skhan@linuxfoundation.org>,
        Mark Brown <broonie@kernel.org>, Shuah Khan <shuah@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Anders Roxell <anders.roxell@linaro.org>,
        Muhammad Usama Anjum <usama.anjum@collabora.com>,
        Ryan Roberts <ryan.roberts@arm.com>
CC:     <linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>
References: <20230710-kselftest-fix-arm64-v1-1-48e872844f25@kernel.org>
 <8d944238-1a9a-e93e-fdab-54e74fa12e11@linuxfoundation.org>
Content-Language: en-US
From:   John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <8d944238-1a9a-e93e-fdab-54e74fa12e11@linuxfoundation.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 20:17:15.5832
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 83644ebf-14db-437b-5545-08db83de26ac
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT068.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB5453
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/13/23 13:02, Shuah Khan wrote:
> On 7/10/23 08:04, Mark Brown wrote:
...
>> -kernel_header_files:
>> -    @ls $(KHDR_DIR)/linux/*.h >/dev/null 2>/dev/null;                      \
>> -    if [ $$? -ne 0 ]; then                                                 \
>> -            RED='\033[1;31m';                                                  \
>> -            NOCOLOR='\033[0m';                                                 \
>> -            echo;                                                              \
>> -            echo -e "$${RED}error$${NOCOLOR}: missing kernel header files.";   \
>> -            echo "Please run this and try again:";                             \
>> -            echo;                                                              \
>> -            echo "    cd $(top_srcdir)";                                       \
>> -            echo "    make headers";                                           \
>> -            echo;                                                              \
>> -        exit 1; \
>> -    fi
>> -
>> -.PHONY: kernel_header_files
>> +all: $(TEST_GEN_PROGS) $(TEST_GEN_PROGS_EXTENDED) $(TEST_GEN_FILES)
>>   define RUN_TESTS
>>       BASE_DIR="$(selfdir)";            \
>>
>> ---
>> base-commit: 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5
>> change-id: 20230710-kselftest-fix-arm64-c023160018d7
>>
>> Best regards,
> 
> Thank you. Will apply the patch for the next rc
> 
> thanks,
> -- Shuah

Hi Shuah,

Actually, I was hoping that my two fixes [1], [2] could be used, instead
of reverting the feature.


[1] https://lore.kernel.org/all/20230711005629.2547838-1-jhubbard@nvidia.com/

[2] https://lore.kernel.org/all/20230712193514.740033-1-jhubbard@nvidia.com/


thanks,
-- 
John Hubbard
NVIDIA